Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CA+0=VoVVenJMdBohkoE_AbxwGuoV8Uif=PKe=vZcJ4Z_6J=4Xg@mail.gmail.com>
References: <82616AF7-6502-42E9-8123-5FDF5AB4E57D@apache.org>
 <CABuYRcrLwYid6rb4_hbkqnNKv_EHzHtmGthUS-tRV7ewTZVVRA@mail.gmail.com>
 <CAPzXPXpZhgfp_GtHratU5qS1ZcS9w-Sc3CvRWMs1qx0uyYHxDw@mail.gmail.com>
 <CAPzXPXp5jqAJ9DnyFw7bVvPpYiZMXaC1y_+OUDR1YjCHrK1PDg@mail.gmail.com>
 <CA+0=VoUzFyq+Pa5o0d3s2sk30dFOmWhmZBrg2JEr8keY0gD=zA@mail.gmail.com> <CA+0=VoVVenJMdBohkoE_AbxwGuoV8Uif=PKe=vZcJ4Z_6J=4Xg@mail.gmail.com>
From: Dmitriy Govorukhin <dmitriy.govorukhin@gmail.com>
Date: Tue, 15 Aug 2017 11:45:33 +0300
Message-ID: <CAPzXPXo8iqwhHnzhWSC0hUhxvXPq1GUPecgZUGPY3pGNUw8vfA@mail.gmail.com>
Subject: Re: Control.sh script and cluster activation
To: dev@ignite.apache.org
Cc: Dmitriy Setrakyan <dsetrakyan@gridgain.com>
Content-Type: multipart/alternative; boundary="001a11476c3c6f973c0556c6cd9f"
archived-at: Tue, 15 Aug 2017 08:45:40 -0000

--001a11476c3c6f973c0556c6cd9f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Folks,

I created jira issue for the current discussion IGNITE-6064
<https://issues.apache.org/jira/browse/IGNITE-6064>, leave you comment
please.

On Tue, Aug 15, 2017 at 11:32 AM, Dmitriy Setrakyan <dsetrakyan@apache.org>
wrote:

> Added one more suggestion below. BTW, if there is no ticket, let's create
> one and copy all the suggestions there.
>
> On Tue, Aug 15, 2017 at 1:13 AM, Dmitriy Setrakyan <dsetrakyan@apache.org=
>
> wrote:
>
> > Guys,
> >
> > Where is the ticket for adding control.[sh|bat] script to the bin folde=
r?
> > I cannot find any mention of it. Was there a discussion on the dev list=
?
> >
> > Here are the issues I am seeing with the script:
> >
> >    1. It could be named better. Perhaps the name "cluster-ops" or
> >    "cluster-switch" would be better. We should rename it in the next
> release.
> >    2. typing any bad command, e.g. "control bla" should provide a
> >    standard usage message explaining correct syntax (see any other
> command
> >    under bin folder)
> >    3. failure to connect to the cluster results in a long stack trace..=
.
> >    instead, it should provide a standard error message, suggesting
> possible
> >    reasons for it.
> >
> > 4. Whenever trying to connect to a cluster, the script should print out=
 a
> message "Connecting to ip-address:port ...". Otherwise, it looks like it =
is
> just hanging.
>
>
> > D.
> >
> > On Tue, Aug 15, 2017 at 12:59 AM, Dmitriy Govorukhin <
> > dmitriy.govorukhin@gmail.com> wrote:
> >
> >> Valentin,
> >>
> >> We have jira issue for this IGNITE-5586
> >> <https://issues.apache.org/jira/browse/IGNITE-5586>
> >>
> >> On Tue, Aug 15, 2017 at 10:56 AM, Dmitriy Govorukhin <
> >> dmitriy.govorukhin@gmail.com> wrote:
> >>
> >> >
> >> > Denis,
> >> >
> >> > 1. control.sh have help parameter. If you try enter ./control.sh
> --help,
> >> > result is an example of how to use it,
> >> > "Example: --host {ip} --port {port} --{activate/deactivate} or witho=
ut
> >> > command --host {ip} --port {port} then will print status"
> >> >
> >> > 2. Visorcmd will start daemon node and join in topology, it is quite
> >> long
> >> > time(as you know nodes joining in series) and requires resources.
> >> > Main goal was create some point for activation, fast and lightweight=
,
> >> > script does not start node.
> >> >
> >> > 3. Historically, the first name(control.sh - controls cluster
> >> > state active/inactive).  Have any idea for another name?
> >> >
> >> > On Tue, Aug 15, 2017 at 2:25 AM, Valentin Kulichenko <
> >> > valentin.kulichenko@gmail.com> wrote:
> >> >
> >> >> Agree that this is confusing. I think this functionality should be =
a
> >> part
> >> >> of Visor CLI tool (likely a new command there).
> >> >>
> >> >> -Val
> >> >>
> >> >> On Mon, Aug 14, 2017 at 4:21 PM, Denis Magda <dmagda@apache.org>
> >> wrote:
> >> >>
> >> >> > Dmitriy,
> >> >> >
> >> >> > I see you contributed control.sh script that activates a cluster
> >> after a
> >> >> > restart. Honestly, I=E2=80=99m a bit confused by it:
> >> >> >
> >> >> > 1. How to use it? I could find out that there are some of the
> >> parameters
> >> >> > but the =E2=80=98help=E2=80=99 is not implemented. Please fix thi=
s and provide a
> >> >> > description for every parameter you introduced.
> >> >> >
> >> >> > 2. Why did we decide to create a specific script for that? Why
> can=E2=80=99t
> >> we
> >> >> > use existing visorcmd script?
> >> >> >
> >> >> > 3. Why the script called =E2=80=9Ccontrol.sh=E2=80=9D?
> >> >> >
> >> >> > =E2=80=94
> >> >> > Denis
> >> >>
> >> >
> >> >
> >>
> >
> >
>

--001a11476c3c6f973c0556c6cd9f--