Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DA93A20049D for ; Wed, 9 Aug 2017 15:49:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D8F69166CCE; Wed, 9 Aug 2017 13:49:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 28A57163E47 for ; Wed, 9 Aug 2017 15:49:50 +0200 (CEST) Received: (qmail 85239 invoked by uid 500); 9 Aug 2017 13:49:49 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 85227 invoked by uid 99); 9 Aug 2017 13:49:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Aug 2017 13:49:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 80974C036C for ; Wed, 9 Aug 2017 13:49:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.379 X-Spam-Level: X-Spam-Status: No, score=0.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id xPv_JmdOJgIZ for ; Wed, 9 Aug 2017 13:49:47 +0000 (UTC) Received: from mail-lf0-f42.google.com (mail-lf0-f42.google.com [209.85.215.42]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id C58995F6BF for ; Wed, 9 Aug 2017 13:49:46 +0000 (UTC) Received: by mail-lf0-f42.google.com with SMTP id d17so28344874lfe.0 for ; Wed, 09 Aug 2017 06:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=PIrgr4ULHDCDQdHoPpKByNYmDKozpiTK+hCiiA01LQk=; b=iHl7Cg8DV5raABrzlikbVsMobFcjapKEqybC4aefSg7xVivpROiPkWjN4vJX7+SnpZ JyfqcQOiMqObA80ZenslmcCm/tp0vnsn0QstaDG25FgGZoTn3w071dkfA30bSe8+fF9k hAdgTy3X2Yjj0BfpxryHoMLvVDCnCs2R8xSqbetPL5l8mMgKRnIlA/slSks/Gmu7NKUF HFyQtNlxFm/GsqJxmXNBaAbQ7HYgTOoakhNqh2RPKhdXaLpYbhS7kb3fau+K636/kLsU MSqRcfLUWlWXUqBNzFtgvukBDKljKrsLhLbdf5qKg9Uv1APR9+wm/DB8tuhbT0n07sVi IrIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=PIrgr4ULHDCDQdHoPpKByNYmDKozpiTK+hCiiA01LQk=; b=dxmXOyQZDpAysDjbuDTk8XmEP8OhsZjKh/lhKgYpxK5AP8//TW1VRbe1kbWGLlq2+w JEfeY9R5qQ/0CfJXolAcfcDIeFYI9dHzRcamPE4hjVk99L/c6kCVPkTUtJDFgvHch+OH GZa5wDIdh1Dj0qk45+zNVzEBkmXOXE2tZN8yOLd7GKBTja1m3Wd7K1IqrIxPjhvkq679 6/Y7GwIFJlS9TgN8X1Os3rct7V30jaXa5d2GRLzPox4H5kKbIFZr7zwBVdX2Q8rapF3k D1zYfdRnpfM0GjAkBztuBFC6qvyaefzWl7HMXYDcaiqOWslvAK3ubz35/vjipTki2F/B d+eg== X-Gm-Message-State: AHYfb5it8PovW8xWR0qoQ+Y6RxrAdQy2lUlV1OBUn0cEJ0fqU97sZHaG 54kYdepTP2Gx+iVn9Uw= X-Received: by 10.46.9.16 with SMTP id 16mr3043161ljj.155.1502286585948; Wed, 09 Aug 2017 06:49:45 -0700 (PDT) Received: from [10.38.151.147] ([194.186.207.251]) by smtp.gmail.com with ESMTPSA id s126sm657673lja.33.2017.08.09.06.49.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Aug 2017 06:49:45 -0700 (PDT) From: Kozlov Maxim Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: Add isPrimary() and isBackup() methods on CacheQueryEntryEvent Date: Wed, 9 Aug 2017 16:49:44 +0300 References: <197DA001-1B67-4B21-9A4C-5CD0BD0121BC@gmail.com> <5A8431D2-2EBD-4070-932A-2E5FEBB261B1@gmail.com> To: dev@ignite.apache.org In-Reply-To: <5A8431D2-2EBD-4070-932A-2E5FEBB261B1@gmail.com> Message-Id: X-Mailer: Apple Mail (2.3273) archived-at: Wed, 09 Aug 2017 13:49:51 -0000 Igniters, What do you think about the new API? > 3 =D0=B0=D0=B2=D0=B3. 2017 =D0=B3., =D0=B2 15:56, Kozlov Maxim = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):= >=20 > Guys,=20 >=20 > I'm sorry for the misunderstanding, I was tired at the end of the day = :-) > In the process of working on the task, I had to add 2 methods to the = public interface. > The first method is #isBackup(), it returns 'true' if cache is being = updated on the backup node. > The second method is #isPrimary(), it returns 'true' if cache is being = updated on the primary node. > Their main purpose is to show where a continuous query filter has been = invoked. >=20 > Any thoughts about such solution? >=20 >> 3 =D0=B0=D0=B2=D0=B3. 2017 =D0=B3., =D0=B2 14:45, Anton Vinogradov = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >>=20 >> Folks, >>=20 >> As far as I see, Issue still in PatchAvailable state, what did you = mean by >> "solved"? >>=20 >> On Wed, Aug 2, 2017 at 8:01 PM, Kozlov Maxim = wrote: >>=20 >>> Sure. >>>=20 >>> CacheQueryEntryEvent: >>>=20 >>> public abstract boolean isBackup(); >>> public abstract boolean isPrimary(); >>>=20 >>>=20 >>>> 2 =D0=B0=D0=B2=D0=B3. 2017 =D0=B3., =D0=B2 19:56, Nikolai Tikhonov = >>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>=20 >>>> Max, >>>>=20 >>>> Thank you for your contribution! Could you share here what exactly = was >>>> added to interface? >>>>=20 >>>> On Wed, Aug 2, 2017 at 7:53 PM, Kozlov Maxim >>> wrote: >>>>=20 >>>>> Igniters, >>>>>=20 >>>>> When you solved the 3878[1] ticket, two methods were added[2]: >>> isPrimary() >>>>> and isBackup() on the CacheQueryEntryEvent in a public API. Do you = agree >>>>> with this decision? >>>>>=20 >>>>> [1] https://issues.apache.org/jira/browse/IGNITE-3878 < >>>>> https://issues.apache.org/jira/browse/IGNITE-3878> >>>>> [2] https://github.com/apache/ignite/pull/1393 < >>> https://github.com/apache/ >>>>> ignite/pull/1393> >>>>>=20 >>>>> -- >>>>> Best Regards, >>>>> Max K. >>>>>=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>=20 >>> -- >>> Best Regards, >>> Max K. >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >=20 > -- > Best Regards, > Max K. >=20 >=20 >=20 >=20 -- Best Regards, Max K.