Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: Control.sh script and cluster activation
From: Denis Magda <dmagda@apache.org>
In-Reply-To: <CAPzXPXo8iqwhHnzhWSC0hUhxvXPq1GUPecgZUGPY3pGNUw8vfA@mail.gmail.com>
Date: Tue, 15 Aug 2017 16:13:01 -0700
Cc: Dmitriy Setrakyan <dsetrakyan@gridgain.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <130AF69C-64B3-44F2-A77A-D9D4622ADBC7@apache.org>
References: <82616AF7-6502-42E9-8123-5FDF5AB4E57D@apache.org>
 <CABuYRcrLwYid6rb4_hbkqnNKv_EHzHtmGthUS-tRV7ewTZVVRA@mail.gmail.com>
 <CAPzXPXpZhgfp_GtHratU5qS1ZcS9w-Sc3CvRWMs1qx0uyYHxDw@mail.gmail.com>
 <CAPzXPXp5jqAJ9DnyFw7bVvPpYiZMXaC1y_+OUDR1YjCHrK1PDg@mail.gmail.com>
 <CA+0=VoUzFyq+Pa5o0d3s2sk30dFOmWhmZBrg2JEr8keY0gD=zA@mail.gmail.com>
 <CA+0=VoVVenJMdBohkoE_AbxwGuoV8Uif=PKe=vZcJ4Z_6J=4Xg@mail.gmail.com>
 <CAPzXPXo8iqwhHnzhWSC0hUhxvXPq1GUPecgZUGPY3pGNUw8vfA@mail.gmail.com>
To: dev@ignite.apache.org
archived-at: Tue, 15 Aug 2017 23:13:06 -0000

Add a documentation requirement. Ping me when the ticket is about to be =
closed.

In the meanwhile, I=E2=80=99ll try to document the existing behavior.

=E2=80=94
Denis

> On Aug 15, 2017, at 1:45 AM, Dmitriy Govorukhin =
<dmitriy.govorukhin@gmail.com> wrote:
>=20
> Folks,
>=20
> I created jira issue for the current discussion IGNITE-6064
> <https://issues.apache.org/jira/browse/IGNITE-6064>, leave you comment
> please.
>=20
> On Tue, Aug 15, 2017 at 11:32 AM, Dmitriy Setrakyan =
<dsetrakyan@apache.org>
> wrote:
>=20
>> Added one more suggestion below. BTW, if there is no ticket, let's =
create
>> one and copy all the suggestions there.
>>=20
>> On Tue, Aug 15, 2017 at 1:13 AM, Dmitriy Setrakyan =
<dsetrakyan@apache.org>
>> wrote:
>>=20
>>> Guys,
>>>=20
>>> Where is the ticket for adding control.[sh|bat] script to the bin =
folder?
>>> I cannot find any mention of it. Was there a discussion on the dev =
list?
>>>=20
>>> Here are the issues I am seeing with the script:
>>>=20
>>>   1. It could be named better. Perhaps the name "cluster-ops" or
>>>   "cluster-switch" would be better. We should rename it in the next
>> release.
>>>   2. typing any bad command, e.g. "control bla" should provide a
>>>   standard usage message explaining correct syntax (see any other
>> command
>>>   under bin folder)
>>>   3. failure to connect to the cluster results in a long stack =
trace...
>>>   instead, it should provide a standard error message, suggesting
>> possible
>>>   reasons for it.
>>>=20
>>> 4. Whenever trying to connect to a cluster, the script should print =
out a
>> message "Connecting to ip-address:port ...". Otherwise, it looks like =
it is
>> just hanging.
>>=20
>>=20
>>> D.
>>>=20
>>> On Tue, Aug 15, 2017 at 12:59 AM, Dmitriy Govorukhin <
>>> dmitriy.govorukhin@gmail.com> wrote:
>>>=20
>>>> Valentin,
>>>>=20
>>>> We have jira issue for this IGNITE-5586
>>>> <https://issues.apache.org/jira/browse/IGNITE-5586>
>>>>=20
>>>> On Tue, Aug 15, 2017 at 10:56 AM, Dmitriy Govorukhin <
>>>> dmitriy.govorukhin@gmail.com> wrote:
>>>>=20
>>>>>=20
>>>>> Denis,
>>>>>=20
>>>>> 1. control.sh have help parameter. If you try enter ./control.sh
>> --help,
>>>>> result is an example of how to use it,
>>>>> "Example: --host {ip} --port {port} --{activate/deactivate} or =
without
>>>>> command --host {ip} --port {port} then will print status"
>>>>>=20
>>>>> 2. Visorcmd will start daemon node and join in topology, it is =
quite
>>>> long
>>>>> time(as you know nodes joining in series) and requires resources.
>>>>> Main goal was create some point for activation, fast and =
lightweight,
>>>>> script does not start node.
>>>>>=20
>>>>> 3. Historically, the first name(control.sh - controls cluster
>>>>> state active/inactive).  Have any idea for another name?
>>>>>=20
>>>>> On Tue, Aug 15, 2017 at 2:25 AM, Valentin Kulichenko <
>>>>> valentin.kulichenko@gmail.com> wrote:
>>>>>=20
>>>>>> Agree that this is confusing. I think this functionality should =
be a
>>>> part
>>>>>> of Visor CLI tool (likely a new command there).
>>>>>>=20
>>>>>> -Val
>>>>>>=20
>>>>>> On Mon, Aug 14, 2017 at 4:21 PM, Denis Magda <dmagda@apache.org>
>>>> wrote:
>>>>>>=20
>>>>>>> Dmitriy,
>>>>>>>=20
>>>>>>> I see you contributed control.sh script that activates a cluster
>>>> after a
>>>>>>> restart. Honestly, I=E2=80=99m a bit confused by it:
>>>>>>>=20
>>>>>>> 1. How to use it? I could find out that there are some of the
>>>> parameters
>>>>>>> but the =E2=80=98help=E2=80=99 is not implemented. Please fix =
this and provide a
>>>>>>> description for every parameter you introduced.
>>>>>>>=20
>>>>>>> 2. Why did we decide to create a specific script for that? Why
>> can=E2=80=99t
>>>> we
>>>>>>> use existing visorcmd script?
>>>>>>>=20
>>>>>>> 3. Why the script called =E2=80=9Ccontrol.sh=E2=80=9D?
>>>>>>>=20
>>>>>>> =E2=80=94
>>>>>>> Denis
>>>>>>=20
>>>>>=20
>>>>>=20
>>>>=20
>>>=20
>>>=20
>>=20