Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 86E9A200CCB for ; Thu, 20 Jul 2017 10:48:15 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8555F16ADE4; Thu, 20 Jul 2017 08:48:15 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CB27316ADE3 for ; Thu, 20 Jul 2017 10:48:14 +0200 (CEST) Received: (qmail 98908 invoked by uid 500); 20 Jul 2017 08:48:13 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 98891 invoked by uid 99); 20 Jul 2017 08:48:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Jul 2017 08:48:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F02501A1BB5 for ; Thu, 20 Jul 2017 08:48:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.379 X-Spam-Level: X-Spam-Status: No, score=0.379 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id IIRKZJiase4g for ; Thu, 20 Jul 2017 08:48:11 +0000 (UTC) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id C52CB5FE43 for ; Thu, 20 Jul 2017 08:48:10 +0000 (UTC) Received: by mail-lf0-f52.google.com with SMTP id z78so9622934lff.0 for ; Thu, 20 Jul 2017 01:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=jJFNtDmKJ3CRaLL1E8aZKb/KptJe7MDRJOOUw0b/5WU=; b=ogem2V5abUGUjJQXDU+WB8oFetcIBjENF507B2sDSthv9d2vbLsmW3KiPfBO3n8AqK aPbaBmE4oEM/8Jk7S0DQtxCe55m7Xilxa3bgtpRWhV/+rIoU6LqsxByYZs9Zam8I55x8 3/kGwJnQPOUnoMawDCWgztpZAqesLX9SuskvQzqht0DSE5mFa4o45bJTwF5IYwWCFOxt XK4URKNyiuESW8tk2c1rAHdetjk5Nvp9wH6K29yuTK1FxWx0nCPr6ifM+Nfy49MpxhaQ DF4tG9gzlhVsuhRWBKO+KahuPXGnNh5hf13TXHsBN7so77uPStkR4I+CRXErSlHRLB+p rcGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=jJFNtDmKJ3CRaLL1E8aZKb/KptJe7MDRJOOUw0b/5WU=; b=rMCxSGXxawsV9FulVG8GiApe0FcmiBi8eOpaE/1T6wOx84tIozZhilQnKQLZz8D61X H2eiW2KDjczfu8fA9m31e/cQ+7jqE44nM2q1yu5zSnh5cdrgRIs/ZcHo8MwVeGyEKnp8 M32n6WWgLGu5DFLtivQi9rL0wdCMSCux+lCMmFvuwzzPurOSENJ55Z+RT9Gwo1aCIhMF ohRg+QGur2LlhYPA9+X7UycIxJNU8TQjl8FWYphbTBgRiqCtK4lIrf1BAHPa6qG0sh8s GBWLFWWQxIkKfCu9BNFUdf+Jmskxq2JEJF+/tLfE+BvubJT3sCvpo5L8s0lWhYyFeAud MD5A== X-Gm-Message-State: AIVw113wLozH0pngDlPnuCwg3v2I629YQjV6b3+c6HQJTSw979DzN2Nd +FKK5x+t8JPfXxZAnrg= X-Received: by 10.25.145.65 with SMTP id y1mr826696lfj.233.1500540489958; Thu, 20 Jul 2017 01:48:09 -0700 (PDT) Received: from [10.18.13.142] ([188.128.94.254]) by smtp.gmail.com with ESMTPSA id y18sm131611lja.56.2017.07.20.01.48.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jul 2017 01:48:09 -0700 (PDT) Subject: Re: IGNITE-5123 Review From: Evgeniy Ignatiev To: dev@ignite.apache.org References: <64f82ec2-0635-d993-51fa-bada79a61bd5@gmail.com> <27c1f0b3-9c0e-9cf9-e3e6-ec0ee3ea78e9@gmail.com> Message-ID: <4479e3e5-d450-8633-8c44-26f2523d5e33@gmail.com> Date: Thu, 20 Jul 2017 12:48:08 +0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <27c1f0b3-9c0e-9cf9-e3e6-ec0ee3ea78e9@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US archived-at: Thu, 20 Jul 2017 08:48:15 -0000 Rerun tests in "Run All" Ignite 2.0 group after merge with the latest master - http://ci.ignite.apache.org/viewLog.html?buildId=734705&tab=queuedBuildOverviewTab - Do you see any issues with them? (Unfortunately I have too little experience with Ignite tests to judge.) On 7/19/2017 6:25 PM, Evgeniy Ignatiev wrote: > Scheduled "Run All" in Ignite 2.0 Tests for pull/2285/head - > http://ci.ignite.apache.org/viewQueued.html?itemId=734208 > > > On 19.07.2017 17:55, Dmitry Pavlov wrote: >> Hi Evgeniy, >> >> Thank you. Ignite Basic is one suite from approximately 80 suites that >> covers Ignite by automated tests. Which is why I suggested to use RunAll >> chain in ignite 2.0 group. Yes, several tests may fail, especially if >> it is >> flaky tests or failure is related to the specific JIRA issue. >> >> About change itself: This change seems to be very impact. There is >> possiblity that many of existing plugins relies on existing order of >> initialization. This change may break plugin initialization in >> unexpected >> manner. >> >> Could we >> - fix javadoc according to existing order in code >> - find out new solution? >> >> Sincerely, >> Dmitriy Pavlov >> >> >> ср, 19 июл. 2017 г. в 16:40, Evgeniy Ignatiev >> : >> >>> http://ci.ignite.apache.org/viewLog.html?buildId=720722&tab=buildResultsDiv&buildTypeId=IgniteTests_IgniteBasic >>> >>> - this one - there seem to be no new failed platform tests, other >>> failed >>> tests seem to fail in several other reviews too and are unrelated to my >>> changes. >>> >>> >>> On 19.07.2017 17:35, Dmitry Pavlov wrote: >>>> Hi Evgeniy, >>>> >>>> I was not able to find Teamcity run for this change. >>>> Could you please run http://ci.ignite.apache.org test for example on >>> branch >>>> pull/2285/head using 'Ignite 2.0 Tests' target 'Run All'. >>>> Or could you please share link to previous run on this changes? >>>> >>>> Sincerely, >>>> Dmitriy Pavlov >>>> >>>> ср, 19 июл. 2017 г. в 15:26, Anton Vinogradov : >>>> >>>>> Igniters, >>>>> >>>>> Could somebody review the fix today? >>>>> >>>>> On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < >>>>> yevgeniy.ignatyev@gmail.com> wrote: >>>>> >>>>>> Hello, Igniters. >>>>>> >>>>>> Could anyone review my request - https://issues.apache.org/jira >>>>>> /browse/IGNITE-5123? - My previous pings seems to got lost. >>>>>> >>>>>> Best regards, >>>>>> >>>>>> Yevgeniy >>>>>> >>>>>> >>> >