ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yucigou <...@git.apache.org>
Subject [GitHub] ignite pull request #2243: IGNITE-5607: HttpSessionBindingListener is not su...
Date Wed, 05 Jul 2017 10:42:17 GMT
GitHub user yucigou opened a pull request:

    https://github.com/apache/ignite/pull/2243

    IGNITE-5607: HttpSessionBindingListener is not supported for clustere…

    Ignite WebSessionV2 uses genuineSes as the original HttpSession.
    
    Therefore, when setting an attribute or setting the maxInactiveInterval, Ignite should
tell the original HttpSession about it.
    
    Otherwise, when the web container (such as Tomcat) thinks that a session expires, or is
invalidated, or a session attribute gets removed, etc., session attributes' HttpSessionBindingListener's
valueUnbound callback function will not get fired.
    
    So once the original HttpSession gets updated with the session attributes and the maxInactiveInterval,
the web container will transitively trigger the session attributes' HttpSessionBindingListener's
valueUnbound callback function when a session expires, etc.
    
    (By the way, tested with our app, and our issue is fixed:
    http://apache-ignite-developers.2346864.n4.nabble.com/It-seems-WebSession-s-removeAttribute-does-not-support-HttpSessionBindingListener-td19184.html)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/EuropePMC/ignite master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2243
    
----
commit eaaee978d37c5a66dff2d59515ddb70c40d5e31b
Author: Yuci Gou <ygou@ebi.ac.uk>
Date:   2017-07-05T10:26:57Z

    IGNITE-5607: HttpSessionBindingListener is not supported for clustered web session

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message