ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Denis Magda <dma...@apache.org>
Subject Re: abbrevation rules plugin
Date Wed, 05 Jul 2017 23:41:44 GMT
Ok, what if we make sure the plugin is available on GitHub (not Ignite) and give a link to
it on the documentation page? This seems to be the easiest way to handle the topic.
 
—
Denis

> On Jul 5, 2017, at 4:37 PM, Dmitriy Setrakyan <dsetrakyan@apache.org> wrote:
> 
> On Wed, Jul 5, 2017 at 4:35 PM, Denis Magda <dmagda@apache.org> wrote:
> 
>> Dmitriy,
>> 
>> I’m not suggesting to add the JAR to the source code or to any binary
>> package but rather treat it as a third party plugin developed by someone
>> for Ignite’s development simplification. It’s similar to the way the
>> community uses Intellij IDEA’s plugins or Team City or many other maven
>> modules imported in the project - they don’t need to be a part of Ignite
>> sources or binaries to be used.
>> 
> 
> In this case AI should not host the download itself, but provide a link for
> the plugin to be downloaded elsewhere. If AI hosts it and distributes it,
> then it needs to be built from the source code.
> 
> 
>> 
>> —
>> Denis
>> 
>>> On Jul 5, 2017, at 4:13 PM, Dmitriy Setrakyan <dsetrakyan@apache.org>
>> wrote:
>>> 
>>> Denis,
>>> 
>>> Apache cannot have any binary files anywhere in its code bases. All
>> binary
>>> JARs must be produced from a build process. If we are adding this plugin,
>>> then the source for it needs to be committed to AI code base and the JAR
>>> should be generated from the build.
>>> 
>>> Once the JAR is generated, only then you can include it on a web page to
>>> download.
>>> 
>>> D.
>>> 
>>> On Wed, Jul 5, 2017 at 3:19 PM, Denis Magda <dmagda@apache.org> wrote:
>>> 
>>>> Guys,
>>>> 
>>>> Let’s make things simple and attach the jar of the plugin to the wiki
>> page
>>>> that refers to it:
>>>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules <
>>>> https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules>
>>>> 
>>>> This should be fine from ASF standpoint.
>>>> 
>>>> —
>>>> Denis
>>>> 
>>>>> On Jul 5, 2017, at 9:58 AM, Dmitriy Setrakyan <dsetrakyan@apache.org>
>>>> wrote:
>>>>> 
>>>>> Hi Dmitriy,
>>>>> 
>>>>> The answer is No. We should put it as a source code and integrate it
>> into
>>>>> our build procedure.
>>>>> 
>>>>> D.
>>>>> 
>>>>> On Wed, Jul 5, 2017 at 9:46 AM, Dmitry Pavlov <dpavlov.spb@gmail.com>
>>>> wrote:
>>>>> 
>>>>>> Hi Igniters,
>>>>>> 
>>>>>> Could you please share your opinion about this topic?
>>>>>> 
>>>>>> The question is as follows: Is it allowed to place abbreviation plugin
>>>> as
>>>>>> jar file into ignite source code? Abbrev-plugin.jar is jar file and
I
>> am
>>>>>> not aware if it is allowed to place jars in git.
>>>>>> 
>>>>>> Sincerely,
>>>>>> Dmitriy Pavlov
>>>>>> 
>>>>>> 
>>>>>> ср, 5 июл. 2017 г. в 12:55, Dmitry Pavlov <dpavlov.spb@gmail.com>:
>>>>>> 
>>>>>>> Hi, I have created https://issues.apache.org/jira/browse/IGNITE-5698
>>>> for
>>>>>>> this task.
>>>>>>> 
>>>>>>> It is not clear for me yet how to publish correctly - is it possible
>> to
>>>>>>> publish JAR.
>>>>>>> 
>>>>>>> ср, 5 июл. 2017 г. в 11:34, ALEKSEY KUZNETSOV <
>>>> alkuznetsov.sb@gmail.com
>>>>>>> :
>>>>>>> 
>>>>>>>> Yeah, it would be very helpful.
>>>>>>>> 
>>>>>>>> вт, 4 июл. 2017 г. в 18:40, Dmitry Pavlov <dpavlov.spb@gmail.com>:
>>>>>>>> 
>>>>>>>>> Hi, Val,
>>>>>>>>> 
>>>>>>>>> No, this plugin is not available in apache-ignite code
base.
>>>>>>>>> May be we should remove reference from JIRA or add this
plugin (and
>>>>>> also
>>>>>>>>> other code inspections) into AI code base.
>>>>>>>>> Thoughts?
>>>>>>>>> 
>>>>>>>>> Sincerely,
>>>>>>>>> Dmitriy Pavlov
>>>>>>>>> 
>>>>>>>>> вт, 4 июл. 2017 г. в 1:29, Valentin Kulichenko
<
>>>>>>>>> valentin.kulichenko@gmail.com>:
>>>>>>>>> 
>>>>>>>>>> The plugin actually exists, not sure why it's not
attached. Does
>>>>>>>> anyone
>>>>>>>>> has
>>>>>>>>>> it?
>>>>>>>>>> 
>>>>>>>>>> -Val
>>>>>>>>>> 
>>>>>>>>>> On Mon, Jul 3, 2017 at 5:27 AM, ALEKSEY KUZNETSOV
<
>>>>>>>>>> alkuznetsov.sb@gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>> 
>>>>>>>>>>> Igntrs!
>>>>>>>>>>> There is a plugin , mentioned  in Abbreviation
Rules
>>>>>>>>>>> <
>>>>>>>> https://cwiki.apache.org/confluence/display/IGNITE/
>> Abbreviation+Rules
>>>>>>>>>> 
>>>>>>>>>>> page
>>>>>>>>>>> that performs on-the-fly check.Is somebody going
to add it some
>>>>>> day?
>>>>>>>>>>> --
>>>>>>>>>>> 
>>>>>>>>>>> *Best Regards,*
>>>>>>>>>>> 
>>>>>>>>>>> *Kuznetsov Aleksey*
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> --
>>>>>>>> 
>>>>>>>> *Best Regards,*
>>>>>>>> 
>>>>>>>> *Kuznetsov Aleksey*
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>> 
>>>> 
>> 
>> 


Mime
View raw message