ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Evgeniy Ignatiev <yevgeniy.ignat...@gmail.com>
Subject Re: IGNITE-5123 Review
Date Thu, 20 Jul 2017 08:48:08 GMT
Rerun tests in "Run All" Ignite 2.0 group after merge with the latest 
master - 
http://ci.ignite.apache.org/viewLog.html?buildId=734705&tab=queuedBuildOverviewTab 
- Do you see any issues with them? (Unfortunately I have too little 
experience with Ignite tests to judge.)


On 7/19/2017 6:25 PM, Evgeniy Ignatiev wrote:
> Scheduled "Run All" in Ignite 2.0 Tests for pull/2285/head - 
> http://ci.ignite.apache.org/viewQueued.html?itemId=734208
>
>
> On 19.07.2017 17:55, Dmitry Pavlov wrote:
>> Hi Evgeniy,
>>
>> Thank you. Ignite Basic is one suite from approximately 80 suites that
>> covers Ignite by automated tests. Which is why I suggested to use RunAll
>> chain in ignite 2.0 group. Yes, several tests may fail, especially if 
>> it is
>> flaky tests or failure is related to the specific JIRA issue.
>>
>> About change itself: This change seems to be very impact. There is
>> possiblity that many of existing plugins relies on existing order of
>> initialization. This change may break plugin initialization in 
>> unexpected
>> manner.
>>
>> Could we
>> - fix javadoc according to existing order in code
>> - find out new solution?
>>
>> Sincerely,
>> Dmitriy Pavlov
>>
>>
>> ср, 19 июл. 2017 г. в 16:40, Evgeniy Ignatiev 
>> <yevgeniy.ignatyev@gmail.com>:
>>
>>> http://ci.ignite.apache.org/viewLog.html?buildId=720722&tab=buildResultsDiv&buildTypeId=IgniteTests_IgniteBasic

>>>
>>> - this one - there seem to be no new failed platform tests, other 
>>> failed
>>> tests seem to fail in several other reviews too and are unrelated to my
>>> changes.
>>>
>>>
>>> On 19.07.2017 17:35, Dmitry Pavlov wrote:
>>>> Hi Evgeniy,
>>>>
>>>> I was not able to find Teamcity run for this change.
>>>> Could you please run http://ci.ignite.apache.org test for example on
>>> branch
>>>> pull/2285/head using 'Ignite 2.0 Tests' target 'Run All'.
>>>> Or could you please share link to previous run on this changes?
>>>>
>>>> Sincerely,
>>>> Dmitriy Pavlov
>>>>
>>>> ср, 19 июл. 2017 г. в 15:26, Anton Vinogradov <av@apache.org>:
>>>>
>>>>> Igniters,
>>>>>
>>>>> Could somebody review the fix today?
>>>>>
>>>>> On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev <
>>>>> yevgeniy.ignatyev@gmail.com> wrote:
>>>>>
>>>>>> Hello, Igniters.
>>>>>>
>>>>>> Could anyone review my request - https://issues.apache.org/jira
>>>>>> /browse/IGNITE-5123? - My previous pings seems to got lost.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> Yevgeniy
>>>>>>
>>>>>>
>>>
>


Mime
View raw message