ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Goncharuk (JIRA)" <j...@apache.org>
Subject [jira] [Created] (IGNITE-5554) ServiceProcessor may process failed reassignments in timeout thread
Date Tue, 20 Jun 2017 09:48:02 GMT
Alexey Goncharuk created IGNITE-5554:

             Summary: ServiceProcessor may process failed reassignments in timeout thread
                 Key: IGNITE-5554
                 URL: https://issues.apache.org/jira/browse/IGNITE-5554
             Project: Ignite
          Issue Type: Bug
          Components: managed services
    Affects Versions: 1.7
            Reporter: Alexey Goncharuk
             Fix For: 2.2

The following parts of GridServiceProcessor look wrong to me: 
In GridServiceProcessor.TopologyListener#onReassignmentFailed
@Override public void onTimeout() {
    onReassignmentFailed(topVer, retries);

And in GridServiceProcessor#onDeployment
@Override public void onTimeout() {
    // Try again.
    onDeployment(dep, topVer);

The rest of ServiceProcessor relies on the deployments being processed in a single thread,
while this code will be executed in the timeout processor thread. Not only can it take a lot
of time to reassign, which will stall the timeout thread, but it may also break the service
assignment logic.

The corresponding calls should be wrapped to runnables and submitted to the depExe.

This message was sent by Atlassian JIRA

View raw message