ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mcherkasov <...@git.apache.org>
Subject [GitHub] ignite pull request #2046: Removed DS map, all DS is added to utilityCache d...
Date Wed, 31 May 2017 11:57:22 GMT
GitHub user mcherkasov opened a pull request:

    https://github.com/apache/ignite/pull/2046

    Removed DS map, all DS is added to utilityCache directly

    All DSs are stored in one Map which itself is stored in utilityCache, this makes high
contention on DS creation or removing, it requires lock on the key and manipulation with the
Map under the lock. So all threads in cluster should wait for this lock to create or remove
DS.
    
    I don't see any reason to store all DS in one map,  we already have utilityCache and can
save DSs directly in utilityCache, to distinguish DS with other objects in utilityCache I
use composite key, the first part of which is DATA_STRUCTURES_KEY, second one is DS's name,
also DS type can be added, this will allow us to create different DS with the same name.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcherkasov/ignite ds-creation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2046.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2046
    
----
commit 85764af902e22df4016b5590e98245935953eed5
Author: mcherkasov <mcherkasov@gridgain.com>
Date:   2017-05-31T11:39:31Z

    Removed DS map, all DS is added to utilityCache directly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message