ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mcherkasov <...@git.apache.org>
Subject [GitHub] ignite pull request #1967: IGNITE-5227: StackOverflowError in GridCacheMapEn...
Date Wed, 17 May 2017 17:34:54 GMT
GitHub user mcherkasov opened a pull request:

    https://github.com/apache/ignite/pull/1967

    IGNITE-5227: StackOverflowError in GridCacheMapEntry#checkOwnerChanged()

    StackOverflowError occurs due recursion in methods:
    GridCacheMapEntry.checkOwnerChanged -> GridDistributedCacheEntry.checkThreadChain ->
GridDistributedCacheEntry.recheck -> GridCacheMapEntry.checkOwnerChanged
    
    I broke this cycle by introducing "checkCandidateChain" flag in GridCacheMapEntry.checkOwnerChanged
method, which allow to miss GridDistributedCacheEntry.checkThreadChain. 
    The check fo the whole candidate chain is moved to GridDistributedCacheEntry.checkThreadChain
method, as you can see there  already was cycle for this, I've just removed break(put it in
else branch in case we don't have any kes for lock candidates).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcherkasov/ignite master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/1967.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1967
    
----
commit fbe059e8003b04568a39a3cfb604a248928d1f6f
Author: mcherkasov <mcherkasov@gridgain.com>
Date:   2017-05-17T17:12:14Z

    IGNITE-5227: StackOverflowError in GridCacheMapEntry#checkOwnerChanged()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message