ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vladimir Ozerov <voze...@gridgain.com>
Subject Re: IgniteCompute async methods do not return ComputeTaskFuture
Date Tue, 30 May 2017 11:55:15 GMT
The fact that closure create task is internal implementation detail which
may (and should for performance reasons) change in future. Please provide
the use case where use needs anything except for the future itself.

On Tue, May 30, 2017 at 2:35 PM, Valentin Kulichenko <
valentin.kulichenko@gmail.com> wrote:

> +1 to Yakov. Closure execution also creates a task and I don't see any
> reason for hiding it. And actually we don't hide it - we fire task/job
> events, apply the same failover mechanisms, etc.
>
> What probably is confusing here is the name of the class. ComputeTaskFuture
> indeed looks like applied only to execution of a ComputeTask. How about
> renaming it to IgniteComputeFuture (or just ComputeFuture) then?
>
> -Val
>
> On Tue, May 30, 2017 at 12:56 PM, Yakov Zhdanov <yzhdanov@apache.org>
> wrote:
>
> > Vladimir,
> >
> > I disagree. I understand this is minor issue, but still.
> >
> > Here are the points:
> >
> > 1. TaskSession is supported for all compute methods. Please see -
> > ComputeFailoverExample. Every compute method starts a task.
> > 2. You still return task future, but method return type is a
> > super-interface.
> > 3. User cannot identify the spawned broadcast - returned future does not
> > provide any ID.
> >
> > --Yakov
> >
> > 2017-05-30 11:28 GMT+03:00 Vladimir Ozerov <vozerov@gridgain.com>:
> >
> > > Valya,
> > >
> > > This future contains task session. We intentionally changed return type
> > to
> > > plain IgniteFuture for closure methods, as there is no notion of
> > "session"
> > > and "task" for them. ComputeTaskFuture now returned only from
> > task-related
> > > methods ("execute"). Unless I am missing something, this approach looks
> > > correct.
> > >
> > >
> > > On Tue, May 30, 2017 at 11:06 AM, Valentin Kulichenko <
> > > valentin.kulichenko@gmail.com> wrote:
> > >
> > > > Folks,
> > > >
> > > > I noticed that the new async API for IgniteCompute returns
> > IgniteFuture,
> > > > while previously we used to have its extension - ComputeTaskFuture,
> > which
> > > > contains useful information about the executed task session.
> > > >
> > > > Should this be fixed?
> > > >
> > > > -Val
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message