ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yakov Zhdanov <yzhda...@apache.org>
Subject Re: DiscoverySpi#setDataExchange returns concrete implementation
Date Tue, 30 May 2017 09:23:13 GMT
yes

--Yakov

2017-05-29 17:30 GMT+03:00 Николай Ижиков <nizhikov.dev@gmail.com>:

> Thanks Yakov.
>
> I moved IGNITE-5321 to resolved state.
> Is that right?
>
> 2017-05-29 17:24 GMT+03:00 Yakov Zhdanov <yzhdanov@apache.org>:
>
> > Merged. Thanks for contribution, Nick. Please also see my edits.
> >
> > --Yakov
> >
> > 2017-05-28 19:29 GMT+03:00 Николай Ижиков <nizhikov.dev@gmail.com>:
> >
> > > Hello. Here is pull request for this issue:
> > >
> > > https://github.com/apache/ignite/pull/2022
> > >
> > > 2017-05-26 13:16 GMT+03:00 Yakov Zhdanov <yzhdanov@apache.org>:
> > >
> > > > Hi Nick! Good catch. Please go ahead and submit a patch.
> > > >
> > > > --Yakov
> > > >
> > > > 2017-05-26 13:09 GMT+03:00 Николай Ижиков <nizhikov.dev@gmail.com>:
> > > >
> > > > > Hello, guys.
> > > > >
> > > > > public interface DiscoverySpi extends IgniteSpi {
> > > > > ....
> > > > >     TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange
> var1);
> > > > >
> > > > >     TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider
> > var1);
> > > > > ...
> > > > > }
> > > > >
> > > > > Two methods of DiscoverySpi returns concrete implementation.
> > > > > I think we should return interface, not implementation from this
> > > methods
> > > > > Or why we need an interface?
> > > > >
> > > > > I can provide simple patch to fix this issue.
> > > > >
> > > > > --
> > > > > Nikolay Izhikov
> > > > > NIzhikov.dev@gmail.com
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Nikolay Izhikov
> > > NIzhikov.dev@gmail.com
> > >
> >
>
>
>
> --
> Nikolay Izhikov
> NIzhikov.dev@gmail.com
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message