ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Николай Ижиков <nizhikov....@gmail.com>
Subject DiscoverySpi#setDataExchange returns concrete implementation
Date Fri, 26 May 2017 10:09:12 GMT
Hello, guys.

public interface DiscoverySpi extends IgniteSpi {
....
    TcpDiscoverySpi setDataExchange(DiscoverySpiDataExchange var1);

    TcpDiscoverySpi setMetricsProvider(DiscoveryMetricsProvider var1);
...
}

Two methods of DiscoverySpi returns concrete implementation.
I think we should return interface, not implementation from this methods
Or why we need an interface?

I can provide simple patch to fix this issue.

-- 
Nikolay Izhikov
NIzhikov.dev@gmail.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message