Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CA+0=VoXJ24SWHx_FO-je7Cah2TNgQpFjp3J-1uLLSVz6xUmRTA@mail.gmail.com>
References: <CAGt6o8mcQwhqt1RsbRWJpXO5Xe5r1oMa=EXNHnqso=OMOh5cSQ@mail.gmail.com>
 <CA+eZwrH5L6SWWV_wim3thq0VYQm45WD_8QxMUrd=F1Un+m7tpg@mail.gmail.com>
 <CA+0=VoVeGmJW7h4jp360u5GS7qQ0oyMsh6YTOC2eTo_RyuCfiA@mail.gmail.com>
 <CA+eZwrFv6X12hMgwpAZqbZT8AvrCoG8m7pbhLh_JMephWKnvZw@mail.gmail.com>
 <CAK2_iMPO1+A457SxREabUb7COpXjbp1fhNAKM_jsQEQz4_cOSw@mail.gmail.com>
 <CA+eZwrFT7RXYAN-aQ1LkYHGsMDA14KjqFw_uu5uVaaxHKaHhaw@mail.gmail.com>
 <CA+0=VoWKCOkmH4za0Bo=5ZoraBV2iti2oGqWC1uCPjt0hWtAkg@mail.gmail.com>
 <CAK2_iMOk6V2wz14+P5KV-WjEuuncUGOPRTQoD3NqJ=KM2ZjZPA@mail.gmail.com>
 <CAK2_iMM8No=F0t51z8sOwCa4GcWfWbVapkqxCjN8gy2wSHvL+A@mail.gmail.com>
 <CA+eZwrEYapRKdkyYcZnHFCUuW-Dy5W4i4Ko4yB12_A0XwUK9Xg@mail.gmail.com>
 <CAGt6o8=A0O7qr1ZNPJXODOP792ff7ibw-CQSNZwttMyPVUHE_g@mail.gmail.com>
 <CA+eZwrG_5EAAyqz_Mes3h_fyWudc1E=yJKAT8x_uU-TONc7W6A@mail.gmail.com>
 <CA+0=VoVdWpL+7okPEPppkMwCYZ=kuXnRd+0dhfZeNPzcjq4rYg@mail.gmail.com>
 <CA+eZwrFUt47CFHUoXam6Ug6zd1Cks=HjzqebFRO9LH11oHXsLQ@mail.gmail.com>
 <CA+0=VoW7zQAzj4KNvDz8+cVxVX-PCUccqVmPqBSb4Whi75Npaw@mail.gmail.com>
 <CAK2_iMNH6c6jmJ39c7ddMaZJdyj60sNd=UKaeu7WbyP2vp8Ztw@mail.gmail.com> <CA+0=VoXJ24SWHx_FO-je7Cah2TNgQpFjp3J-1uLLSVz6xUmRTA@mail.gmail.com>
From: Vladimir Ozerov <vozerov@gridgain.com>
Date: Wed, 12 Apr 2017 11:07:42 +0300
Message-ID: <CAGt6o8k5FNWM8Zdft+J698S1_Wc=X7XSiQLAs2TxNxDT25OUGw@mail.gmail.com>
Subject: Re: Sorting fields of Binarilyzable objects on write
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=f403045e3774e9cdaa054cf3b37f
archived-at: Wed, 12 Apr 2017 08:07:50 -0000

--f403045e3774e9cdaa054cf3b37f
Content-Type: text/plain; charset=UTF-8

Consider the following code:

void writeBinary(BinaryWriter w) {
    w.writeBoolean("C", c);

    if (c)
        w.writeInt("A", a)
    else
        w.writeInt("B", b)
}

How are we going to force user to follow the contract in this case?

On Wed, Apr 12, 2017 at 9:16 AM, Dmitriy Setrakyan <dsetrakyan@apache.org>
wrote:

> I think it is OK for users to do their own sorting, but we should
> definitely validate the correct order and throw an exception if it is not.
>
> D.
>
> On Tue, Apr 11, 2017 at 11:02 PM, Pavel Tupitsyn <ptupitsyn@apache.org>
> wrote:
>
> > QueryEntity order is not only harder for the users, it will be nightmare
> to
> > implement.
> > What if there is no QueryEntity defined? What if the same class is used
> in
> > multiple QueryEntity?
> > I don't think serialization code has to be tied to QueryEntity in any
> way,
> > this violates separation of concerns.
> >
> > So I guess we can agree on sorting fields alphabetically.
> >
> > Let's get to the initial question:
> > * Should we do the sorting for the user (performance hit)?
> > * Should we at least validate user-defined order?
> >
> > On Wed, Apr 12, 2017 at 2:12 AM, Dmitriy Setrakyan <
> dsetrakyan@apache.org>
> > wrote:
> >
> > > On Tue, Apr 11, 2017 at 1:28 PM, Sergi Vladykin <
> > sergi.vladykin@gmail.com>
> > > wrote:
> > >
> > > > I'm just trying to understand the current state of things and risks.
> > May
> > > be
> > > > we need to do some adjustments here before 2.0 to be on the safe
> side.
> > > >
> > > > Actually looks like this not really important, we just have to
> clearly
> > > > document that DML builds keys this way and require from user to do
> the
> > > same
> > > > to be able to use cache API.
> > > >
> > >
> > >
> > > I think it is important from the usability stand point. A user can
> always
> > > sort fields alphabetically in his or her mind. However, trying to
> > remember
> > > the field order from some QueryEntity is a lot harder.
> > >
> >
>

--f403045e3774e9cdaa054cf3b37f--