Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CA0D8200C64 for ; Fri, 28 Apr 2017 14:32:27 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id C7550160BA3; Fri, 28 Apr 2017 12:32:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1A69C160B8C for ; Fri, 28 Apr 2017 14:32:26 +0200 (CEST) Received: (qmail 68845 invoked by uid 500); 28 Apr 2017 12:32:26 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 68832 invoked by uid 99); 28 Apr 2017 12:32:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 28 Apr 2017 12:32:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7A2ACC031B for ; Fri, 28 Apr 2017 12:32:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.879 X-Spam-Level: * X-Spam-Status: No, score=1.879 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ACWPWAma8uUs for ; Fri, 28 Apr 2017 12:32:24 +0000 (UTC) Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 3236F5FDC7 for ; Fri, 28 Apr 2017 12:32:24 +0000 (UTC) Received: by mail-wm0-f53.google.com with SMTP id u65so40964765wmu.1 for ; Fri, 28 Apr 2017 05:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=m6pQ565XekxFmzVzY/5VbQBXH8j8ynIwcXen51tFX80=; b=djdntHABCPR41+l/Kj2PqwWnVnJf3NcEgfet5Z/KU7qCZ+w2qgnuDmbBe7XvTwqMv2 orIgpyrFUNFa3LNYEeDeVcFUP+4uv7zuSlfE4/o1Jt9sakrhLUqllrsDu6HHlWioAjmS lduIZJ37PfDhRRyMFWglnRB7LaxFC4CAGJaqxliIys3zXM8TIsR4WTjP/Q7dx6SMTVc4 wjRhGllvZJ1l8hHAfl3GS/myCWR+RBPIOVrDBNPEG4MCcnDy+hpHi9WnjrqQMlMd/awa MFg2V3NPri+kU+SLSmLMbjWQbFwUrutIDbTL/n5eNNt7QGUuo2RceRbI4PmD1FEBHG/0 F7Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=m6pQ565XekxFmzVzY/5VbQBXH8j8ynIwcXen51tFX80=; b=qAzuLP1/7Zq+9y5gXpEZfMAEDyo27HXpJeG7swRFfTJ1Aq3C+E9VzbKYU+upLwoqeO tyVhMgbG8EEJZVmdNKFdb8KOpk92Acb4Ybm6lJnQc6PsFk4sq4QsggXUJ4WEypv4+bXJ RNebD6BZyPnA9qJhZFvz1lbcbQbPPhi4Zh9LZuy3K+k/cpgqShmThb0Hg2d03mkmWiJg oU7ZaYb9AnJnWFh96NB6ntuC7Ip3EmYSr2Fq/Uf0T6JrZpMm4XqyU/qARbyGEc0AvSk0 V6L+GQk7fDheixcXiCebpAqeYaISHyH4Q7nbhUEwYzRfC1YhcVIINj9a6T6ZBiZLsp3O 9ljQ== X-Gm-Message-State: AN3rC/4HQFN7MuJbPaEjrEyd6Pn2wLZ1Im6lnmafdXkzVpEvPoe2XOoI 2wiRVdokrL4Q2tZJtRXiVqahHQ9/bqb9 X-Received: by 10.80.181.33 with SMTP id y30mr9034989edd.109.1493382737703; Fri, 28 Apr 2017 05:32:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.171.133 with HTTP; Fri, 28 Apr 2017 05:32:17 -0700 (PDT) In-Reply-To: References: From: Nikita Amelchev Date: Fri, 28 Apr 2017 15:32:17 +0300 Message-ID: Subject: Re: IGNITE-4763 - ready for review. To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary=f403045c117c9839e0054e3943ba archived-at: Fri, 28 Apr 2017 12:32:28 -0000 --f403045c117c9839e0054e3943ba Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello. I add test. Please review. https://issues.apache.org/jira/browse/IGNITE-4763 PR: https://github.com/apache/ignite/pull/1884/files ci test: http://ci.ignite.apache.org/project.html?projectId=3DIgniteTests&branch_Ign= iteTests=3Dpull/1884/head 2017-04-27 19:15 GMT+03:00 Denis Magda : > Nikita, > > I don=E2=80=99t see a single test that validates your fix works and no on= e will > break it in the future. Please address this. > > =E2=80=94 > Denis > > > On Apr 27, 2017, at 1:56 AM, Nikita Amelchev > wrote: > > > > Hello. I done it. > > > > Please, review. > > > > https://issues.apache.org/jira/browse/IGNITE-4763 - doSetRollbackOnly > > method to be implemented in SpringTransactionManager > > > > PR: https://github.com/apache/ignite/pull/1879/files > > > > latest ci.tests: > > http://ci.ignite.apache.org/project.html?projectId=3DIgniteTests&tab=3D > projectOverview&branch_IgniteTests=3Dpull%2F1879%2Fhead > > > > -- > > Best wishes, > > Amelchev Nikita > > --=20 Best wishes, Amelchev Nikita --f403045c117c9839e0054e3943ba--