Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 44450200C4D for ; Wed, 5 Apr 2017 14:14:34 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 417D4160B94; Wed, 5 Apr 2017 12:14:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 539F7160B91 for ; Wed, 5 Apr 2017 14:14:33 +0200 (CEST) Received: (qmail 51936 invoked by uid 500); 5 Apr 2017 12:14:32 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 51924 invoked by uid 99); 5 Apr 2017 12:14:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Apr 2017 12:14:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CC48118063D for ; Wed, 5 Apr 2017 12:14:31 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.104 X-Spam-Level: * X-Spam-Status: No, score=1.104 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=2, KAM_LIVE=1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-2.796, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 6VCG-9Z8_4AX for ; Wed, 5 Apr 2017 12:14:29 +0000 (UTC) Received: from mail-vk0-f48.google.com (mail-vk0-f48.google.com [209.85.213.48]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A8B6C5F2FE for ; Wed, 5 Apr 2017 12:14:28 +0000 (UTC) Received: by mail-vk0-f48.google.com with SMTP id r69so5705703vke.2 for ; Wed, 05 Apr 2017 05:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=JHjYr259TC1CAUY5fw4hBhtM3mOYhp7CbFoEjIUORbo=; b=i3OEYeZ3pnfqJPrd9vjvre4GrXD2Wc6o+xuKOu/YeesXHYsN84SfC0WZL1XP4smTIs WrCpMztDmh+y0sUZBipj3XQm7Ek0VLil+/eokTeAHsLpT4d+o5ctpSRt9qayzqOA4mWz rlw30AW8i+0m/rEDB28DPRxfE5v4aUsm6Qq8TH73hk2veHIt4jrMbNkI5CV/nfOmrBzi E+OYAcBdJDwhWQvqwNogQ3qz11bed/brnVAUnY+zJoaDSZ5cWD83vgCaTwAbtHzbCLdE 06T56488mn4+O5lOGzqonuxxGlj1OD4Q3AMvb6O5d5vpjhFjbDsUJit7TCzqmI3ssrjS DDXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=JHjYr259TC1CAUY5fw4hBhtM3mOYhp7CbFoEjIUORbo=; b=G6VZTtVLByO21/IoHx0Ff0bjwLBwSVVxIrg5vw9o9cbRjLD7HVKbeL/fRZ7G9eYv/3 DQihr97xOBxSsn5EtyYksRVhASkHsfP6OXUP6qb/dqV8pj4PLpmNAn/47UCSOw2e8hIc C2i9rZuR/cs/2B5cqWtbATY4HyFqwvIXt6/tAo29TvZ+ljvnxOkX4Yg5i2WIVNJHPiMv reawCXWDxDYuIZluSw/ItKCcCU2nb6KA5HIeet6MYYeu0v6n1PpBXsSgZHifk1dQ2lJo 4OMPhb+fNNfyZE49wZ+Re1fE/4vb/cWu0/lkwa+DVvrwX5izXWV1L/g74tGQ1FfXT5dW PaIA== X-Gm-Message-State: AFeK/H25JfUE0HK5cKzWhuzluL2GArCranbxi1TDsE2KJM7dxK2dyfo5gHLCG4mpirNWL3aQxapRHwiN/4CmZg== X-Received: by 10.31.227.198 with SMTP id a189mr12362439vkh.1.1491394467495; Wed, 05 Apr 2017 05:14:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.82.103 with HTTP; Wed, 5 Apr 2017 05:14:27 -0700 (PDT) In-Reply-To: References: <803E30BA-D595-430E-AE12-C86B9E93088C@gridgain.com> From: Alexey Goncharuk Date: Wed, 5 Apr 2017 15:14:27 +0300 Message-ID: Subject: Re: one point optimisation To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary=001a114dfe76748978054c6a55db archived-at: Wed, 05 Apr 2017 12:14:34 -0000 --001a114dfe76748978054c6a55db Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable This optimization does not work when near cache is enabled because we need the same ordering on near nodes. You should see the expected number of messages with near cache disabled. 2017-04-05 15:09 GMT+03:00 ALEKSEY KUZNETSOV : > yes > > =D1=81=D1=80, 5 =D0=B0=D0=BF=D1=80. 2017 =D0=B3. =D0=B2 15:07, Alexey Gon= charuk : > > > Do you have a near cache enabled? > > > > 2017-04-05 15:00 GMT+03:00 ALEKSEY KUZNETSOV = : > > > > > The test shows as follows: > > > assertMessageCount(GridNearTxPrepareRequest.class, 1); > > > assertMessageCount(GridDhtTxPrepareRequest.class, 1); > > > assertMessageCount(GridDhtTxPrepareResponse.class, 1); > > > assertMessageCount(GridNearTxPrepareResponse.class, 1); > > > assertMessageCount(GridNearTxFinishRequest.class, 1); > > > assertMessageCount(GridDhtTxFinishRequest.class, 0); > > > assertMessageCount(GridNearTxFinishResponse.class, 1); > > > > > > =D1=81=D1=80, 5 =D0=B0=D0=BF=D1=80. 2017 =D0=B3. =D0=B2 14:53, Alexey= Goncharuk < > alexey.goncharuk@gmail.com > > >: > > > > > > > Aleksey, > > > > > > > > Can you elaborate on which of the extra messages you observe? > > > > > > > > --AG > > > > > > > > 2017-04-04 14:17 GMT+03:00 ALEKSEY KUZNETSOV < > alkuznetsov.sb@gmail.com > > >: > > > > > > > > > any thoughts on one phase commit realization ? > > > > > > > > > > =D0=BF=D0=BD, 3 =D0=B0=D0=BF=D1=80. 2017 =D0=B3. =D0=B2 19:35, AL= EKSEY KUZNETSOV < > > > alkuznetsov.sb@gmail.com > > > > >: > > > > > > > > > > > I've attached test that prints messages exchange . Which shows = us > > > that > > > > > > there are more messages then you declared in article. Perhaps, > > > > > > implementation has changed. > > > > > > I created it on base of IgniteOnePhaseCommitNearSelfTest > > > > > > > > > > > > =D0=BF=D0=BD, 3 =D0=B0=D0=BF=D1=80. 2017 =D0=B3. =D0=B2 19:03, = Dmitriy Setrakyan < > > dsetrakyan@apache.org > > > >: > > > > > > > > > > > > Aleksey, > > > > > > > > > > > > The blog describes the 1-phase commit at a high level, but I am > > still > > > > > > curious about the differences you found. Can you share them her= e? > > > > > > > > > > > > D. > > > > > > > > > > > > On Mon, Apr 3, 2017 at 2:11 AM, ALEKSEY KUZNETSOV < > > > > > > alkuznetsov.sb@gmail.com> > > > > > > wrote: > > > > > > > > > > > > > Regarding IgniteOnePhaseCommitNearSelfTest test , ignite's on= e > > > phase > > > > > > > optimisation works not as you said. > > > > > > > I attached picture of message exchange. There are partial > prepare > > > > phase > > > > > > > exists, along with finish phase. > > > > > > > > > > > > > > > > > > > > > > > > > > > > =D0=BF=D0=BD, 3 =D0=B0=D0=BF=D1=80. 2017 =D0=B3. =D0=B2 10:55= , Christos Erotocritou < > > > > > christos@gridgain.com > > > > > > >: > > > > > > > > > > > > > >> As far as I know a partition is always allocated to a specif= ic > > > node > > > > > and > > > > > > >> does not span nodes. Ignite has default 1024 partitions on > start > > > > that > > > > > > are > > > > > > >> split equally across nodes. > > > > > > >> > > > > > > >> > On 3 Apr 2017, at 08:10, ALEKSEY KUZNETSOV < > > > > > alkuznetsov.sb@gmail.com> > > > > > > >> wrote: > > > > > > >> > > > > > > > >> > in ur blog u texted belonging to the same partition is > > nessesary > > > > > for 1 > > > > > > >> > phase commit. But its not guarantee belonging to the same > > node. > > > > > > >> Partition > > > > > > >> > may span many nodes > > > > > > >> > > > > > > > >> > =D0=B2=D1=81, 2 =D0=90=D0=BF=D1=80 2017 =D0=B3., 13:46 ALE= KSEY KUZNETSOV < > > > > > alkuznetsov.sb@gmail.com > > > > > > >: > > > > > > >> > > > > > > > >> >> thank u ! > > > > > > >> >> > > > > > > >> >> =D0=BF=D1=82, 31 =D0=9C=D0=B0=D1=80 2017 =D0=B3., 21:06 D= enis Magda : > > > > > > >> >> > > > > > > >> >> Here is a good blog post about 1phase commit impl in Igni= te > > and > > > > its > > > > > > >> >> advantages: > > > > > > >> >> > > > > > > >> >> http://gridgain.blogspot.com/ > 2014/09/one-phase-commit-fast- > > > > > > >> transactions-for.html > > > > > > >> >> < > > > > > > >> >> http://gridgain.blogspot.com/ > 2014/09/one-phase-commit-fast- > > > > > > >> transactions-for.html > > > > > > >> >>> > > > > > > >> >> > > > > > > >> >> Took a reference to it from there: > > > > > > >> >> > > > > > > >> >> https://apacheignite.readme.io/docs/transactions#section- > > > > > > >> two-phase-commit-2pc > > > > > > >> >> < > > > > > > >> >> https://apacheignite.readme.io/docs/transactions#section- > > > > > > >> two-phase-commit-2pc > > > > > > >> >>> > > > > > > >> >> > > > > > > >> >> =E2=80=94 > > > > > > >> >> Denis > > > > > > >> >> > > > > > > >> >>> On Mar 31, 2017, at 12:27 PM, Dmitriy Setrakyan < > > > > > > >> dsetrakyan@apache.org> > > > > > > >> >> wrote: > > > > > > >> >>> > > > > > > >> >>> On Fri, Mar 31, 2017 at 9:25 AM, ALEKSEY KUZNETSOV < > > > > > > >> >> alkuznetsov.sb@gmail.com > > > > > > >> >>>> wrote: > > > > > > >> >>> > > > > > > >> >>>> Igniters! What is the point of one phase optimisation? > > > > > > >> >>>> > > > > > > >> >>> > > > > > > >> >>> Performance > > > > > > >> >> > > > > > > >> >> -- > > > > > > >> >> > > > > > > >> >> *Best Regards,* > > > > > > >> >> > > > > > > >> >> *Kuznetsov Aleksey* > > > > > > >> >> > > > > > > >> > -- > > > > > > >> > > > > > > > >> > *Best Regards,* > > > > > > >> > > > > > > > >> > *Kuznetsov Aleksey* > > > > > > >> > > > > > > > -- > > > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > *Best Regards,* > > > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > -- > > > > > > > > > > *Best Regards,* > > > > > > > > > > *Kuznetsov Aleksey* > > > > > > > > > > > > -- > > > > > > *Best Regards,* > > > > > > *Kuznetsov Aleksey* > > > > > > -- > > *Best Regards,* > > *Kuznetsov Aleksey* > --001a114dfe76748978054c6a55db--