ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vyacheslav Daradur <daradu...@gmail.com>
Subject Re: ignite-3682 - GridFunc: move all inner anonymous classes to separate top-level classes.
Date Wed, 12 Apr 2017 16:24:55 GMT
Andrey,

I see you've merged it before I fixed merge conflict and you fixed it
yourself, thank you)

There is one more unused method:
public static <K0, K extends K0, V0, V extends V0, V1> Map<K, V1>
viewReadOnly

You can see it in my fixed version:
https://github.com/apache/ignite/pull/1652/files

BTW, looks unusually that the master-branch contains separate commits of
this task.


2017-04-12 19:13 GMT+03:00 Andrey Gura <agura@apache.org>:

> Vyacheslav,
>
> thank you for contribution! Your changes are merged into master branch.
>
> On Mon, Mar 20, 2017 at 1:11 PM, Vyacheslav Daradur <daradurvs@gmail.com>
> wrote:
> > I've received answers in the issue.
> >
> > Ready for review.
> >
> > 2017-03-16 10:14 GMT+03:00 Vyacheslav Daradur <daradurvs@gmail.com>:
> >
> >> Hello everyone.
> >>
> >> I have some questions about the issue https://issues.apache.
> >> org/jira/browse/IGNITE-3682
> >>
> >> 1) Can I do some minor refactoring of GridFunc class within this task?
> >> (to remove unused methods and code duplicates)
> >> Or just to extract anonymous classes?
> >>
> >> 2) Should @Depricated be added to GridFunc and F classes?
> >>
> >> --
> >> Best Regards, Vyacheslav
> >>
> >
> >
> >
> > --
> > Best Regards, Vyacheslav
>



-- 
Best Regards, Vyacheslav

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message