ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikita Amelchev <nsamelc...@gmail.com>
Subject Re: IGNITE-4763 - ready for review.
Date Fri, 28 Apr 2017 12:32:17 GMT
Hello.

I add test. Please review.

https://issues.apache.org/jira/browse/IGNITE-4763

PR: https://github.com/apache/ignite/pull/1884/files

ci test:
http://ci.ignite.apache.org/project.html?projectId=IgniteTests&branch_IgniteTests=pull/1884/head


2017-04-27 19:15 GMT+03:00 Denis Magda <dmagda@apache.org>:

> Nikita,
>
> I don’t see a single test that validates your fix works and no one will
> break it in the future. Please address this.
>
> —
> Denis
>
> > On Apr 27, 2017, at 1:56 AM, Nikita Amelchev <nsamelchev@gmail.com>
> wrote:
> >
> > Hello. I done it.
> >
> > Please, review.
> >
> > https://issues.apache.org/jira/browse/IGNITE-4763 - doSetRollbackOnly
> > method to be implemented in SpringTransactionManager
> >
> > PR: https://github.com/apache/ignite/pull/1879/files
> >
> > latest ci.tests:
> > http://ci.ignite.apache.org/project.html?projectId=IgniteTests&tab=
> projectOverview&branch_IgniteTests=pull%2F1879%2Fhead
> >
> > --
> > Best wishes,
> > Amelchev Nikita
>
>


-- 
Best wishes,
Amelchev Nikita

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message