ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Valentin Kulichenko <valentin.kuliche...@gmail.com>
Subject Re: IGNITE-2558 PR is ready to review (NearCacheConfiguration should not extend MutableConfiguration)
Date Sat, 08 Apr 2017 22:14:36 GMT
Hi Maxim,

I merged your changes to master. Thanks for the contribution!

-Val

On Thu, Apr 6, 2017 at 1:33 AM, Valentin Kulichenko <
valentin.kulichenko@gmail.com> wrote:

> Maxim,
>
> I will take a look today or tomorrow.
>
> -Val
>
> On Tue, Apr 4, 2017 at 7:40 AM, Kozlov Maxim <dreamx.max@gmail.com> wrote:
>
>> Create ticket https://issues.apache.org/jira/browse/IGNITE-4910 <
>> https://issues.apache.org/jira/browse/IGNITE-4910> and fix PR.
>>
>> > 4 апр. 2017 г., в 17:06, Kozlov Maxim <dreamx.max@gmail.com>
>> написал(а):
>> >
>> > Valentin, of course. I'll let you know how I'll do it.
>> >
>> >> 4 апр. 2017 г., в 16:38, Valentin Kulichenko <
>> valentin.kulichenko@gmail.com <mailto:valentin.kulichenko@gmail.com>>
>> написал(а):
>> >>
>> >> Maxim,
>> >>
>> >> It looks like you added copyOnRead property on configuration, but I'm
>> >> pretty sure that currently it will be ignored. Basically, it's a new
>> >> feature and I'm OK if we do this as a separate task sometime later
>> (e.g. in
>> >> 2.1). Can you create a ticket and remove the property for now?
>> >>
>> >> -Val
>> >>
>> >> On Tue, Apr 4, 2017 at 3:04 AM, Kozlov Maxim <dreamx.max@gmail.com
>> <mailto:dreamx.max@gmail.com>> wrote:
>> >>
>> >>> Hi igniters,
>> >>>
>> >>> Please review if someone has time.
>> >>> https://issues.apache.org/jira/browse/IGNITE-2558 <
>> https://issues.apache.org/jira/browse/IGNITE-2558> <
>> >>> https://issues.apache.org/jira/browse/IGNITE-2558 <
>> https://issues.apache.org/jira/browse/IGNITE-2558>>
>> >>> https://github.com/apache/ignite/pull/1701 <
>> https://github.com/apache/ignite/pull/1701> <https://github.com/apache/ <
>> https://github.com/apache/>
>> >>> ignite/pull/1701>
>> >>>
>> >>> --
>> >>> Best Regards,
>> >>> Max K.
>> >>>
>> >>>
>> >>>
>> >>>
>> >>>
>> >
>> > --
>> > Best Regards,
>> > Max K.
>> >
>> >
>> >
>> >
>>
>> --
>> Best Regards,
>> Max K.
>>
>>
>>
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message