ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Denis Magda <dma...@apache.org>
Subject Re: IGNITE-1794 is ready for review
Date Tue, 11 Apr 2017 16:55:40 GMT
Vadim, 

Do you mean this task?
> https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>
As I see Semen has already promised to review it and merge into the master by the end of the
week.

Did you add anything else in addition to previous changes?

—
Denis

> On Apr 11, 2017, at 9:51 AM, Вадим Опольский <vaopolskij@gmail.com>
wrote:
> 
> Hello guys!
> 
> I added folder hibernate5 as module to project settings and discovered some errors. Fixed
errors in pull request - https://github.com/vopolski/ignite/pull/1/files <https://github.com/vopolski/ignite/pull/1/files>
> But some tests from hibernate5 is failed. I'll fix them.
> 
> How much time do I have?
> 
> Vadim Opolski
> 
> 2017-04-06 13:04 GMT+03:00 Вадим Опольский <vaopolskij@gmail.com <mailto:vaopolskij@gmail.com>>:
> Dear sirs!
> 
> Sorry for incorrect subject.
> 
> https://github.com/apache/ignite/pull/1643 <https://github.com/apache/ignite/pull/1643>
> 
> ---------- Forwarded message ----------
> From: Вадим Опольский <vaopolskij@gmail.com <mailto:vaopolskij@gmail.com>>
> Date: 2017-03-24 15:48 GMT+03:00
> Subject: ready for review IGNITE-933
> To: dev@ignite.apache.org <mailto:dev@ignite.apache.org>, Denis Magda <dmagda@apache.org
<mailto:dmagda@apache.org>>, Valentin Kulichenko <valentin.kulichenko@gmail.com
<mailto:valentin.kulichenko@gmail.com>>
> 
> 
> Hello everyone!
> 
> Denis, Valentin, what should I do to close issue https://issues.apache.org/jira/browse/IGNITE-1794
<https://issues.apache.org/jira/browse/IGNITE-1794> ?
> 
> The tests in Team City executed successfully.
> 
> Valentin, I renamed IgniteHibernateTestSuite -> IgniteHibernate5TestSuite. Can you
create TeamCity Configuration ?
> 
> 
> 
> Vadim Opolski
> 
> 2017-03-21 11:30 GMT+03:00 Вадим Опольский <vaopolskij@gmail.com <mailto:vaopolskij@gmail.com>>:
> Hello everybody.
> 
> The issue  https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>
fixed originally by Mykola Pereyma.
> I re-assigned issue https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>
on myself, because we haven’t got a note from him for a while.
> 
> Denis, I merged pull request https://github.com/apache/ignite/pull/1146 <https://github.com/apache/ignite/pull/1146>
with my fork.
> Then I changed hibernate version to 5.2.7 and deleted ByteArrayType.java as per CI comments.
> The tests from list below executed succesfully.
> 
> Prepared new pull request - https://github.com/apache/ignite/pull/1643 <https://github.com/apache/ignite/pull/1643>
> 
> What's the next step ?
> 
> Tests:
> HibernateL2CacheConfigurationSelfTest.java
> HibernateL2CacheSelfTest.java
> HibernateL2CacheTransactionalSelfTest.java
> HibernateL2CacheTransactionalUseSyncSelfTest.java
> CacheHibernateBlobStoreNodeRestartTest.java
> CacheHibernateBlobStoreSelfTest.java
> CacheHibernateStoreFactorySelfTest.java
> CacheHibernateStoreSessionListenerSelfTest.java
> 
> 
> Vadim Opolski
> 
> 
> 2017-02-25 2:38 GMT+03:00 Denis Magda <dmagda@apache.org <mailto:dmagda@apache.org>>:
> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is interesting
for me. How I can assignee it to me? It is assigning with Mykola Pereyma now.
> >
> > https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>
<https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>>
> 
> Just re-assign it on yourself ;) Hope that Mykola is fine with this because we haven’t
got a note from him for a while.
> 
> —
> Denis
> 
> > On Feb 24, 2017, at 12:24 PM, Вадим Опольский <vaopolskij@gmail.com
<mailto:vaopolskij@gmail.com>> wrote:
> >
> > Hi Denis,
> >
> > OK, I spotted the problem in the code and I will be try to resolve it.
> >
> > https://issues.apache.org/jira/browse/IGNITE-933 <https://issues.apache.org/jira/browse/IGNITE-933>
<https://issues.apache.org/jira/browse/IGNITE-933 <https://issues.apache.org/jira/browse/IGNITE-933>>
> >
> > Yes, I have some experience with Hibernate. The issue № IGNITE-1974 is interesting
for me. How I can assignee it to me? It is assigning with Mykola Pereyma now.
> >
> > https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>
<https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>>
> >
> > Vadim Opolski
> >
> > 2017-02-24 5:55 GMT+03:00 Denis Magda <dmagda@apache.org <mailto:dmagda@apache.org>
<mailto:dmagda@apache.org <mailto:dmagda@apache.org>>>:
> > Hi Vadim,
> >
> > Yes, this issue might be still relevant. I can’t guide you through but, basically,
you need to reproduce the issue, spot it in the code and propose a fix.
> >
> > BTW, do you have any experience with Hibernate? If so, I would be amazing if you
pick up this ticket reassigning on yourself:
> > https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>
<https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>>
<https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>
<https://issues.apache.org/jira/browse/IGNITE-1794 <https://issues.apache.org/jira/browse/IGNITE-1794>>>
> >
> > —
> > Denis
> >
> > > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopolskij@gmail.com
<mailto:vaopolskij@gmail.com> <mailto:vaopolskij@gmail.com <mailto:vaopolskij@gmail.com>>>
wrote:
> > >
> > > Dear sirs !
> > >
> > > I want to resolve issue IGNITE-933
> > >
> > > https://issues.apache.org/jira/browse/IGNITE-933 <https://issues.apache.org/jira/browse/IGNITE-933>
<https://issues.apache.org/jira/browse/IGNITE-933 <https://issues.apache.org/jira/browse/IGNITE-933>>
> > >
> > > Is it actual ?
> > >
> > > In which class and method you want me to make changes ?
> > >
> > > Vadim Opolski
> >
> >
> 
> 
> 
> 
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message