ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vadopolski <vaopols...@gmail.com>
Subject Re: issue with Hibernate 2L cache region factory ignite-1.8
Date Wed, 05 Apr 2017 13:32:18 GMT
Hello everybody!

Cameron write please. How did you recreated mistake that the wrong
regions/caches were being updated?

I tried to do it in HibernateL2CacheConfigurationSelfTest.java -
testEntityCacheNonStrictFails. 

After: 
e2forUpdate.setName("XXXXXXX"); 
session.update(e2forUpdate); 

Both regions for Entity1 and Entity2 get updates and assert fails:
assertEquals(1,
sessionFactory.getStatistics().getSecondLevelCacheStatistics(ENTITY1_NAME).getPutCount());






Cameron Braid wrote
> I have just discovered that the ignite hibernate layer 2 cache region
> factory does something weird with tracking changes - the wrong
> regions/caches were being updated  -  I would end up with cache entries
> for
> other regions in one region.
> 
> for example if I say loaded updated a product entity then updated a
> customer entity the product cache could contain the update to the
> customer.
> 
> It looks like someone didn't finish the implementation as there was a note
> in source : /** Map needed to provide the same transaction context for
> different regions. */
> 
> So I made the following two lines of change in
> modules/hibernate/src/main/java/org/apache/ignite/cache/hibernate/HibernateRegionFactory
> 
> Line 102 in 1.8 :
> 
> -    private final ThreadLocal threadLoc = new ThreadLocal();
> +    private ConcurrentMap&lt;String, ThreadLocal&gt; threadLocMap = new
> ConcurrentHashMap<>();
> 
> Line 222 in 1.8 :
> 
>      ThreadLocal threadLocalForCache(String cacheName) {
> -        return threadLoc;
> +        return threadLocMap.computeIfAbsent(cacheName, (k)->new
> ThreadLocal());;
>      }
> 
> 
> Cameron





--
View this message in context: http://apache-ignite-developers.2346864.n4.nabble.com/issue-with-Hibernate-2L-cache-region-factory-ignite-1-8-tp14912p16170.html
Sent from the Apache Ignite Developers mailing list archive at Nabble.com.

Mime
View raw message