Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
From: Denis Magda <dmagda@apache.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: IGNITE-3422 - ready for review
Date: Fri, 3 Mar 2017 10:58:52 -0800
References: <CAFyTW-iLutKEX0RGrBLhni7GjdWDTQ31dub6Nx915qP97o8epw@mail.gmail.com>
 <CAGt6o8moAq8OR8taTJSkTDFR3Jc7mEw0XdZO8oSUcNW7Gyp+hw@mail.gmail.com>
 <5CA257DA-AE41-4C09-BAF5-074CC0270DC5@apache.org>
 <CAFyTW-hb-1rKfS66FTXm=dcf_aaJFUdDJ=2n0O6xtQT+ur2BTw@mail.gmail.com>
 <9ED94A13-2DE7-4B28-9090-67C2AF0B2ACB@apache.org>
 <CAFyTW-iiUz-8oMfDphjrF72uXDfDFtq_mfMUvQJAMtJyoQpdcQ@mail.gmail.com>
 <CAFyTW-gw_5_m7OQ=BjeUuWmhURCimjY+ZwPRv8HDydGCPP1QaQ@mail.gmail.com>
To: dev@ignite.apache.org
In-Reply-To: <CAFyTW-gw_5_m7OQ=BjeUuWmhURCimjY+ZwPRv8HDydGCPP1QaQ@mail.gmail.com>
Message-Id: <E5FB81E8-2589-4150-BFA2-9DC9B224373B@apache.org>
archived-at: Fri, 03 Mar 2017 18:58:55 -0000

Vyacheslav, sorry for the delay with a reply.

Let=E2=80=99s put off this ticket for now because, as I see it=E2=80=99s =
too controversial for us. If no one emerges and asks that he needs it =
then we will close it later on.

=E2=80=94
Denis

> On Mar 1, 2017, at 12:11 AM, Vyacheslav Daradur <daradurvs@gmail.com> =
wrote:
>=20
> Guys, any thoughts?
>=20
> 2017-02-23 13:22 GMT+03:00 Vyacheslav Daradur <daradurvs@gmail.com>:
>=20
>> I think it makes a sense to define factory in IgniteConfiguration, as =
the
>> Map<Class, InstanceFactory> which will be ised when deserializing.
>>=20
>> Interface example:
>>=20
>> public intterface InstanceFactory {
>>    newInstance(Class clazz, BinaryReader reader);
>> }
>>=20
>> P.S.
>> About "constructor(BinraryReader reader)" - I think there is no =
sense,
>> because it just duplicate readObject method and we can't manage a =
reference
>> of new instance.
>> How about singlton-deserialization?
>>=20
>>=20
>>=20
>> 2017-02-23 10:16 GMT+03:00 Denis Magda <dmagda@apache.org>:
>>=20
>>> In my understanding the goal is well-defined in the ticket. At the =
same
>>> time we have a similar task prepared by Pavel for .NET:
>>> https://issues.apache.org/jira/browse/IGNITE-3102 <
>>> https://issues.apache.org/jira/browse/IGNITE-3102>
>>>=20
>>> So, what we need to agree on is how to proceed with the =
implementation.
>>> Let us think this over and propose design.
>>>=20
>>> =E2=80=94
>>> Denis
>>>=20
>>>> On Feb 22, 2017, at 2:41 AM, Vyacheslav Daradur =
<daradurvs@gmail.com>
>>> wrote:
>>>>=20
>>>> Guys, let's discuss a goal of this task.
>>>>=20
>>>> I need the task specification.
>>>>=20
>>>>=20
>>>> 2017-02-22 2:00 GMT+03:00 Denis Magda <dmagda@apache.org <mailto:
>>> dmagda@apache.org>>:
>>>> Replied.
>>>>=20
>>>> =E2=80=94
>>>> Denis
>>>>=20
>>>>> On Feb 20, 2017, at 3:08 AM, Vladimir Ozerov <vozerov@gridgain.com
>>> <mailto:vozerov@gridgain.com>> wrote:
>>>>>=20
>>>>> Hi Vyacheslav,
>>>>>=20
>>>>> Thank you for contribution. I reviewed implementation again and =
now I
>>> am in
>>>>> doubts whether our product would really benefit from it or not. =
See my
>>>>> comments in the ticket. I'de prefer Denis Magda to chime in and =
give
>>> his
>>>>> feedback first.
>>>>>=20
>>>>> Vladimir.
>>>>>=20
>>>>> On Wed, Feb 15, 2017 at 5:00 PM, Vyacheslav Daradur <
>>> daradurvs@gmail.com <mailto:daradurvs@gmail.com>>
>>>>> wrote:
>>>>>=20
>>>>>> Hello everyone.
>>>>>>=20
>>>>>> Please, review implemented solution.
>>>>>>=20
>>>>>> https://issues.apache.org/jira/browse/IGNITE-3422 <
>>> https://issues.apache.org/jira/browse/IGNITE-3422> - No way to =
control
>>>>>> object initialization during deserialization/unmarshalling
>>>>>>=20
>>>>>> ci.tests =
<http://ci.ignite.apache.org/viewQueued.html?itemId=3D461054
>>> <http://ci.ignite.apache.org/viewQueued.html?itemId=3D461054>>
>>>>>>=20
>>>>=20
>>>>=20
>>>=20
>>>=20
>>=20