Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
From: Kozlov Maxim <dreamx.max@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: Remove CacheAtomicWriteOrderMode.CLOCK mode.
Date: Mon, 6 Mar 2017 12:12:10 +0300
References: <311A3371-F0E7-46BE-A8A1-20DEE0E45F0C@gmail.com>
 <CABuYRco-9s-JLZjvrENLev10BhJDNYBvXi09DFy2G_1YdCUT9w@mail.gmail.com>
 <6ED93810-D057-4A4D-90BF-EE4A05DA2FD6@gmail.com>
 <CAK1mX7Gxdvvk2RdF-Lne7ChX6Mq6m0ARHWw_mJJ+Xhp073BF0g@mail.gmail.com>
 <CA+0=VoXZQ9i7P_9CbsBRCHFFF69DBTzibuV97qTqNip7Bx53ig@mail.gmail.com>
 <CAK1mX7EgmiJszQPw2+86eOLaC2J6E=CMoLknN3Fh760wOEPpJg@mail.gmail.com>
 <725BC2C2-0E52-42A2-A012-922D217B8DF6@gmail.com>
 <CAK1mX7H2hSecS+MC6q+3tMhewXhW8rNQ7NNV3EA5Pc7A9QV7Rw@mail.gmail.com>
 <9B0D1D66-B753-4EBE-965F-463C453B6C7A@gmail.com>
 <CAK1mX7EEWHckrrHRviccfGkzvvyD5-7==yNP99XLqQ-AHLfkJg@mail.gmail.com>
 <163E772A-BE6A-4DFF-8F2D-43E976D1DB1A@gmail.com>
 <4FC4E9E8-DBC0-4A8D-B96B-9BE18646F457@gmail.com>
 <CABDss3iE7Ligd_8UWVT=4rybg4wgcgzJTpCt24ER+rzh2skffA@mail.gmail.com>
 <CAK1mX7FaZKH5pdtbcvQCdVu2Z+C_Gz+VVubADC4xaNWm-qjrZg@mail.gmail.com>
 <C515658E-2A66-4751-B7A5-52800DC0B29C@gmail.com>
 <CAK1mX7FB4oa0FYgv1+yM-OCAsX8FXGP4ebw+NaOEGfKgkZ1Q1w@mail.gmail.com>
To: dev@ignite.apache.org
In-Reply-To: <CAK1mX7FB4oa0FYgv1+yM-OCAsX8FXGP4ebw+NaOEGfKgkZ1Q1w@mail.gmail.com>
Message-Id: <2354E060-62D9-4931-B344-B761024E446E@gmail.com>
archived-at: Mon, 06 Mar 2017 11:53:45 -0000

In CacheEntryImplEx class use ver.globalTime() in=20

@Override public long updateTime() {
    return ver.globalTime();
}

Than is better to replace this variable?


> 3 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 19:19, Andrey =
Gura <agura@apache.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0)=
:
>=20
> Maxim,
>=20
> I think the next implementation will be good enough:
>=20
> public IgniteUuid asGridUuid() {
>    return new IgniteUuid(new UUID(nodeOrderDrId, topVer), order);
> }
>=20
>=20
> Serialization/deserialization of GridCacheVersion.globalTime field
> should be removed.
>=20
> On Fri, Mar 3, 2017 at 5:57 PM, Kozlov Maxim <dreamx.max@gmail.com> =
wrote:
>> Alexey,
>>=20
>> public IgniteUuid asGridUuid() {
>>    return new IgniteUuid(new UUID(nodeOrderDrId << 32, topVer << 32), =
order);
>> }
>>=20
>> So you want to change or not?
>>=20
>> And
>> - GridCacheVersion.writeTo(ByteBuffer buf, MessageWriter writer)
>> - GridCacheVersion.readFrom(ByteBuffer buf, MessageReader reader)
>>=20
>> use globalTime variable, must be removed case 0: (in both methods) or =
replace globalTime?
>>=20
>>=20
>>=20
>>> 2 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 16:58, Andrey =
Gura <agura@apache.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0)=
:
>>>=20
>>> +1
>>>=20
>>> Removing of asGridUuid() method can lead to much code changes but it
>>> should be avoided on this step.
>>>=20
>>> On Thu, Mar 2, 2017 at 4:56 PM, Alexey Goncharuk
>>> <alexey.goncharuk@gmail.com> wrote:
>>>> Maxim,
>>>>=20
>>>> I see several usages of asGridUuid() method, so I would just remove =
global
>>>> time and use nodeOrderDrId and topVer as different parts of high =
and low
>>>> parts of the embedded UUID.
>>>>=20
>>>> --AG
>>>>=20
>>>> 2017-03-02 12:39 GMT+03:00 Kozlov Maxim <dreamx.max@gmail.com>:
>>>>=20
>>>>> Andrey,
>>>>>=20
>>>>> When removed parameter globalTime, in method:
>>>>>=20
>>>>> public IgniteUuid asGridUuid() {
>>>>>   return new IgniteUuid(new UUID(((long)topVer << 32) | =
nodeOrderDrId,
>>>>> globalTime), order);
>>>>> }
>>>>>=20
>>>>> globalTime parameter replaced by something or remove this method?
>>>>>=20
>>>>>=20
>>>>>> 2 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 12:07, =
Kozlov Maxim <dreamx.max@gmail.com>
>>>>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):
>>>>>>=20
>>>>>> Andrey,
>>>>>>=20
>>>>>> Please review PR again.
>>>>>>=20
>>>>>>> 1 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 18:47, =
Andrey Gura <agura@apache.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=
=D0=B0):
>>>>>>>=20
>>>>>>> I think that it is ok.
>>>>>>>=20
>>>>>>> On Wed, Mar 1, 2017 at 6:34 PM, Kozlov Maxim =
<dreamx.max@gmail.com>
>>>>> wrote:
>>>>>>>> Ok. What do you say for the rest?
>>>>>>>>=20
>>>>>>>>> 1 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 18:15, =
Andrey Gura <agura@apache.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=
=D0=B0):
>>>>>>>>>=20
>>>>>>>>> Maxim,
>>>>>>>>>=20
>>>>>>>>> I think that during renaming we should not lose "Atomic" =
prefix.
>>>>>>>>>=20
>>>>>>>>>=20
>>>>>>>>> On Wed, Mar 1, 2017 at 5:16 PM, Kozlov Maxim =
<dreamx.max@gmail.com>
>>>>> wrote:
>>>>>>>>>> Andrey, ok.
>>>>>>>>>>=20
>>>>>>>>>> Also remove in the modules/platform/dotnet
>>>>> CacheAtomicWriteOrderMode.cs?
>>>>>>>>>>=20
>>>>>>>>>> Rename classes:
>>>>>>>>>>=20
>>>>>>>>>> GridCacheAtomicNearCacheSelfTest.startGrids ->
>>>>> GridCacheAtomicNearCacheSelfTest.startGridsLocal (commit)
>>>>>>>>>> IgniteCacheAtomicPrimaryWriteOrderWithStoreInvokeTest ->
>>>>> IgniteCacheWithStoreInvokeTest
>>>>>>>>>> IgniteCacheAtomicPrimaryWriteOrderInvokeTest ->
>>>>> IgniteCacheInvokeTest
>>>>>>>>>> IgniteCacheAtomicPrimaryWriteOrderNearEnabledStoreValueTest =
->
>>>>> IgniteCacheNearEnabledStoreValueTest
>>>>>>>>>> GridCacheAtomicPrimaryWriteOrderNearRemoveFailureTest ->
>>>>> GridCacheNearRemoveFailureTest
>>>>>>>>>> GridCacheAtomicPrimaryWriteOrderRemoveFailureTest ->
>>>>> GridCacheRemoveFailureTest
>>>>>>>>>> GridCacheAtomicPrimaryWriteOrderFailoverSelfTest ->
>>>>> GridCacheFailoverSelfTest
>>>>>>>>>> =
GridCacheValueConsistencyAtomicPrimaryWriteOrderNearEnabledSelfTest
>>>>> -> GridCacheValueConsistencyNearEnabledSelfTest
>>>>>>>>>> =
CacheContinuousQueryAsyncFailoverAtomicPrimaryWriteOrderSelfTest ->
>>>>> CacheContinuousQueryAsyncFailoverSelfTest
>>>>>>>>>> CacheContinuousQueryFailoverAtomicPrimaryWriteOrderSelfTest =
->
>>>>> CacheContinuousQueryFailoverSelfTest
>>>>>>>>>> =
GridCacheAtomicNearCacheSelfTest.testNoBackupsPrimaryWriteOrder ->
>>>>> GridCacheAtomicNearCacheSelfTest.testNoBackups
>>>>>>>>>> =
GridCacheAtomicNearCacheSelfTest.testWithBackupsPrimaryWriteOrder
>>>>> -> GridCacheAtomicNearCacheSelfTest.testWithBackups
>>>>>>>>>>=20
>>>>>>>>>> Remove classes:
>>>>>>>>>>=20
>>>>>>>>>> IgniteCacheAtomicPrimaryWriteOrderStoreValueTest
>>>>>>>>>> =
GridCacheReplicatedAtomicPrimaryWriteOrderMultiNodeFullApiSelfTest
>>>>>>>>>> GridCacheAtomicPrimaryWriteOrderMultiNodeFullApiSelfTest
>>>>>>>>>> =
GridCacheAtomicPrimaryWriteOrderMultiNodeP2PDisabledFullApiSelfTest
>>>>>>>>>> =
GridCacheAtomicPrimaryWrityOrderOffHeapMultiNodeFullApiSelfTest
>>>>>>>>>> GridCacheAtomicPrimaryWriteOrderOffHeapFullApiSelfTest
>>>>>>>>>> GridCacheAtomicPrimaryWriteOrderFullApiSelfTest
>>>>>>>>>> GridCacheAtomicPrimaryWriteOrderReloadAllSelfTest
>>>>>>>>>> IgniteCachePutRetryAtomicPrimaryWriteOrderSelfTest
>>>>>>>>>> GridCacheValueConsistencyAtomicPrimaryWriteOrderSelfTest
>>>>>>>>>> IgniteCacheAtomicPrimaryWriteOrderExpiryPolicyTest
>>>>>>>>>>=20
>>>>>>>>>> ok? :)
>>>>>>>>>>=20
>>>>>>>>>>> 1 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 2:04, =
Andrey Gura <agura@apache.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=
=D0=B0):
>>>>>>>>>>>=20
>>>>>>>>>>> No, it should be removed. If somebody use entry last update =
time
>>>>> (e.g.
>>>>>>>>>>> for conflict resolving) they should store this time as entry =
field.
>>>>>>>>>>>=20
>>>>>>>>>>> On Wed, Mar 1, 2017 at 12:57 AM, Dmitriy Setrakyan
>>>>>>>>>>> <dsetrakyan@apache.org> wrote:
>>>>>>>>>>>> Do we still need GridClockSyncProcessor?
>>>>>>>>>>>>=20
>>>>>>>>>>>> On Tue, Feb 28, 2017 at 5:26 AM, Andrey Gura =
<agura@apache.org>
>>>>> wrote:
>>>>>>>>>>>>=20
>>>>>>>>>>>>> Maxim,
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> Yes, this setting doesn't make sense anymore. So we need =
remove
>>>>> all
>>>>>>>>>>>>> related methods.
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> Also there is component called GridClockSyncProcessor that =
also
>>>>> should
>>>>>>>>>>>>> be removed. It will lead to removing globalTime field from
>>>>>>>>>>>>> GridCacheVersion class and some related methods.
>>>>>>>>>>>>>=20
>>>>>>>>>>>>> On Tue, Feb 28, 2017 at 3:21 PM, Kozlov Maxim <
>>>>> dreamx.max@gmail.com>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>> Valentin,
>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>> Then there is no need for setting CacheConfiguration.
>>>>> atomicWriteOrderMode.
>>>>>>>>>>>>> What do you think, remove it and and related methods?
>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>> 28 =D1=84=D0=B5=D0=B2=D1=80. 2017 =D0=B3., =D0=B2 2:49, =
Valentin Kulichenko <
>>>>>>>>>>>>> valentin.kulichenko@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=
=D0=B0=D0=BB(=D0=B0):
>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>> Hi Max,
>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>> In case we remove the CLOCK mode, I think we should =
remove the
>>>>> enum
>>>>>>>>>>>>> too, as
>>>>>>>>>>>>>>> well as configuration properties and other code using =
this
>>>>> enum. Having
>>>>>>>>>>>>>>> enum with one value doesn't make sense to me.
>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>> -Val
>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>> On Mon, Feb 27, 2017 at 5:09 AM, Kozlov Maxim <
>>>>> dreamx.max@gmail.com>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>>> Hi Igniters,
>>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>>> After remove CLOCK mode, CacheAtomicWriteOrderMode enum
>>>>> contains now
>>>>>>>>>>>>> only
>>>>>>>>>>>>>>>> one value PRIMARY. Andrey Gura, proposition remove
>>>>>>>>>>>>>>>> CacheAtomicWriteOrderMode enum. Will there be something
>>>>> special for
>>>>>>>>>>>>> this
>>>>>>>>>>>>>>>> purpose is enum?
>>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>>> jira: https://issues.apache.org/jira/browse/IGNITE-4587 =
<
>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/IGNITE-4587>
>>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>> Best Regards,
>>>>>>>>>>>>>>>> Max K.
>>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>> --
>>>>>>>>>>>>>> Best Regards,
>>>>>>>>>>>>>> Max K.
>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>>=20
>>>>>>>>>>>>>=20
>>>>>>>>>>=20
>>>>>>>>>> --
>>>>>>>>>> Best Regards,
>>>>>>>>>> Max K.
>>>>>>>>>>=20
>>>>>>>>>>=20
>>>>>>>>>>=20
>>>>>>>>>>=20
>>>>>>>>=20
>>>>>>>> --
>>>>>>>> Best Regards,
>>>>>>>> Max K.
>>>>>>>>=20
>>>>>>>>=20
>>>>>>>>=20
>>>>>>>>=20
>>>>>>=20
>>>>>> --
>>>>>> Best Regards,
>>>>>> Max K.
>>>>>>=20
>>>>>>=20
>>>>>>=20
>>>>>>=20
>>>>>=20
>>>>> --
>>>>> Best Regards,
>>>>> Max K.
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>=20
>>=20
>> --
>> Best Regards,
>> Max K.
>>=20
>>=20
>>=20
>>=20

--
Best Regards,
Max K.