Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F08BA200C28 for ; Mon, 13 Mar 2017 18:07:00 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EF259160B6C; Mon, 13 Mar 2017 17:07:00 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 77D84160B5D for ; Mon, 13 Mar 2017 18:06:59 +0100 (CET) Received: (qmail 82296 invoked by uid 500); 13 Mar 2017 17:06:58 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 82285 invoked by uid 99); 13 Mar 2017 17:06:58 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 17:06:58 +0000 Received: from [192.168.75.221] (c-73-222-138-29.hsd1.ca.comcast.net [73.222.138.29]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 640091A0193 for ; Mon, 13 Mar 2017 17:06:57 +0000 (UTC) From: Denis Magda Content-Type: multipart/alternative; boundary="Apple-Mail=_40CCAB1D-3E95-44CC-985F-954C37A306D5" Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: Remove CacheAtomicWriteOrderMode.CLOCK mode. Date: Mon, 13 Mar 2017 10:06:56 -0700 References: <311A3371-F0E7-46BE-A8A1-20DEE0E45F0C@gmail.com> <6ED93810-D057-4A4D-90BF-EE4A05DA2FD6@gmail.com> <725BC2C2-0E52-42A2-A012-922D217B8DF6@gmail.com> <9B0D1D66-B753-4EBE-965F-463C453B6C7A@gmail.com> <163E772A-BE6A-4DFF-8F2D-43E976D1DB1A@gmail.com> <4FC4E9E8-DBC0-4A8D-B96B-9BE18646F457@gmail.com> <2354E060-62D9-4931-B344-B761024E446E@gmail.com> <8F13048E-1487-479A-947F-2FEB40759DEA@gmail.com> <5F0E8EE7-4DFE-41A4-981A-08AC5DF08C22@gmail.com> <32575620-47D0-4B9A-986D-86958759B3F6@gmail.com> <5D019555-9D02-48B2-A784-D69AC662F42A@apache.org> <4CBB849C-4048-4604-AEF0-49B4512E8B76@gmail.com> <5838AA67-D404-4467-A466-465521BD8C19@gmail.com> <35BF6DCE-E65A-4AD5-9B7F-B618E289F4DE@apache.org> <68F42758-5587-49D8-91FC-13408E6F469C@gmail.com> To: dev@ignite.apache.org In-Reply-To: <68F42758-5587-49D8-91FC-13408E6F469C@gmail.com> Message-Id: <22B0C042-2276-43D9-A107-A6556DE8C4AC@apache.org> X-Mailer: Apple Mail (2.3259) archived-at: Mon, 13 Mar 2017 17:07:01 -0000 --Apple-Mail=_40CCAB1D-3E95-44CC-985F-954C37A306D5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Well, looks like only committers can edit the pages. Could you prepare the content and paste it here? I=E2=80=99ll update the = migration guide for you. =E2=80=94 Denis > On Mar 13, 2017, at 9:59 AM, Kozlov Maxim = wrote: >=20 > No, I can not edit other pages. >=20 > Screenshots menu: > = https://www.dropbox.com/s/hbhuk3tci7k77qr/%D0%A1%D0%BA%D1%80%D0%B8%D0%BD%D= 1%88%D0%BE%D1%82%202017-03-13%2019.51.30.png?dl=3D0 = > = https://www.dropbox.com/s/43nr384icfb6xwp/%D0%A1%D0%BA%D1%80%D0%B8%D0%BD%D= 1%88%D0%BE%D1%82%202017-03-13%2019.50.24.png?dl=3D0 = >=20 >=20 >> 13 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 19:44, Denis = Magda > =D0=BD=D0=B0=D0=BF=D0= =B8=D1=81=D0=B0=D0=BB(=D0=B0): >>=20 >> Weird, can you edit any other page? I can=E2=80=99t find any = configuration parameters that should prevent you from editing. >>=20 >> =E2=80=94 >> Denis >>=20 >>> On Mar 13, 2017, at 9:14 AM, Kozlov Maxim > wrote: >>>=20 >>> Denis, I can not edit this page. >>>=20 >>> confluence username: dreamx >>>=20 >>>> 13 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 19:01, = Kozlov Maxim = >> = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>=20 >>>> Denis,=20 >>>>=20 >>>> ok >>>>=20 >>>>> 13 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 18:59, = Denis Magda = > = >>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >>>>>=20 >>>>> Maxim, >>>>>=20 >>>>> Please update Apache Ignite 2.0 migration guide: >>>>> = https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+2.0+Migra= tion+Guide = >>> = >>>> >>>>>=20 >>>>> You need to say that the parameter has been discontinued and the = users can use CacheAtomicWriteOrderMode.PRIMARY instead. >>>>>=20 >>>>> Agreed? >>>>>=20 >>>>> =E2=80=94 >>>>> Denis >>>>>=20 >>>>>> On Mar 10, 2017, at 12:06 AM, Kozlov Maxim > >>> wrote: >>>>>>=20 >>>>>> Andrey, Alexey, please review=20 >>>>>> PR - https://github.com/apache/ignite/pull/1521 = = > = = >> = = > = = >>> >>>>>> tests - = http://ci.ignite.apache.org/viewType.html?buildTypeId=3DIgniteTests_RunAll= &branch_IgniteTests=3Dpull%2F1521%2Fhead&tab=3DbuildTypeStatusDiv = >>> = >>>> >>>>>>=20 >>>>>>> 7 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 14:15, = Andrey Gura = > = >>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >>>>>>>=20 >>>>>>> Maxim, >>>>>>>=20 >>>>>>> all GridClockSyncProcessor related code should be remove = (objects, >>>>>>> messages, etc) >>>>>>>=20 >>>>>>> On Tue, Mar 7, 2017 at 12:23 PM, Kozlov Maxim = = > = = >>> wrote: >>>>>>>> Andrey, or better remove GridTimeSyncProcessorSelfTest class? >>>>>>>>=20 >>>>>>>>> 7 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 12:21, = Kozlov Maxim = > = = >>> = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>>>>>>=20 >>>>>>>>> Andrey, in GridTimeSyncProcessorSelfTest class methods: = testTimeSync() and testTimeSyncChangeCoordinator() also removed? >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>> 6 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 18:42, = Andrey Gura = > = >>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >>>>>>>>>>=20 >>>>>>>>>> Maxim, >>>>>>>>>>=20 >>>>>>>>>> About SER_VER_COMPARATOR. You can use code branch that = executes when >>>>>>>>>> times are equal: >>>>>>>>>>=20 >>>>>>>>>> int nodeOrder1 =3D ver1.nodeOrder(); >>>>>>>>>> int nodeOrder2 =3D ver2.nodeOrder(); >>>>>>>>>>=20 >>>>>>>>>> if (nodeOrder1 =3D=3D nodeOrder2) { >>>>>>>>>> long order1 =3D ver1.order(); >>>>>>>>>> long order2 =3D ver2.order(); >>>>>>>>>>=20 >>>>>>>>>> assert order1 !=3D order2; >>>>>>>>>>=20 >>>>>>>>>> return order1 > order2 ? 1 : -1; >>>>>>>>>> } >>>>>>>>>> else >>>>>>>>>> return nodeOrder1 > nodeOrder2 ? 1 : -1; >>>>>>>>>>=20 >>>>>>>>>> On Mon, Mar 6, 2017 at 6:32 PM, Alexey Goncharuk >>>>>>>>>> > >>> wrote: >>>>>>>>>>> Maxim, >>>>>>>>>>>=20 >>>>>>>>>>> Global time comparison is only needed for CLOCK mode, so you = should modify >>>>>>>>>>> the code as if ignoreTime is always true. >>>>>>>>>>>=20 >>>>>>>>>>> 2017-03-06 18:13 GMT+03:00 Kozlov Maxim = = > = = >>>: >>>>>>>>>>>=20 >>>>>>>>>>>> ok, >>>>>>>>>>>> in GridCacheAtomicVersionComparator class, method >>>>>>>>>>>> compare(GridCacheVersion one, GridCacheVersion other, = boolean ignoreTime) >>>>>>>>>>>> if (globalTime =3D=3D otherGlobalTime || ignoreTime) { // = =3D> if (ignoreTime) { >>>>>>>>>>>> ..... >>>>>>>>>>>> } >>>>>>>>>>>> else >>>>>>>>>>>> return globalTime > otherGlobalTime ? 1 : -1; // =3D> = return -1; >>>>>>>>>>>>=20 >>>>>>>>>>>> and, >>>>>>>>>>>> GridCacheMvcc class, >>>>>>>>>>>> SER_VER_COMPARATOR is comparator by globalTime var. His = remove and remove >>>>>>>>>>>> compareSerializableVersion? >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>> 6 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 = 16:51, Andrey Gura = > = = >>> = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>>>>>>>>>>=20 >>>>>>>>>>>>> Maxim, >>>>>>>>>>>>>=20 >>>>>>>>>>>>> updateTime() method should be removed. >>>>>>>>>>>>>=20 >>>>>>>>>>>>> On Mon, Mar 6, 2017 at 12:12 PM, Kozlov Maxim = = > = = >>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>> In CacheEntryImplEx class use ver.globalTime() in >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> @Override public long updateTime() { >>>>>>>>>>>>>> return ver.globalTime(); >>>>>>>>>>>>>> } >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> Than is better to replace this variable? >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> 3 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 = 19:19, Andrey Gura = > = = >>> = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> Maxim, >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> I think the next implementation will be good enough: >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> public IgniteUuid asGridUuid() { >>>>>>>>>>>>>>> return new IgniteUuid(new UUID(nodeOrderDrId, topVer), = order); >>>>>>>>>>>>>>> } >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> Serialization/deserialization of = GridCacheVersion.globalTime field >>>>>>>>>>>>>>> should be removed. >>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>> On Fri, Mar 3, 2017 at 5:57 PM, Kozlov Maxim = = > = = >>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> Alexey, >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> public IgniteUuid asGridUuid() { >>>>>>>>>>>>>>>> return new IgniteUuid(new UUID(nodeOrderDrId << 32, = topVer << 32), >>>>>>>>>>>> order); >>>>>>>>>>>>>>>> } >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> So you want to change or not? >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> And >>>>>>>>>>>>>>>> - GridCacheVersion.writeTo(ByteBuffer buf, = MessageWriter writer) >>>>>>>>>>>>>>>> - GridCacheVersion.readFrom(ByteBuffer buf, = MessageReader reader) >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> use globalTime variable, must be removed case 0: (in = both methods) or >>>>>>>>>>>> replace globalTime? >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>> 2 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2 = 16:58, Andrey Gura = > = = >>> = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>> +1 >>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>> Removing of asGridUuid() method can lead to much code = changes but it >>>>>>>>>>>>>>>>> should be avoided on this step. >>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>> On Thu, Mar 2, 2017 at 4:56 PM, Alexey Goncharuk >>>>>>>>>>>>>>>>> > >>> wrote: >>>>>>>>>>>>>>>>>> Maxim, >>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>> I see several usages of asGridUuid() method, so I = would just remove >>>>>>>>>>>> global >>>>>>>>>>>>>>>>>> time and use nodeOrderDrId and topVer as different = parts of high >>>>>>>>>>>> and low >>>>>>>>>>>>>>>>>> parts of the embedded UUID. >>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>> --AG >>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>> 2017-03-02 12:39 GMT+03:00 Kozlov Maxim = >>>>: >>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>> Andrey, >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>> When removed parameter globalTime, in method: >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>> public IgniteUuid asGridUuid() { >>>>>>>>>>>>>>>>>>> return new IgniteUuid(new UUID(((long)topVer << 32) = | >>>>>>>>>>>> nodeOrderDrId, >>>>>>>>>>>>>>>>>>> globalTime), order); >>>>>>>>>>>>>>>>>>> } >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>> globalTime parameter replaced by something or remove = this method? >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>> 2 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2= 12:07, Kozlov Maxim > >>> >>>>>>>>>>>>>>>>>>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>> Andrey, >>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>> Please review PR again. >>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>> 1 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., =D0=B2= 18:47, Andrey Gura = > = = >>> >>>>>>>>>>>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>> I think that it is ok. >>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>> On Wed, Mar 1, 2017 at 6:34 PM, Kozlov Maxim < >>>>>>>>>>>> dreamx.max@gmail.com = > = >>> >>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>> Ok. What do you say for the rest? >>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>> 1 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., = =D0=B2 18:15, Andrey Gura = > = = >>> >>>>>>>>>>>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>> Maxim, >>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>> I think that during renaming we should not lose = "Atomic" >>>>>>>>>>>> prefix. >>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>> On Wed, Mar 1, 2017 at 5:16 PM, Kozlov Maxim < >>>>>>>>>>>> dreamx.max@gmail.com = > = >>> >>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>>>> Andrey, ok. >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>> Also remove in the modules/platform/dotnet >>>>>>>>>>>>>>>>>>> CacheAtomicWriteOrderMode.cs? >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>> Rename classes: >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>> GridCacheAtomicNearCacheSelfTest.startGrids -> >>>>>>>>>>>>>>>>>>> GridCacheAtomicNearCacheSelfTest.startGridsLocal = (commit) >>>>>>>>>>>>>>>>>>>>>>>> = IgniteCacheAtomicPrimaryWriteOrderWithStoreInvokeTest -> >>>>>>>>>>>>>>>>>>> IgniteCacheWithStoreInvokeTest >>>>>>>>>>>>>>>>>>>>>>>> IgniteCacheAtomicPrimaryWriteOrderInvokeTest -> >>>>>>>>>>>>>>>>>>> IgniteCacheInvokeTest >>>>>>>>>>>>>>>>>>>>>>>> = IgniteCacheAtomicPrimaryWriteOrderNearEnabledStoreValueTest >>>>>>>>>>>> -> >>>>>>>>>>>>>>>>>>> IgniteCacheNearEnabledStoreValueTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicPrimaryWriteOrderNearRemoveFailureTest -> >>>>>>>>>>>>>>>>>>> GridCacheNearRemoveFailureTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicPrimaryWriteOrderRemoveFailureTest -> >>>>>>>>>>>>>>>>>>> GridCacheRemoveFailureTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicPrimaryWriteOrderFailoverSelfTest -> >>>>>>>>>>>>>>>>>>> GridCacheFailoverSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheValueConsistencyAtomicPrimaryWriteOrderNearEnabledS >>>>>>>>>>>> elfTest >>>>>>>>>>>>>>>>>>> -> GridCacheValueConsistencyNearEnabledSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = CacheContinuousQueryAsyncFailoverAtomicPrimaryWriteOrderSelfTest >>>>>>>>>>>> -> >>>>>>>>>>>>>>>>>>> CacheContinuousQueryAsyncFailoverSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = CacheContinuousQueryFailoverAtomicPrimaryWriteOrderSelfTest >>>>>>>>>>>> -> >>>>>>>>>>>>>>>>>>> CacheContinuousQueryFailoverSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicNearCacheSelfTest.testNoBackupsPrimaryWriteOrder >>>>>>>>>>>> -> >>>>>>>>>>>>>>>>>>> GridCacheAtomicNearCacheSelfTest.testNoBackups >>>>>>>>>>>>>>>>>>>>>>>> GridCacheAtomicNearCacheSelfTest. >>>>>>>>>>>> testWithBackupsPrimaryWriteOrder >>>>>>>>>>>>>>>>>>> -> GridCacheAtomicNearCacheSelfTest.testWithBackups >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>> Remove classes: >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>> = IgniteCacheAtomicPrimaryWriteOrderStoreValueTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheReplicatedAtomicPrimaryWriteOrderMultiNodeFullApiSe >>>>>>>>>>>> lfTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicPrimaryWriteOrderMultiNodeFullApiSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicPrimaryWriteOrderMultiNodeP2PDisabledFullApiS >>>>>>>>>>>> elfTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicPrimaryWrityOrderOffHeapMultiNodeFullApiSelfT >>>>>>>>>>>> est >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicPrimaryWriteOrderOffHeapFullApiSelfTest >>>>>>>>>>>>>>>>>>>>>>>> GridCacheAtomicPrimaryWriteOrderFullApiSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheAtomicPrimaryWriteOrderReloadAllSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = IgniteCachePutRetryAtomicPrimaryWriteOrderSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = GridCacheValueConsistencyAtomicPrimaryWriteOrderSelfTest >>>>>>>>>>>>>>>>>>>>>>>> = IgniteCacheAtomicPrimaryWriteOrderExpiryPolicyTest >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>> ok? :) >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>> 1 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2017 =D0=B3., = =D0=B2 2:04, Andrey Gura = > = = >>> >>>>>>>>>>>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0): >>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>> No, it should be removed. If somebody use = entry last update >>>>>>>>>>>> time >>>>>>>>>>>>>>>>>>> (e.g. >>>>>>>>>>>>>>>>>>>>>>>>> for conflict resolving) they should store this = time as entry >>>>>>>>>>>> field. >>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>> On Wed, Mar 1, 2017 at 12:57 AM, Dmitriy = Setrakyan >>>>>>>>>>>>>>>>>>>>>>>>> > >>> wrote: >>>>>>>>>>>>>>>>>>>>>>>>>> Do we still need GridClockSyncProcessor? >>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>> On Tue, Feb 28, 2017 at 5:26 AM, Andrey Gura = < >>>>>>>>>>>> agura@apache.org = > = = >>> >>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>> Maxim, >>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>> Yes, this setting doesn't make sense = anymore. So we need >>>>>>>>>>>> remove >>>>>>>>>>>>>>>>>>> all >>>>>>>>>>>>>>>>>>>>>>>>>>> related methods. >>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>> Also there is component called = GridClockSyncProcessor that >>>>>>>>>>>> also >>>>>>>>>>>>>>>>>>> should >>>>>>>>>>>>>>>>>>>>>>>>>>> be removed. It will lead to removing = globalTime field from >>>>>>>>>>>>>>>>>>>>>>>>>>> GridCacheVersion class and some related = methods. >>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>> On Tue, Feb 28, 2017 at 3:21 PM, Kozlov = Maxim < >>>>>>>>>>>>>>>>>>> dreamx.max@gmail.com = > = >>> >>>>>>>>>>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>>>>>>>> Valentin, >>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>> Then there is no need for setting = CacheConfiguration. >>>>>>>>>>>>>>>>>>> atomicWriteOrderMode. >>>>>>>>>>>>>>>>>>>>>>>>>>> What do you think, remove it and and related = methods? >>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>> 28 =D1=84=D0=B5=D0=B2=D1=80. 2017 =D0=B3., = =D0=B2 2:49, Valentin Kulichenko < >>>>>>>>>>>>>>>>>>>>>>>>>>> valentin.kulichenko@gmail.com = = > = = >>> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=BB(=D0=B0): >>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>> Hi Max, >>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>> In case we remove the CLOCK mode, I think = we should >>>>>>>>>>>> remove the >>>>>>>>>>>>>>>>>>> enum >>>>>>>>>>>>>>>>>>>>>>>>>>> too, as >>>>>>>>>>>>>>>>>>>>>>>>>>>>> well as configuration properties and other = code using >>>>>>>>>>>> this >>>>>>>>>>>>>>>>>>> enum. Having >>>>>>>>>>>>>>>>>>>>>>>>>>>>> enum with one value doesn't make sense to = me. >>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>> -Val >>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>> On Mon, Feb 27, 2017 at 5:09 AM, Kozlov = Maxim < >>>>>>>>>>>>>>>>>>> dreamx.max@gmail.com = > = >>> >>>>>>>>>>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Hi Igniters, >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> After remove CLOCK mode, = CacheAtomicWriteOrderMode enum >>>>>>>>>>>>>>>>>>> contains now >>>>>>>>>>>>>>>>>>>>>>>>>>> only >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> one value PRIMARY. Andrey Gura, = proposition remove >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> CacheAtomicWriteOrderMode enum. Will = there be something >>>>>>>>>>>>>>>>>>> special for >>>>>>>>>>>>>>>>>>>>>>>>>>> this >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> purpose is enum? >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> jira: = https://issues.apache.org/jira/browse/IGNITE-4587 = >>> >>>>>>>>>>>> < >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> = https://issues.apache.org/jira/browse/IGNITE-4587 = > >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>>>>>>>>>>>>>>>>>> Max K. >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>>>>>>>>>>>>>>>> Max K. >>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>>>>>>>>>>>> Max K. >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>>>>>>>>>> Max K. >>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>>>>>>>> Max K. >>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>>>>>>> Max K. >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>>>> Max K. >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Best Regards, >>>>>>>>>>>>>> Max K. >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>> -- >>>>>>>>>>>> Best Regards, >>>>>>>>>>>> Max K. >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>> -- >>>>>>>>> Best Regards, >>>>>>>>> Max K. >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>>=20 >>>>>>>>=20 >>>>>>>> -- >>>>>>>> Best Regards, >>>>>>>> Max K. >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>>>=20 >>>>>>=20 >>>>>> -- >>>>>> Best Regards, >>>>>> Max K. >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>=20 >>>>=20 >>>> -- >>>> Best Regards, >>>> Max K. >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>=20 >>> -- >>> Best Regards, >>> Max K. >>=20 >=20 > -- > Best Regards, > Max K. --Apple-Mail=_40CCAB1D-3E95-44CC-985F-954C37A306D5--