ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Вадим Опольский <vaopols...@gmail.com>
Subject IGNITE-933 ready for review
Date Tue, 14 Mar 2017 09:04:42 GMT
Hello everybody!

Denis, I prepared a pull-request and test executed successfully on TeamCity
with awaiting time 500 milliseconds.

Review it please - https://github.com/apache/ignite/pull/1615

Vadim Opolski

2017-03-10 23:04 GMT+03:00 Denis Magda <dmagda@apache.org>:

> Vadim,
>
> Please prepare a pull-request and make sure that the test passes on
> TeamCity.
>
> —
> Denis
>
> > On Mar 10, 2017, at 9:25 AM, Вадим Опольский <vaopolskij@gmail.com>
> wrote:
> >
> > Hello everyone!
> >
> > Denis, I've successfully executed GridFailFastNodeFailureDetectionSelfTest
> in IDE 10 times on VMware Workstation (3 GB RAM,  Intel Core i5-2520M) in
> single core mode with 300 MILLISECONDS timeout.
> >
> > What's the next step ?
> >
> > Vadim
> >
> >
> > 2017-03-07 22:25 GMT+03:00 Denis Magda <dmagda@apache.org <mailto:
> dmagda@apache.org>>:
> > Vadim,
> >
> > The timeout should be such that the test completes successfully on
> single core machine as well as on multi-core servers. Setting timeout to 3
> - 5 seconds should work.
> >
> > —
> > Denis
> >
> >> On Mar 7, 2017, at 1:55 AM, Вадим Опольский <vaopolskij@gmail.com
> <mailto:vaopolskij@gmail.com>> wrote:
> >>
> >> Denis,
> >>
> >> I'm planning to adjust processing time of incoming and outgoing
> messages by JMH benchmarks.
> >>
> >> What do you think are the parameters of commodity hardware/? RAM size?
> CPU speed ? or others ?
> >>
> >> Vadim
> >>
> >> 2017-03-06 22:36 GMT+03:00 Denis Magda <dmagda@apache.org <mailto:
> dmagda@apache.org>>:
> >> Vadim,
> >>
> >> How do you plan to adjust processing time of incoming and outgoing
> messages? In general, I don’t think that you need to move the direction of
> the communication layer.
> >>
> >> I’m thinking that you just need to set some reasonable awaiting time so
> that the test passes on a commodity hardware.
> >>
> >> —
> >> Denis
> >>
> >>> On Mar 6, 2017, at 2:31 AM, Вадим Опольский <vaopolskij@gmail.com
> <mailto:vaopolskij@gmail.com>> wrote:
> >>>
> >>> Hi everyone!
> >>>
> >>> I executed test GridFailFastNodeFailureDetectionSelfTest.testFailFast
> fails periodically with different values of node quantity and awaiting
> time. Test fails if the awaiting time is less than 600 miliseconds.
> >>> I debugged test and understood that messaging took a lot of time in
> this case.
> >>> I want to measure (with GridFailFastNodeFailureDetectionSelfTest.testFailFast)
> and increase speed of receiving and sending message.
> >>>
> >>> Denis, what do you think about it ?
> >>>
> >>> Vadim Opolski
> >>>
> >>>
> >>> 2017-02-24 5:55 GMT+03:00 Denis Magda <dmagda@apache.org <mailto:
> dmagda@apache.org>>:
> >>> Hi Vadim,
> >>>
> >>> Yes, this issue might be still relevant. I can’t guide you through
> but, basically, you need to reproduce the issue, spot it in the code and
> propose a fix.
> >>>
> >>> BTW, do you have any experience with Hibernate? If so, I would be
> amazing if you pick up this ticket reassigning on yourself:
> >>> https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794> <
> https://issues.apache.org/jira/browse/IGNITE-1794 <
> https://issues.apache.org/jira/browse/IGNITE-1794>>
> >>>
> >>> —
> >>> Denis
> >>>
> >>> > On Feb 23, 2017, at 2:40 AM, Вадим Опольский <vaopolskij@gmail.com
> <mailto:vaopolskij@gmail.com>> wrote:
> >>> >
> >>> > Dear sirs !
> >>> >
> >>> > I want to resolve issue IGNITE-933
> >>> >
> >>> > https://issues.apache.org/jira/browse/IGNITE-933 <
> https://issues.apache.org/jira/browse/IGNITE-933>
> >>> >
> >>> > Is it actual ?
> >>> >
> >>> > In which class and method you want me to make changes ?
> >>> >
> >>> > Vadim Opolski
> >
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message