ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ALEKSEY KUZNETSOV <alkuznetsov...@gmail.com>
Subject Re: Unused argument in DirectMessageWriter
Date Thu, 16 Mar 2017 12:51:31 GMT
watch him, he is gonna remove all the messages he doesn't like :)

чт, 16 мар. 2017 г. в 14:56, Valentin Kulichenko <
valentin.kulichenko@gmail.com>:

> Hi,
>
> These classes are part of plugin framework. Even though 'name' argument is
> not used by Ignite implementations, it can be used by others. Therefore it
> should not be removed.
>
> -Val
>
> On Thu, Mar 16, 2017 at 10:36 AM, Александр Меньшиков <
> sharplermc@gmail.com>
> wrote:
>
> > Hello, everyone!
> >
> > I found some strange thing. In 'MessageWriter' there are a lot of methods
> > like 'write*(String name, * val)'. But in implementation
> > 'DirectMessageWriter' argument 'name' isn't used in these methods. And
> > there aren't other 'MessageWriter' implementations.
> >
> > Maybe we can remove 'name' from interface and implementation?
> >
>
-- 

*Best Regards,*

*Kuznetsov Aleksey*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message