Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CABuYRcr2nN11Z2dy+M1HTx+fpkvU_dOz9BvER1ZBA8n=zgHN9g@mail.gmail.com>
References: <CAMDWjONo2R+bmHiY2-HNKO_=tPdSew0SN8tQNFcakikgEGFczw@mail.gmail.com>
 <CABuYRcoPZ+tu5gRmxb3WGtN7barAN79U1bCBgdbkiG1Qsm8Paw@mail.gmail.com>
 <CA+0=VoVc+PHiCU9=vBHbuOQTGvWojqi+h_=Xrg9h-wV8MQ4NUQ@mail.gmail.com>
 <CABuYRcrk-Z-913czhDp577EfnA9XzikOuDavTdvc+rncG20cmA@mail.gmail.com>
 <CAGt6o8k_Ytx_z_cynwurpUPQWteJYcq2dRfgy6P62DyBpx3uiA@mail.gmail.com>
 <CABuYRcorhZD0T-TiQYFHmk0nQB=7j-FbjUNP0nDP1ougBzzmjQ@mail.gmail.com>
 <CAMDWjOP1bTcqGw3hZ9LO9jhQjmVgVOXO2A6jONJ0+k3VkcR12g@mail.gmail.com> <CABuYRcr2nN11Z2dy+M1HTx+fpkvU_dOz9BvER1ZBA8n=zgHN9g@mail.gmail.com>
From: =?UTF-8?B?0JLQsNC00LjQvCDQntC/0L7Qu9GM0YHQutC40Lk=?= <vaopolskij@gmail.com>
Date: Tue, 21 Feb 2017 11:28:46 +0300
Message-ID: <CAMDWjOPEypFDNqLwM+=JfkkQW0eEgFcz6NGPSDqSPRxvXk6tFQ@mail.gmail.com>
Subject: Re: IGNITE-13
To: Valentin Kulichenko <valentin.kulichenko@gmail.com>
Cc: Vladimir Ozerov <vozerov@gridgain.com>, dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=001a11440f029d20ff0549062d2f
archived-at: Tue, 21 Feb 2017 08:29:43 -0000

--001a11440f029d20ff0549062d2f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Valentin!

I compare speed of different methods how to get byte from string and push
it to outputstream.

Third method is the fastest.

Ok, I'm creating a benchmark for BinaryWriterExImpl#doWriteString method,
and making the change described in the ticket.

https://issues.apache.org/jira/browse/IGNITE-13

Vadim

2017-02-21 1:06 GMT+03:00 Valentin Kulichenko <valentin.kulichenko@gmail.co=
m
>:

> Hi Vadim,
>
> I'm not sure I understand your benchmarks and how they verify the
> optimization discussed here. Basically, here is what needs to be done:
>
> 1. Create a benchmark for BinaryWriterExImpl#doWriteString method.
> 2. Run the benchmark with current implementation.
> 3. Make the change described in the ticket.
> 4. Run the benchmark with these changes.
> 5. Compare results.
>
> Makes sense? Let me know if anything is unclear.
>
> -Val
>
> On Mon, Feb 20, 2017 at 8:51 AM, =D0=92=D0=B0=D0=B4=D0=B8=D0=BC =D0=9E=D0=
=BF=D0=BE=D0=BB=D1=8C=D1=81=D0=BA=D0=B8=D0=B9 <vaopolskij@gmail.com>
> wrote:
>
>> Hello everybody!
>>
>> https://issues.apache.org/jira/browse/IGNITE-13
>>
>> Valentin, I just have finished benchmark (with JMH) -
>> https://github.com/javaller/MyBenchmark.git
>>
>> It collect data about time working of serialization.
>>
>> For instance - https://github.com/javaller/My
>> Benchmark/blob/master/out200217.txt
>>
>> To start it you have to do next:
>>
>> 1) clone it - git colne https://github.com/javaller/MyBenchmark.git
>>
>> 2) install it - mvn install
>>
>> 3) run benchmarks -  java -Xms1024m -Xmx4096m -jar target\benchmarks.jar
>>
>> Vadim Opolski
>>
>>
>>
>>
>>
>> 2017-02-15 0:52 GMT+03:00 Valentin Kulichenko <
>> valentin.kulichenko@gmail.com>:
>>
>>> Vladimir,
>>>
>>> I think we misunderstood each other. My understanding of this
>>> optimization is the following.
>>>
>>> Currently string serialization is done in two steps (see
>>> BinaryWriterExImpl#doWriteString):
>>>
>>> strArr =3D BinaryUtils.strToUtf8Bytes(val); // Encode string into byte
>>> array.
>>> out.writeByteArray(strArr);                      // Write byte array
>>> into stream.
>>>
>>> What this ticket suggests is to write directly into stream while string
>>> is encoded, without intermediate array. This both reduces memory
>>> consumption and eliminates array copy step.
>>>
>>> I updated the ticket and added this explanation there.
>>>
>>> Vadim, can you create a micro benchmark and check if it gives any
>>> improvement?
>>>
>>> -Val
>>>
>>> On Sun, Feb 12, 2017 at 10:38 PM, Vladimir Ozerov <vozerov@gridgain.com=
>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> It is hard to say whether it makes sense or not. No doubt, it could
>>>> speed up marshalling process at the cost of 2x memory required for str=
ings.
>>>> From my previous experience with marshalling micro-optimizations, we w=
ill
>>>> hardly ever notice speedup in distributed environment.
>>>>
>>>> But, there is another sied - it could speedup our queries, because we
>>>> will not have to unmarshal string on every field access. So I would tr=
y to
>>>> make this optimization optional and then measure query performance wit=
h
>>>> classes having lots of strings. It could give us interesting results.
>>>>
>>>> On Mon, Feb 13, 2017 at 5:37 AM, Valentin Kulichenko <
>>>> valentin.kulichenko@gmail.com> wrote:
>>>>
>>>>> Vladimir,
>>>>>
>>>>> Can you please take a look and provide your thoughts? Can this be
>>>>> applied to binary marshaller? From what I recall, it serializes strin=
g a
>>>>> bit differently from optimized marshaller, so I'm not sure.
>>>>>
>>>>> -Val
>>>>>
>>>>> On Fri, Feb 10, 2017 at 5:16 PM, Dmitriy Setrakyan <
>>>>> dsetrakyan@apache.org> wrote:
>>>>>
>>>>>> On Thu, Feb 9, 2017 at 11:26 PM, Valentin Kulichenko <
>>>>>> valentin.kulichenko@gmail.com> wrote:
>>>>>>
>>>>>> > Hi Vadim,
>>>>>> >
>>>>>> > I don't think it makes much sense to invest into
>>>>>> OptimizedMarshaller.
>>>>>> > However, I would check if this optimization is applicable to
>>>>>> > BinaryMarshaller, and if yes, implement it.
>>>>>> >
>>>>>>
>>>>>> Val, in this case can you please update the ticket?
>>>>>>
>>>>>>
>>>>>> >
>>>>>> > -Val
>>>>>> >
>>>>>> > On Thu, Feb 9, 2017 at 11:05 PM, =D0=92=D0=B0=D0=B4=D0=B8=D0=BC =
=D0=9E=D0=BF=D0=BE=D0=BB=D1=8C=D1=81=D0=BA=D0=B8=D0=B9 <
>>>>>> vaopolskij@gmail.com>
>>>>>> > wrote:
>>>>>> >
>>>>>> > > Dear sirs!
>>>>>> > >
>>>>>> > > I want to resolve issue IGNITE-13 -
>>>>>> > > https://issues.apache.org/jira/browse/IGNITE-13
>>>>>> > >
>>>>>> > > Is it actual?
>>>>>> > >
>>>>>> > > Vadim Opolski
>>>>>> > >
>>>>>> >
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>

--001a11440f029d20ff0549062d2f--