ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ALEKSEY KUZNETSOV <alkuznetsov...@gmail.com>
Subject Re: PR IGNITE-2845 Get operation might ignore entry update from EntryProcessor
Date Wed, 22 Feb 2017 07:40:45 GMT
Do it in scope of 3471, and plz change status in my ticket accordingly :
https://issues.apache.org/jira/browse/IGNITE-2845

вт, 21 февр. 2017 г. в 23:24, Alexander Fedotov <
alexander.fedotoff@gmail.com>:

> Hi,
>
> Here are my findings.
> The case is related to IGNITE-3471 and will be done in its scope.
> I've tried a simple fix that enables missed checks for keys for which there
> are entry processors
> and it has worked. Still, a more elaborate solution is required that
> accounts the entry modification type,
> i.e. CREATE in this case, because the simple fix leads to entry processors
> being called two times.
> Shall I prepare a fix for
> https://issues.apache.org/jira/browse/IGNITE-2845 or
> do it in scope of IGNITE-3471?
>
> On Tue, Feb 21, 2017 at 8:26 PM, Alexander Fedotov <
> alexander.fedotoff@gmail.com> wrote:
>
> > Hi,
> >
> > Looks like that it's actually related to https://issues.apache.org/jira
> > /browse/IGNITE-3471.
> > I'll take a look at it. I would suggest, it is by design behavior.
> > Let me check.
> >
> > On Tue, Feb 21, 2017 at 8:13 PM, Alexey Goncharuk <
> > alexey.goncharuk@gmail.com> wrote:
> >
> >> Aleksey,
> >>
> >> I am not sure your change is a correct fix. The whole point of
> >> EntryProcessor is to avoid sending values over the network and send only
> >> entry processor result, which is typically smaller than the value stored
> >> in
> >> a cache.
> >>
> >> Looks like this case is covered by the following ticket:
> >> https://issues.apache.org/jira/browse/IGNITE-3471. Please cooperate
> with
> >> Alexandr to make sure your test is included in his fix.
> >>
> >> --AG
> >>
> >> 2017-02-21 14:44 GMT+03:00 ALEKSEY KUZNETSOV <alkuznetsov.sb@gmail.com
> >:
> >>
> >> > PR redy, welcome to review :
> https://github.com/apache/ignite/pull/1557
> >> >
> >> > https://issues.apache.org/jira/browse/IGNITE-2845
> >> > --
> >> >
> >> > *Best Regards,*
> >> >
> >> > *Kuznetsov Aleksey*
> >> >
> >>
> >
> >
> >
> > --
> > Kind regards,
> > Alexander.
> >
>
>
>
> --
> Kind regards,
> Alexander.
>
-- 

*Best Regards,*

*Kuznetsov Aleksey*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message