Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CA+0=VoVNEnZvJtCJ2nJi29fFDvYnJyTjPB8Y19L6eQ4vz6HmUA@mail.gmail.com>
References: <CAK2_iMM9QspKLftxonyf4zA64hfY2K2+F65RmC0z=jHNNgqJjw@mail.gmail.com>
 <CA+0=VoXV3bxcyCZ2xB9SNgPPyu83pkFW0cTYMJk+jwrS9YTzLA@mail.gmail.com>
 <CAK2_iMMGUKQofbdGBw0ZTyUX5y9B_FNdrXUO7bg0fJtVHBoWpQ@mail.gmail.com>
 <CA+0=VoWyw35ZfMUDsGMkOzjYXFHNk+sRjSLmu-Y+ETX0jT4kbw@mail.gmail.com>
 <CAK2_iMOnsVsj_QCnEyF4rHyuD7Kj1XSFxHR6-SH6DdqiPR4nZw@mail.gmail.com>
 <CA+0=VoU3Z6xRVOyNkEUSch3zJcyr8r+yQLmbB-9OPmR=XnpTPw@mail.gmail.com>
 <1483095204638-13451.post@n4.nabble.com> <CAGcMBHiF==Ua5GddRdzfSUwtTfX7aW-yDSCK7zxd-iynezHWfQ@mail.gmail.com>
 <CA+0=VoUnMjbAwY=CE=RRo=HbskOzfCOtemmKMgScxqMOcOqRdg@mail.gmail.com>
 <CAGcMBHh3GRTXdybqeUb5s+oXp-kE_wAJCrJZZfceeT3mNGVmug@mail.gmail.com>
 <5663DBA5-DF2E-4D2E-ABFF-22D5E1DFB8FC@apache.org> <CABuYRcrMm2q1vYGPPHvjnJ1SAAeXiMF7OSxvcpcL0P_F0g5HSA@mail.gmail.com>
 <2009F2EB-E108-4B34-B297-1ABF67EB2FC7@apache.org> <49C2B265-D66F-41B4-827D-686CFB989205@apache.org>
 <CA+0=VoUpfUbcDJExjiLo0uvWGZkrXwdGT_q6Og-xtwv+pt5WRw@mail.gmail.com>
 <7DA871AD-2CC0-49F3-BB37-320F88840481@apache.org> <CA+0=VoUYcMjH6O1qzC9-7CHciP-WcDn5DkMBrkHPAKqmvYcPsg@mail.gmail.com>
 <D7E1236E-5EDA-4A26-8A45-7F329D9999EA@apache.org> <CAO=R_k6fTg3SrrtZyBkq335CTUty9cpqFrscOSfT3AaeZX70iw@mail.gmail.com>
 <CAK0qHnqBTM1Nb1KoxLBAb_qiAikJGG1Q5v0-2z24B32q_t=bNQ@mail.gmail.com>
 <CABuYRcr_BZ=FfbYa66AFh3yaJg7xCFqyA6snOJEV5HdVJ0=XwA@mail.gmail.com>
 <CAK0qHnox5uOp3fZ+OR9KkWZpr7u4X+hxkn-GUTRiqWaygxADvA@mail.gmail.com> <CA+0=VoVNEnZvJtCJ2nJi29fFDvYnJyTjPB8Y19L6eQ4vz6HmUA@mail.gmail.com>
From: Alexander Fedotov <alexander.fedotoff@gmail.com>
Date: Sat, 31 Dec 2016 11:23:18 +0300
Message-ID: <CAO=R_k5ZBtszaX=Pk=LUw3xzL_VK1x87u3vS7W9heUtOoe-gWQ@mail.gmail.com>
Subject: Re: IgniteConfiguration.gridName is very confusing
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=f403045e286ee7a2ec0544f007fe
archived-at: Sat, 31 Dec 2016 08:23:37 -0000

--f403045e286ee7a2ec0544f007fe
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Okay. From the all said above I suppose "instanceName" should work for
IgniteConfiguration and "igniteInstanceName" in all other places.

Regards,
Alexander

31 =D0=B4=D0=B5=D0=BA. 2016 =D0=B3. 3:43 AM =D0=BF=D0=BE=D0=BB=D1=8C=D0=B7=
=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C "Dmitriy Setrakyan" <
dsetrakyan@apache.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:

It sounds like it must be unique then. I would propose the following:

   1. If user defines the instanceName, then we assign it to the node.
   2. If user does not define the instance name, then we have to give it
   some unique value, like node ID or PID.

Will this change be backward compatible, or should we leave it as null if
user does not define it?

D.

On Fri, Dec 30, 2016 at 4:19 PM, Denis Magda <dmagda@gridgain.com> wrote:

> Sounds reasonable. Agree that 'instanceName' suits better considering you=
r
> explanation.
>
> --
> Denis
>
> On Friday, December 30, 2016, Valentin Kulichenko <
> valentin.kulichenko@gmail.com> wrote:
> > This name identifies instance of Ignite, in case there are more than on=
e
> > within an application. Here are our API methods around this:
> >
> > // We provide a name and get newly started *Ignite* instance.
> > Ignite ignite =3D Ignition.start(new
> IgniteConfiguration().setGridName(name));
> >
> > // We provide a name and get existing *Ignite* instance.
> > Ignite ignite =3D Ignition.ignite(name);
> >
> > This has nothing to do with nodes. For node representation we have
> > ClusterNode API, which already has nodeId() method for identification.
> >
> > In other words, if we choose nodeName, we will have both nodeName and
> > nodeId in the product, but with absolutely different meaning and used i=
n
> > different parts of API. How user is going to understand the difference
> > between them? In my view, this is even more confusing than current
> gridName.
> >
> > -Val
> >
> > On Fri, Dec 30, 2016 at 2:42 PM, Denis Magda <dmagda@gridgain.com>
> wrote:
> >
> >> Alexander, frankly speaking I'm still for your original proposal -
> >> nodeName. The uniqueness specificities can be set in the doc.
> >>
> >> --
> >> Denis
> >>
> >> On Friday, December 30, 2016, Alexander Fedotov <
> >> alexander.fedotoff@gmail.com> wrote:
> >> > Well, then may be we should go with one of the below names:
> >> >
> >> > processNodeName
> >> > jvmNodeName
> >> > runtimeNodeName
> >> > processScopedNodeName
> >> > jvmScopedNodeName
> >> > runtimeScopedNodeName
> >> > processWideNodeName
> >> > jvmWideNodeName
> >> > runtimeWideNodeName
> >> >
> >> > Regards,
> >> > Alexander
> >> >
> >> > 31 =D0=B4=D0=B5=D0=BA. 2016 =D0=B3. 12:37 AM =D0=BF=D0=BE=D0=BB=D1=
=8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C "Denis Magda" <
> dmagda@apache.org>
> >> > =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:
> >> >
> >> > The parameter specifies a node name which has to be unique per JVM
> >> process
> >> > (if you start multiple nodes in a single process). In my
understanding
> it
> >> > was mainly introduced to handle these multiple-nodes-per-JVM
> scenarios.
> >> >
> >> > However, several nodes can have the same name cluster wide.
> >> >
> >> > =E2=80=94
> >> > Denis
> >> >
> >> >
> >> >> On Dec 30, 2016, at 1:30 PM, Dmitriy Setrakyan <
> dsetrakyan@apache.org>
> >> > wrote:
> >> >>
> >> >> Now I am confused. What is the purpose of this configuration
> parameter?
> >> >>
> >> >> On Fri, Dec 30, 2016 at 1:15 PM, Denis Magda <dmagda@apache.org>
> wrote:
> >> >>
> >> >>> See Val=E2=80=99s concern in the discussion. I=E2=80=99m absolutel=
y fine with
> >> =E2=80=98nodeName=E2=80=99.
> >> >>>
> >> >>> =E2=80=94
> >> >>> Denis
> >> >>>
> >> >>>> On Dec 30, 2016, at 1:13 PM, Dmitriy Setrakyan <
> dsetrakyan@apache.org
> >> >
> >> >>> wrote:
> >> >>>>
> >> >>>> On Fri, Dec 30, 2016 at 1:12 PM, Denis Magda <dmagda@apache.org>
> >> wrote:
> >> >>>>
> >> >>>>> What=E2=80=99s about =E2=80=98localNodeName=E2=80=99?
> >> >>>>>
> >> >>>>
> >> >>>> Why is it better than "nodeName"? Isn't it obvious that the name
is
> >> for
> >> >>> the
> >> >>>> local node?
> >> >>>
> >> >>>
> >> >
> >>
> >
>

--f403045e286ee7a2ec0544f007fe--