Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C9C98200BE3 for ; Thu, 22 Dec 2016 12:09:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C8776160B26; Thu, 22 Dec 2016 11:09:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EE642160B1F for ; Thu, 22 Dec 2016 12:09:55 +0100 (CET) Received: (qmail 74803 invoked by uid 500); 22 Dec 2016 11:09:55 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 74787 invoked by uid 99); 22 Dec 2016 11:09:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2016 11:09:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 564F51A03FF for ; Thu, 22 Dec 2016 11:09:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.98 X-Spam-Level: * X-Spam-Status: No, score=1.98 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gridgain-com.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lCDHqiCYP1HF for ; Thu, 22 Dec 2016 11:09:52 +0000 (UTC) Received: from mail-ua0-f178.google.com (mail-ua0-f178.google.com [209.85.217.178]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id CDFC45F36B for ; Thu, 22 Dec 2016 11:09:51 +0000 (UTC) Received: by mail-ua0-f178.google.com with SMTP id 2so104164190uax.2 for ; Thu, 22 Dec 2016 03:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gridgain-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=MEuK8JIV1srZDOEMH2A7p4qMxYbjoO5yvaJUk12pXa4=; b=yew6Il670/Zh8iHPBas1AyLdhqVHWOTJDy/deBlCmxM5Bu6mlZhc62/07Zvg3jQPu6 gufyrBPXVUprWbIDWfSL87MS196aIXWAiw5Y3ZbzWc3Eu5K202s1qmkJ1/puudGqSvCr 825BOVGHwWpqwqmpkYy5izTb9Wx6nOLewdSohu15AR5UGEKQjfEFK/P0eJrvNOlPxfCy Wu896f40MHd3HqFUHIjJVejQQJxt41rlvMZXwoancXtM50o5Gd+k24ty6rcKwHIbLGCw ZELbGU4EhsltYndyMcE3ajvnCY+OG4rfhtn7AaFpoA4c3oev80FS6OK5vsScA8zRTFoR djQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=MEuK8JIV1srZDOEMH2A7p4qMxYbjoO5yvaJUk12pXa4=; b=qU24QHU767EvRaBfphDm8uwDAUsie89FmqQH2hFf5VG1YvV3KT2gwvKV5UMR79YMmF 5EpqGQj/VpRqCwE01jLxXGouaad5JBriU3i4qe3KR/8mpSohoiCpR1XxnTdmH0BEJj5m MvpOdglfAaLbII40t3aOe7lXDKReHSbfFRRIgwBYYAgMHUKGBpfITqLcTdImNeYh8rRM vBvnCDE3CGFJwLNndz6A1UWzqA+MjSdN16gpFeeXjb8yzIWvAoBf1ykaXM4X6UvYQXaO /cr2tdqiXitbGwvGn3+pRaSyzqoXDa8NHpZUONsh5zoHOimaGWx7xEVAU6kSD663basx R6xg== X-Gm-Message-State: AIkVDXJ6hJ37H+aiGzODtjAN4xdAf0WN353DoWJ8wb2GxhrxNvNnIzmFTh5CFQUbykzjAuu51hKXj870efzvfRWa X-Received: by 10.176.74.26 with SMTP id q26mr7552431uae.100.1482404985213; Thu, 22 Dec 2016 03:09:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.159.56.218 with HTTP; Thu, 22 Dec 2016 03:09:44 -0800 (PST) In-Reply-To: References: From: Vladimir Ozerov Date: Thu, 22 Dec 2016 14:09:44 +0300 Message-ID: Subject: Re: Make async API great again To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary=f403045f8ac48ec40405443d4ee9 archived-at: Thu, 22 Dec 2016 11:09:57 -0000 --f403045f8ac48ec40405443d4ee9 Content-Type: text/plain; charset=UTF-8 And several more improvements to future API: 1) Remove startTime() and duration() methods: https://issues.apache.org/jira/browse/IGNITE-4479 2) Fix broken cancellation semantics: https://issues.apache.org/jira/browse/IGNITE-4480 On Thu, Dec 22, 2016 at 1:40 PM, Vladimir Ozerov wrote: > Gents, > > I created tickets for all proposed improvements: > 1) Nice async API: https://issues.apache.org/jira/browse/IGNITE-4475 > 2) Do not process IO messages synchronously for local node: > https://issues.apache.org/jira/browse/IGNITE-4476 > 3) Better IgniteFuture API and callback semantics: https://issues. > apache.org/jira/browse/IGNITE-4477 > > Please review it and let me know if you have any comments. > > Vladimir. > > On Wed, Dec 21, 2016 at 4:32 AM, Dmitriy Setrakyan > wrote: > >> Would be nice if someone would prototype a new cache API and post the >> generated javadoc here. I think we all will benefit from reviewing it. >> >> On Tue, Dec 20, 2016 at 12:17 PM, Vladimir Ozerov >> wrote: >> >> > Async API rework is mechanical addition of ~100 methods through >> copy-paste. >> > Should not take more than a day to implement and more than another day >> to >> > rework tests. >> > >> > On Tue, Dec 20, 2016 at 10:00 PM, Dmitriy Setrakyan < >> dsetrakyan@apache.org >> > > >> > wrote: >> > >> > > How difficult is this change? Does not look like it can be done >> > overnight. >> > > >> > > On Tue, Dec 20, 2016 at 10:46 AM, Vladimir Ozerov < >> vozerov@gridgain.com> >> > > wrote: >> > > >> > > > We already discussed this several months ago in other thread. >> > > > >> > > > "Async" methods is the most simple and straight API possible. .NET >> > world >> > > > goes this way all over their frameworks and nobody died. Hazelcast >> also >> > > > goes this way. Java goes this way (see CompletableFuture). This is >> > common >> > > > and well-known practice. The most impacted part of our API will be >> > cache, >> > > > +33 new methods. Though, I do not see how it can affect learning >> curve. >> > > > >> > > > Agree that we should deprecate AsyncSupport gradually and remove it >> no >> > > > earlier than in Apache Ignite 3.0. >> > > > >> > > > On Tue, Dec 20, 2016 at 9:31 PM, Dmitriy Setrakyan < >> > > dsetrakyan@apache.org> >> > > > wrote: >> > > > >> > > > > On Tue, Dec 20, 2016 at 10:28 AM, Sergi Vladykin < >> > > > sergi.vladykin@gmail.com >> > > > > > >> > > > > wrote: >> > > > > >> > > > > > +1 For removing withAsync. It is a broken design. >> > > > > > >> > > > > >> > > > > Sergi, do you also want to add all the async methods to the main >> API >> > or >> > > > do >> > > > > you have some other design in mind? >> > > > > >> > > > >> > > >> > >> > > --f403045f8ac48ec40405443d4ee9--