Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CAGcMBHjikODnqvdDHQBnvPyJ3+29NHU0ESw5t6yf4OKMEC0LCw@mail.gmail.com>
References: <CAFyTW-gg0SYijb66ZBD0M-fQKuURTXUWWL3yBNuiMUL784YJBQ@mail.gmail.com>
 <CAGcMBHjikODnqvdDHQBnvPyJ3+29NHU0ESw5t6yf4OKMEC0LCw@mail.gmail.com>
From: Vyacheslav Daradur <daradurvs@gmail.com>
Date: Tue, 27 Dec 2016 14:46:05 +0300
Message-ID: <CAFyTW-hEsD91RUNYiGvVwxY3B7idYAX=9_6gsOe+Hg7fSf8wyA@mail.gmail.com>
Subject: Re: IGNITE-4374 - Ignite should validate JVM and OS configuration and
 output warning in log
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=f403045ea296c2e95e0544a2659f
archived-at: Tue, 27 Dec 2016 11:46:17 -0000

--f403045ea296c2e95e0544a2659f
Content-Type: text/plain; charset=UTF-8

>>
3. I think this should be a new section in performance suggestion output.
And I think the GridPerformanceSuggestions should be used, but it should be
probably renamed to reflect its new role and remove Grid prefix also. How
about ConfigurationSuggestions?
>>
How about:

public class ConfigurationValidator {

      public static String getPerformanceSuggestions() {...}

      public static List<String> getPerformanceSuggestions() {...}

}


2016-12-27 14:12 GMT+03:00 Yakov Zhdanov <yzhdanov@apache.org>:

> Vyacheslav, my comments are below.
>
> >>
> 1. It is necessary to check a flag MaxDirectMemorySize, but there is no
> recommendation of it:
> https://apacheignite.readme.io/docs/jvm-and-system-tuning
>
> 2. Whether it is necessary to output message in "Quiet mode"?
>
> 3. Where it is better to output information about checking? At the end or
> maybe before "Ignite node started OK"?
> >>
>
> 1. Alex Goncharuk, can you please help here? How can we determine how much
> direct memory we need? Vyacheslav, you can skip this for the very first
> version.
>
> 2. Yes
>
> 3. I think this should be a new section in performance suggestion output.
> And I think the GridPerformanceSuggestions should be used, but it should be
> probably renamed to reflect its new role and remove Grid prefix also. How
> about ConfigurationSuggestions?
>
> --Yakov
>

--f403045ea296c2e95e0544a2659f--