Return-Path: <dev-return-17266-archive-asf-public=cust-asf.ponee.io@ignite.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id C3310200BE3
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Thu, 22 Dec 2016 20:55:28 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id C1C1E160B26; Thu, 22 Dec 2016 19:55:28 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 0C006160B1B
	for <archive-asf-public@cust-asf.ponee.io>; Thu, 22 Dec 2016 20:55:27 +0100 (CET)
Received: (qmail 89600 invoked by uid 500); 22 Dec 2016 19:55:27 -0000
Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@ignite.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@ignite.apache.org>
List-Post: <mailto:dev@ignite.apache.org>
List-Id: <dev.ignite.apache.org>
Reply-To: dev@ignite.apache.org
Delivered-To: mailing list dev@ignite.apache.org
Received: (qmail 89589 invoked by uid 99); 22 Dec 2016 19:55:27 -0000
Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Dec 2016 19:55:27 +0000
Received: from [192.168.75.153] (c-73-222-138-29.hsd1.ca.comcast.net [73.222.138.29])
	by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id E3E361A028B
	for <dev@ignite.apache.org>; Thu, 22 Dec 2016 19:55:26 +0000 (UTC)
From: Denis Magda <dmagda@apache.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\))
Subject: Re: Node attribute filter
Date: Thu, 22 Dec 2016 11:55:26 -0800
References: <CABuYRco6ZD6ND31HfTK_bNtkZpFGwExL7aEhVRd3qzYTjEVoAg@mail.gmail.com>
To: dev@ignite.apache.org
In-Reply-To: <CABuYRco6ZD6ND31HfTK_bNtkZpFGwExL7aEhVRd3qzYTjEVoAg@mail.gmail.com>
Message-Id: <3595FF1E-B107-4DC0-8276-E542B0C9221A@apache.org>
X-Mailer: Apple Mail (2.3259)
archived-at: Thu, 22 Dec 2016 19:55:28 -0000

Val, thanks. Reviewed. Looks good to merge.

=E2=80=94
Denis

> On Dec 20, 2016, at 3:27 PM, Valentin Kulichenko =
<valentin.kulichenko@gmail.com> wrote:
>=20
> Guys,
>=20
> I created a simple implementation of IgnitePredicate<ClusterNode> =
based on
> user attributes. This is the most commonly used approach for node =
filters,
> but currently users are forced to create their own implementations =
each
> time. Would be useful to have it out of the box.
>=20
> Can someone take a look at the implementation and tell me if there is
> anything wrong/missed?
>=20
> Ticket: https://issues.apache.org/jira/browse/IGNITE-4439
> PR: https://github.com/apache/ignite/pull/1369
>=20
> -Val