Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CAGt6o8n+HkAkBByoUbW=HGickoQ-C5s3M_9fDssv2K8GGQ7R9Q@mail.gmail.com>
References: <CAEHhZ=mbj6q-MCWC+w_+TFYud+i8d9YGEUNM=b78iZfrkF4hPA@mail.gmail.com>
 <CAGt6o8n0OwYc1CtNXQLdhy26Xsv_A+=14GCxyKdsrd4Y3sQBZw@mail.gmail.com>
 <CAGt6o8nmxHU9M9rpqVrOeiF_DtaYnK4ekFpYrR_jbZKK27bRXg@mail.gmail.com> <CAGt6o8n+HkAkBByoUbW=HGickoQ-C5s3M_9fDssv2K8GGQ7R9Q@mail.gmail.com>
From: Vladimir Ozerov <vozerov@gridgain.com>
Date: Mon, 7 Nov 2016 09:09:47 +0300
Message-ID: <CAGt6o8mu0LJYRYSZSSsVn2rqzzQ0N7SKgdASvT3jocQQBGG=Gw@mail.gmail.com>
Subject: Re: IGNITE-3999: Design discussion
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=001a114db57ef62be40540afde8b
archived-at: Mon, 07 Nov 2016 06:09:58 -0000

--001a114db57ef62be40540afde8b
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Amir,

Having POJO class QueryField looks like a good idea to me. Because we will
be able to encapsulate more field information into it over time. E.g. we
can add "keyField" flag for DML there.

I would even think about removing map from method signature in favor of
simple list/array:

void setFields(QueryField...);

Vladimir.

07 =D0=BD=D0=BE=D1=8F=D0=B1. 2016 =D0=B3. 7:32 =D0=BF=D0=BE=D0=BB=D1=8C=D0=
=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C "Amir Akhmedov" <amir.akhmedo=
v@gmail.com>
=D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:

Hi Igniters,

I was looking into ticket IGNITE-3999 and I have a concern on this, can you
please advise what will be the correct way to solve it. As of today, SQL
fields are defined as setFields(LinkedHashMap<String, String> fields), with
introduction of case insensitive property need to create a new POJO
e.g. QueryField(String
type, boolean caseInsensitive). So, to keep backward compatibility we can
introduce a new method e.g. setQueryFields(LinkedHashMap<String,
QueryField> fields), in my opinion it looks like counter-intuitive with
existing setFields method. Another possible way, this change can be done
with changing the generic type of setFields (which will not be backward
compatible) and released in Ignite 2.0.
Please advise on this, or maybe you have an alternative solutions?

--
Sincerely Yours Amir Akhmedov

--001a114db57ef62be40540afde8b--