ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Setrakyan <dsetrak...@apache.org>
Subject Re: [VOTE] Use Upsource for Code Review
Date Wed, 16 Nov 2016 11:33:18 GMT
+1

I think we should allow this tool, unless it proves counter productive. If
it does, then we will drop it.

On Wed, Nov 16, 2016 at 11:44 AM, Pavel Tupitsyn <ptupitsyn@apache.org>
wrote:

> Sergi,
>
> I don't think we should enforce it.
> "Official" means that it will be allowed, linked and described in wiki.
>
> It is up to contributor and reviewer to use it.
> For example, if the changes are small/trivial, creating a review in
> Upsource is not necessary.
> If the changes are complex and contributor has not created a review,
> reviewer may ask to do so.
> Etc etc.
>
> Thoughts?
>
> On Wed, Nov 16, 2016 at 1:31 PM, Sergi Vladykin <sergi.vladykin@gmail.com>
> wrote:
>
> > Pavel,
> >
> > I'm not sure I understand the term "official code review tool", can you
> > please elaborate it? We will enforce everyone to register in Upsource and
> > use it or what?
> >
> > Sergi
> >
> > 2016-11-16 13:22 GMT+03:00 Pavel Tupitsyn <ptupitsyn@apache.org>:
> >
> > > Proper link to the discussion:
> > > http://apache-ignite-developers.2346864.n4.nabble.com/
> > > Code-Review-Tool-Proposal-Upsource-td12195.html
> > >
> > > On Wed, Nov 16, 2016 at 1:16 PM, Anton Vinogradov <av@apache.org>
> wrote:
> > >
> > > > +1
> > > >
> > > > On Wed, Nov 16, 2016 at 1:08 PM, Pavel Tupitsyn <
> ptupitsyn@apache.org>
> > > > wrote:
> > > >
> > > > > Following the discussion on Upsource [1],
> > > > > I would like to call a vote on accepting it as our official code
> > review
> > > > > tool.
> > > > >
> > > > > [ ] +1  approve
> > > > > [ ] +0  no opinion
> > > > > [ ] -1  disapprove (and reason why)
> > > > >
> > > > > This vote will go on for 5 days.
> > > > >
> > > > > [1] http://apache-ignite-developers.2346864.n4.nabble.
> > > > > com/Code-Review-Tool-Proposal-Upsource-td12195.html
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message