Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
From: Denis Magda <dmagda@gridgain.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 10.0 \(3226\))
Subject: Re: IGNITE-4088
Date: Thu, 20 Oct 2016 08:26:06 -0700
References: <8438211476884803@web28j.yandex.ru>
 <9A86291C-1E65-4BB0-855A-F4D7E21A9E4D@gridgain.com>
 <CAK2_iMPT_sCAew_V+JGOMgq9CoRGyBMvMXHbgKjGxs2uO8rKuw@mail.gmail.com>
 <3908571476975492@web11m.yandex.ru>
To: dev@ignite.apache.org
In-Reply-To: <3908571476975492@web11m.yandex.ru>
Message-Id: <F665470F-FCA9-4646-B602-6DC61C875B00@gridgain.com>
archived-at: Thu, 20 Oct 2016 15:31:46 -0000

Correct, you have to create a PR and check that your changes don=E2=80=99t=
 break anything by running TeamCity. Please refer to this [1] which =
contains all the relevant information.

[1] https://cwiki.apache.org/confluence/display/IGNITE/How+ =
to+Contribute#HowtoContribute-1.CreateGitHubpull-request

> On Oct 20, 2016, at 7:58 AM, =D0=9A=D0=BE=D0=BD=D1=81=D1=82=D0=B0=D0=BD=D1=
=82=D0=B8=D0=BD =D0=94=D1=83=D0=B4=D0=BA=D0=BE=D0=B2 <kdudkov@ya.ru> =
wrote:
>=20
> Have added github branch url to ticket. Should I create PR?
>=20
> 19.10.2016, 20:49, "Pavel Tupitsyn" <ptupitsyn@apache.org>:
>> Hi Konstantin,
>>=20
>> I don't see a patch or a pull request in the JIRA item, am I missing
>> something?
>>=20
>> Pavel.
>>=20
>> On Wed, Oct 19, 2016 at 8:26 PM, Denis Magda <dmagda@gridgain.com> =
wrote:
>>=20
>>>  Hi Kosntantin,
>>>=20
>>>  Thanks for the contribution! Personally, the API looks good from my
>>>  standpoint of view. However the overall contribution has to be =
reviewed my
>>>  Ignite caching maintainers.
>>>=20
>>>  Please learn our development process [1], add new tests that would =
check
>>>  your functionality and send a pull-request to the community [2].
>>>=20
>>>  [1] =
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute <
>>>  =
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute>
>>>  [2] https://cwiki.apache.org/confluence/display/IGNITE/How+
>>>  to+Contribute#HowtoContribute-1.CreateGitHubpull-request <
>>>  https://cwiki.apache.org/confluence/display/IGNITE/How+
>>>  to+Contribute#HowtoContribute-1.CreateGitHubpull-request>
>>>=20
>>>  =E2=80=94
>>>  Denis
>>>=20
>>>  > On Oct 19, 2016, at 6:46 AM, =D0=9A=D0=BE=D0=BD=D1=81=D1=82=D0=B0=D0=
=BD=D1=82=D0=B8=D0=BD =D0=94=D1=83=D0=B4=D0=BA=D0=BE=D0=B2 =
<kdudkov@ya.ru> wrote:
>>>  >
>>>  > Hi,
>>>  >
>>>  > I have done some changes due to jira ticket[1].
>>>  >
>>>  > I have added new method signatures to modules/core/src/main/java/
>>>  org/apache/ignite/Ignite.java:
>>>  >
>>>  > public Collection<IgniteCache> =
createCaches(Collection<CacheConfiguration>
>>>  cacheCfgs);
>>>  > public Collection<IgniteCache> =
getOrCreateCaches(Collection<CacheConfiguration>
>>>  cacheCfgs);
>>>  > public void destroyCaches(Collection<String> cacheNames);
>>>  >
>>>  > Please review and let me know if any changes required.
>>>  >
>>>  > [1] https://issues.apache.org/jira/browse/IGNITE-4088