Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8685D200BA5 for ; Wed, 19 Oct 2016 19:49:50 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 852D1160AEA; Wed, 19 Oct 2016 17:49:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CB862160ADC for ; Wed, 19 Oct 2016 19:49:49 +0200 (CEST) Received: (qmail 28868 invoked by uid 500); 19 Oct 2016 17:49:49 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 28857 invoked by uid 99); 19 Oct 2016 17:49:48 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Oct 2016 17:49:48 +0000 Received: from mail-oi0-f43.google.com (mail-oi0-f43.google.com [209.85.218.43]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id A77601A0143 for ; Wed, 19 Oct 2016 17:49:48 +0000 (UTC) Received: by mail-oi0-f43.google.com with SMTP id t73so39777506oie.1 for ; Wed, 19 Oct 2016 10:49:48 -0700 (PDT) X-Gm-Message-State: AA6/9Rl3qP1Zl9gOpf30oEeVz9pTAxsPXkgH/O9HDUib0WXbFXg3KpBHq9MvjUtfZ1m9CNSNPYYQDzKeWywfaR5c X-Received: by 10.202.191.85 with SMTP id p82mr5193431oif.43.1476899388044; Wed, 19 Oct 2016 10:49:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.46.70 with HTTP; Wed, 19 Oct 2016 10:49:17 -0700 (PDT) In-Reply-To: <9A86291C-1E65-4BB0-855A-F4D7E21A9E4D@gridgain.com> References: <8438211476884803@web28j.yandex.ru> <9A86291C-1E65-4BB0-855A-F4D7E21A9E4D@gridgain.com> From: Pavel Tupitsyn Date: Wed, 19 Oct 2016 20:49:17 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: IGNITE-4088 To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary=001a113dd23264dabe053f3b6f7a archived-at: Wed, 19 Oct 2016 17:49:50 -0000 --001a113dd23264dabe053f3b6f7a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Konstantin, I don't see a patch or a pull request in the JIRA item, am I missing something? Pavel. On Wed, Oct 19, 2016 at 8:26 PM, Denis Magda wrote: > Hi Kosntantin, > > Thanks for the contribution! Personally, the API looks good from my > standpoint of view. However the overall contribution has to be reviewed m= y > Ignite caching maintainers. > > Please learn our development process [1], add new tests that would check > your functionality and send a pull-request to the community [2]. > > [1] https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute = < > https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute> > [2] https://cwiki.apache.org/confluence/display/IGNITE/How+ > to+Contribute#HowtoContribute-1.CreateGitHubpull-request < > https://cwiki.apache.org/confluence/display/IGNITE/How+ > to+Contribute#HowtoContribute-1.CreateGitHubpull-request> > > =E2=80=94 > Denis > > > On Oct 19, 2016, at 6:46 AM, =D0=9A=D0=BE=D0=BD=D1=81=D1=82=D0=B0=D0=BD= =D1=82=D0=B8=D0=BD =D0=94=D1=83=D0=B4=D0=BA=D0=BE=D0=B2 wro= te: > > > > Hi, > > > > I have done some changes due to jira ticket[1]. > > > > I have added new method signatures to modules/core/src/main/java/ > org/apache/ignite/Ignite.java: > > > > public Collection createCaches(Collection > cacheCfgs); > > public Collection getOrCreateCaches(Collection > cacheCfgs); > > public void destroyCaches(Collection cacheNames); > > > > Please review and let me know if any changes required. > > > > [1] https://issues.apache.org/jira/browse/IGNITE-4088 > > --001a113dd23264dabe053f3b6f7a--