Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: <CA+eZwrFAJEwon5ZM533niRhRZ7BP0DXK4a-bT0jTMb8ue5Tcuw@mail.gmail.com>
References: <CAJhSPbriyMVto_GD1wQG0WXJJ09bUof2jju0hpH2_O1bzkdU1A@mail.gmail.com>
 <D77A1A7B-9864-447F-A1E2-1BF1BF418792@gridgain.com> <CA+eZwrF2YEZzAfB5u_7cyrqPrc4BNKBELT7Appw7pxNC3K8dSA@mail.gmail.com>
 <CA+0=VoX0ea6NySsM2qkX0kdVpeuivFX_ip9V=fdmC6-3=A=Oig@mail.gmail.com>
 <CA+eZwrF38d8RgaGQaibE9FnbM=KVPTEGTRSFeMaT=yPwnPLS=g@mail.gmail.com>
 <CA+0=VoVUdp6Bnoyj-TkAp1WruLyZKVVXvG9tz3kdPD-qvBNh2Q@mail.gmail.com>
 <CAJhSPbp1KO6mqL3nSaKCpwCgmOeyKwT4CdYveSoQ1292TXC6zw@mail.gmail.com>
 <CA+eZwrHK4kh=e4B6_NNvMxLeFHJcAt+F9D=t2+5vWJWemJdxgQ@mail.gmail.com>
 <CA+eZwrEfhDxJzjNFU166ErnXWPnXgADWgPJk0YH-SgMHpkzfJg@mail.gmail.com>
 <CAJhSPbq9sGbKmU4e257zanDGzYViovB9qrVPtQnW--afd93QfQ@mail.gmail.com>
 <CA+eZwrFQj_wBdKc_D649DAA7Yhm+hOD03d16872j0Bw=R1DG=A@mail.gmail.com>
 <CA+0=VoVWYR4yKu1hoqgLtcGXShgYR-2g3e4NAK7tE1ADDKPcrg@mail.gmail.com>
 <CAJhSPbonNZ-wF9rFD5xg0cpL4iE8sCwYyJ-G7bsj6pbYuWe_tA@mail.gmail.com>
 <CA+eZwrGCqtzg0B4ee0QyYUKx7iU793-EXpXfd2z8j0q4xpR+KQ@mail.gmail.com>
 <CAJhSPbo7Xi+MfUmoT8xU=NkOiGK3vxh64QAYVsKYq=WaMNYA=g@mail.gmail.com>
 <CA+eZwrFMSqjDY+6_br7FL54WYTqR22RG0v3OXyH=adtUiSAWRg@mail.gmail.com>
 <CAJhSPbpgefej5vn-vEtnznXxt+0EwnFbQv5Cc8TXE99Ei-i1zQ@mail.gmail.com>
 <CA+eZwrEa7uKA4Ssvi9k6+V4yGA-xabDDFzzv80uywqxvL_mQuA@mail.gmail.com>
 <CAJhSPbptSmWxL=PufqqTbskuE5KKbx-jiwwa1e0YzLER-jLgPQ@mail.gmail.com>
 <CA+eZwrGaOUVJMghbakN9LOpkMHX6bTMGbsumTBw3pHqstP-jBA@mail.gmail.com>
 <CAJhSPbquA8=AUiU2KWVYba875DXJBZUz+D=sQ4QSiML_a_wnuA@mail.gmail.com>
 <CAJhSPbq_mr7HMjdSKdToRzqs5oji=yOevHUe9g_2REYtqH0Dvg@mail.gmail.com>
 <CA+eZwrHGir3gQXELyvMiV_z77o2OdizYa9a24nCiUk=_FNfZHA@mail.gmail.com>
 <CAJhSPbpjQcP-Q9TQiii5MDRz6SDqdOEEi2eZZBDP0470eORovw@mail.gmail.com>
 <CA+0=VoVOPt-143n5PUp6W8oBgkiOSJ=hTwMgAvmTXu7Fn_-SRA@mail.gmail.com>
 <CAJhSPbruZkxGW=rUPK0b__6=Fii=vjUkRxW3KyU7gmWERjUojw@mail.gmail.com>
 <CA+0=VoXEKam5kEW1yT9kngBjPWBC-wiNbfnwtY4VaM7Wgowyxw@mail.gmail.com>
 <CAJhSPbqyeTJSiLDRtkx3UOyWW-+YoFCYzY0ShMAmdiWWc6GESg@mail.gmail.com>
 <CABuYRcpm5edG3gyAWRmc7zNJ_MXoROVTX9CpppD2eYGK6wt7sA@mail.gmail.com>
 <CALH+G9ooQSBbRo0eM_UirYa7y6cn1YZERKuZoAYVhWEwri1Dsw@mail.gmail.com>
 <CA+eZwrEX6Wnffwvq0KermtWjPhG9sHE5RSFu63m8YR+buRUZtw@mail.gmail.com> <CA+eZwrFAJEwon5ZM533niRhRZ7BP0DXK4a-bT0jTMb8ue5Tcuw@mail.gmail.com>
From: Sergi Vladykin <sergi.vladykin@gmail.com>
Date: Thu, 4 Aug 2016 09:43:46 +0300
Message-ID: <CA+eZwrHP2jKz582=85bstqeypoYAMRxFpqpm1=+DRQtDEyv7Ng@mail.gmail.com>
Subject: Re: IGNITE-2294 implementation details
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=001a11450586fd4020053939476e
archived-at: Thu, 04 Aug 2016 06:44:44 -0000

--001a11450586fd4020053939476e
Content-Type: text/plain; charset=UTF-8

About new public APIs 2.

QueryCursor.isResultSet makes sense only for SqlFieldsQuery only in Jdbc.
Thus it must be private on QueryCursorEx like fieldsMeta() for example.

All in all, there should be no changes on public API at this point.

Sergi

2016-08-04 9:05 GMT+03:00 Sergi Vladykin <sergi.vladykin@gmail.com>:

> Also about new public APIs. I don't see why we need
> SqlFieldsQuery.isQuery, looks like it has to be optional, so it will only
> confuse users.
>
> Sergi
>
> 2016-08-04 9:00 GMT+03:00 Sergi Vladykin <sergi.vladykin@gmail.com>:
>
>> Why do we need to count query arguments? Can anyone clarify?
>>
>> Sergi
>>
>> 2016-08-04 5:07 GMT+03:00 Alexey Kuznetsov <akuznetsov@gridgain.com>:
>>
>>> About arguments number. I see following options here:
>>> 1. Somehow use H2 engine to parse SQL string and check results.
>>> 2. Use some other parsing library instead  of H2 but this will bring one
>>> more dependency to Ignite.
>>> 3. Write some simple parser by ourselves .
>>>
>>
>>
>

--001a11450586fd4020053939476e--