ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Peralta <patrick.pera...@workday.com>
Subject Re: PR for EntryProcessor/partition event test
Date Tue, 30 Aug 2016 15:32:03 GMT
Thank you Denis - I have updated IGNITE-3789.

On Aug 30, 2016, at 11:28 AM, Denis Magda <dmagda@gridgain.com<mailto:dmagda@gridgain.com>>
wrote:

Hi Patrick,

Please move IGNITE-3789 to ‘PATCH_AVAILABLE’ state. Someone from the community will take
care of the review.

In regards to the failing test like the one below
https://urldefense.proofpoint.com/v2/url?u=http-3A__149.202.210.143-3A8111_viewLog.html-3FbuildId-3D306617-26tab-3DbuildResultsDiv-26buildTypeId-3DIgniteTests-5FIgniteCache3&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=Zj2RbMug3kEGbHVwOEQRi0Ko-AjKDC3fsUn9p8qkMG0&s=1vruH4PfvxHP6_lgO8HdOAzzFh6hMbLolFGj6JAfkoo&e=
 <https://urldefense.proofpoint.com/v2/url?u=http-3A__149.202.210.143-3A8111_viewLog.html-3FbuildId-3D306617-26tab-3DbuildResultsDiv-26buildTypeId-3DIgniteTests-5FIgniteCache3&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=Zj2RbMug3kEGbHVwOEQRi0Ko-AjKDC3fsUn9p8qkMG0&s=1vruH4PfvxHP6_lgO8HdOAzzFh6hMbLolFGj6JAfkoo&e=
>you can ignore it since it’s explicitly being failed with failed(…) call. I muted
this test on TC using Investigate/Mute menu that pops up when you focus on the dropdown arrow
that is to the right from the failed ticket name.

—
Denis

On Aug 26, 2016, at 1:37 PM, Patrick Peralta <patrick.peralta@workday.com<mailto:patrick.peralta@workday.com>>
wrote:

Hello list!

I’ve submitted PR 997 (https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_ignite_pull_997_files&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=Zj2RbMug3kEGbHVwOEQRi0Ko-AjKDC3fsUn9p8qkMG0&s=TsR9pourPOdbWDfto4gac9sJHxXlZRW8541KUpWPNGc&e=
) for IGNITE-3789 (https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_IGNITE-2D3789&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=Zj2RbMug3kEGbHVwOEQRi0Ko-AjKDC3fsUn9p8qkMG0&s=S99RYRJGCbV3peCi220QCBXGT3uVYYOJqYZYNf_1Mx8&e=
). This is a series of tests that are targeted towards behavior related to EntryProcessor
execution while partitions are in flight. I believe this is a test case for IGNITE-3456 (https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_IGNITE-2D3456&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=Zj2RbMug3kEGbHVwOEQRi0Ko-AjKDC3fsUn9p8qkMG0&s=snVj3xtU3WDFe3WyszfNaI8l-S4YZgqqSBTw_wtr6hc&e=
).

As you can see in TeamCity (https://urldefense.proofpoint.com/v2/url?u=http-3A__149.202.210.143-3A8111_viewLog.html-3FbuildId-3D306617-26tab-3DbuildResultsDiv-26buildTypeId-3DIgniteTests-5FIgniteCache3&d=DQIFaQ&c=DS6PUFBBr_KiLo7Sjt3ljp5jaW5k2i9ijVXllEdOozc&r=bv8ec-Kqy0rvHZMrmTEC9X2WWUb1kJfp6qXEP5chI2I&m=Zj2RbMug3kEGbHVwOEQRi0Ko-AjKDC3fsUn9p8qkMG0&s=1vruH4PfvxHP6_lgO8HdOAzzFh6hMbLolFGj6JAfkoo&e=
) the test (predictably) does not pass.

My question is - how do we go about submitting a PR that includes a test that fails for a
known issue? Should I comment out the fail() invocation with a TODO pointing to the JIRA?

Thanks!


Patrick Peralta
Senior Software Engineer
Workday, Inc.
617-852-8388 (mobile)
patrick.peralta@workday.com<mailto:patrick.peralta@workday.com><mailto:patrick.peralta@workday.com>



Patrick Peralta
Senior Software Engineer
Workday, Inc.
617-852-8388 (mobile)
patrick.peralta@workday.com<mailto:patrick.peralta@workday.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message