ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergi Vladykin <sergi.vlady...@gmail.com>
Subject Re: JetBrains Annotaions usage.
Date Thu, 28 Jul 2016 08:17:23 GMT
I don't think that JB annotations is a runtime dependency, we should need
them only at compile time, no?

Sergi

2016-07-28 11:09 GMT+03:00 Anton Vinogradov <av@apache.org>:

> Igniters,
>
> As you may know we had only 2 dependencies at ignite-core: jcache and
> ignite-shmen.
>
> IGNITE-3323 Get rid of copypasted JB annotations, use dependency instead.
> <https://issues.apache.org/jira/browse/IGNITE-3323> brings one more
> dependency to org.jetbrains.annotations.
> This solves problems for people using JB annotations at their projects. but
> makes ignite-core less dependency-lightweight.
>
> JB annotaions are used to highlight null problems in IDE and provide some
> understanding to users on whether null is allowed/possible in concrete
> place. I doubt other products/frameworks use it much.
>
> But, do we really need them? As for me, we can replace all these
> annotations by asserts.
>
> I propose to discontinue usage of jb annotation and replace them by
> asserts.
>
> Thoughts?
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message