ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dmitriy Setrakyan <dsetrak...@apache.org>
Subject Re: IGNITE-3055
Date Tue, 12 Jul 2016 10:54:36 GMT
Thanks Vlad.

At a high level, the changes look OK. However, I am not sure about
TimeoutException. Don’t we already have other timeout exceptions in Ignite?
Can we reuse them?

D.

On Tue, Jul 12, 2016 at 1:51 PM, Vladislav Pyatkov <vpyatkov@gridgain.com>
wrote:

> Dmitriy,
>
> I have added the description of changes in the JIRA ticket.
>
> On Tue, Jul 12, 2016 at 1:28 PM, Dmitriy Setrakyan <dsetrakyan@apache.org>
> wrote:
>
> > Hi Vlad,
> >
> > Can you please list the API changes in the ticket, so others can review
> > without digging in code?
> >
> > Thanks,
> > D.
> >
> > On Mon, Jul 11, 2016 at 1:14 PM, Vladislav Pyatkov <
> vpyatkov@gridgain.com>
> > wrote:
> >
> > > Igniters,
> > >
> > > I have implemented timeout in DataStreamer by issue IGNITE-3055
> > > <https://issues.apache.org/jira/browse/IGNITE-3055
> >(*IgniteDataStreamer
> > > can't be timed out*).
> > >
> > > That lead the change public API:
> > >
> > > 1) Added set and get methods (IgniteDataStreamer.timeout(long) and
> > > IgniteDataStreamer.timeout()) for establish. Default value is -1, means
> > > unlimited time.
> > >
> > > 2) Added new TimeoutException (inherited IgniteException). The
> exception
> > > will thrown when timeout will be reached (may be take place in
> > > IgniteDataStreamer.addData, IgniteDataStreamer.close and
> > > IgniteDataStreamer.flash operations).
> > >
> > > Dmitry, colleagues, please comment or approve.
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message