ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Valentin Kulichenko <valentin.kuliche...@gmail.com>
Subject Re: [apache/ignite] [IGNITE-2929] IgniteContext should not have type parameters (#740)
Date Wed, 25 May 2016 10:12:19 GMT
I think we should change it anyway, because it looks like each new user of
IgniteRDD is confused by this issue. Basically, we require to create
separate IgniteContext for each IgniteRDD, which is counterintuitive and is
not consistent with Spark APIs.

Yes, the upgrade to the next version of Ignite will require a minor code
change for existing users, but the current API is wrong and I think we
should fix it.

Any other opinions?

-Val

On Tue, May 24, 2016 at 9:29 PM, Alexey Goncharuk <
alexey.goncharuk@gmail.com> wrote:

> Folks,
>
> The PR looks good to me. There is one concern - even though the type
> parameters were placed to IgniteContext by mistake, removing them will
> break backward compatibility. Are we ok with that?
>
> Val, can you comment?
>
> 2016-05-21 8:32 GMT-07:00 MaBiao <notifications@github.com>:
>
> > @agoncharuk <https://github.com/agoncharuk> Would you please help me to
> > review this PR?
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly or view it on GitHub
> > <https://github.com/apache/ignite/pull/740#issuecomment-220784081>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message