Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CA+eZwrGJm5znbyoOKFSe2t5FAhgXQKTyQKBkBB0ERtKrREFwEw@mail.gmail.com>
References: <56D8260E.2020305@gridgain.com> <20160305034307.GU24049@tpx>
 <CA+eZwrESvBz3h8RBK2Wm9hdsjXofrY4vzxcLjJYiWXKstEWMEg@mail.gmail.com>
 <CA+eZwrHW9f=yykBtvPqE+03BYqvDSfEa6bVeCdWzH-D4=UfkZw@mail.gmail.com>
 <56EFF92F.5000702@gridgain.com>
 <CA+eZwrGJm5znbyoOKFSe2t5FAhgXQKTyQKBkBB0ERtKrREFwEw@mail.gmail.com>
From: Pavel Tupitsyn <ptupitsyn@gridgain.com>
Date: Mon, 21 Mar 2016 18:14:08 +0300
Message-ID: 
 <CAK2_iMOcME1Q-1E=jbqSo9FS-Dp4NN3VNBjdiRb4k1uLVFwEJQ@mail.gmail.com>
Subject: Re: Switching back to review-then-commit process
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=001a11352ed8199414052e908e2c

--001a11352ed8199414052e908e2c
Content-Type: text/plain; charset=UTF-8

Suspicious entries:
* C++ API Ivan Veselovsky
* Docker, Mesos, YARN integration Igor Sapego

On Mon, Mar 21, 2016 at 6:08 PM, Sergi Vladykin <sergi.vladykin@gmail.com>
wrote:

> Looks good.
>
> Sergi
>
> 2016-03-21 16:37 GMT+03:00 Denis Magda <dmagda@gridgain.com>:
>
> > Igniters,
> >
> > I've prepared a draft of the maintainers list.
> >
> >
> https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers
> >
> > Please review it and/or adjust it whenever is needed.
> >
> > If you have any thoughts, concerns let's discuss them there.
> >
> > --
> > Denis
> >
> > On 3/10/2016 1:37 PM, Sergi Vladykin wrote:
> >
> >> If everyone is ok with the proposals, then we need to set this new
> >> approach
> >> and properly document it.
> >>
> >> Also we need to select list of RTC modules and elect their maintainers.
> >>
> >> Sergi
> >>
> >> 2016-03-05 19:31 GMT+03:00 Sergi Vladykin <sergi.vladykin@gmail.com>:
> >>
> >> +1 to the original proposal of Denis to introduce module maintainers and
> >>> RTC process
> >>> +1 to the proposal of Raul to restrict number of core modules, which
> >>> require maintainers review
> >>>
> >>> Sergi
> >>>
> >>>
> >>> 2016-03-05 6:43 GMT+03:00 Konstantin Boudnik <cos@apache.org>:
> >>>
> >>> It saddens me to see this coming to it ;(
> >>>>
> >>>> On Thu, Mar 03, 2016 at 02:54PM, Denis Magda wrote:
> >>>>
> >>>>> Igniters,
> >>>>>
> >>>>> I would propose to switch back to review-then-commit process. This
> >>>>> process has to be followed by both contributors and committers.
> >>>>>
> >>>>> There is a reason for this I have in mind. Ignite is a complex
> >>>>> platform with several big modules. Some of the people may be experts
> >>>>> in module A while others in module B etc.
> >>>>> If a committer, who is good in module A, makes changes in module B
> >>>>> merging the changes without a review this can break module's B
> >>>>> internal functionality that the committer didn't take into account.
> >>>>>
> >>>>> My proposal is to introduce a list of maintainers for every Ignite
> >>>>> module like it's done in Spark [1] and a rule that will require a
> >>>>> committer to get an approval from a module maintainer before merging
> >>>>> changes.
> >>>>>
> >>>>> Thoughts?
> >>>>>
> >>>>> --
> >>>>> Denis
> >>>>>
> >>>>> [1]
> >>>>>
> >>>>
> >>>>
> https://cwiki.apache.org/confluence/display/SPARK/Committers#Committers-ReviewProcessandMaintainers
> >>>>
> >>>>>
> >>>>>
> >>>>>
> >>>
> >
>

--001a11352ed8199414052e908e2c--