ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergi Vladykin <sergi.vlady...@gmail.com>
Subject Re: Switching back to review-then-commit process
Date Thu, 10 Mar 2016 10:37:12 GMT
If everyone is ok with the proposals, then we need to set this new approach
and properly document it.

Also we need to select list of RTC modules and elect their maintainers.

Sergi

2016-03-05 19:31 GMT+03:00 Sergi Vladykin <sergi.vladykin@gmail.com>:

> +1 to the original proposal of Denis to introduce module maintainers and
> RTC process
> +1 to the proposal of Raul to restrict number of core modules, which
> require maintainers review
>
> Sergi
>
>
> 2016-03-05 6:43 GMT+03:00 Konstantin Boudnik <cos@apache.org>:
>
>> It saddens me to see this coming to it ;(
>>
>> On Thu, Mar 03, 2016 at 02:54PM, Denis Magda wrote:
>> > Igniters,
>> >
>> > I would propose to switch back to review-then-commit process. This
>> > process has to be followed by both contributors and committers.
>> >
>> > There is a reason for this I have in mind. Ignite is a complex
>> > platform with several big modules. Some of the people may be experts
>> > in module A while others in module B etc.
>> > If a committer, who is good in module A, makes changes in module B
>> > merging the changes without a review this can break module's B
>> > internal functionality that the committer didn't take into account.
>> >
>> > My proposal is to introduce a list of maintainers for every Ignite
>> > module like it's done in Spark [1] and a rule that will require a
>> > committer to get an approval from a module maintainer before merging
>> > changes.
>> >
>> > Thoughts?
>> >
>> > --
>> > Denis
>> >
>> > [1]
>> https://cwiki.apache.org/confluence/display/SPARK/Committers#Committers-ReviewProcessandMaintainers
>> >
>> >
>> >
>>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message