Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B56211844F for ; Fri, 12 Feb 2016 19:07:55 +0000 (UTC) Received: (qmail 22697 invoked by uid 500); 12 Feb 2016 19:07:55 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 22660 invoked by uid 500); 12 Feb 2016 19:07:55 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 22649 invoked by uid 99); 12 Feb 2016 19:07:55 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Feb 2016 19:07:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 007D91A0551 for ; Fri, 12 Feb 2016 19:07:55 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.499 X-Spam-Level: X-Spam-Status: No, score=0.499 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LNQrWANgU_5R for ; Fri, 12 Feb 2016 19:07:54 +0000 (UTC) Received: from mail-ob0-f171.google.com (mail-ob0-f171.google.com [209.85.214.171]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id 59E5324EB7 for ; Fri, 12 Feb 2016 19:07:53 +0000 (UTC) Received: by mail-ob0-f171.google.com with SMTP id xk3so134217522obc.2 for ; Fri, 12 Feb 2016 11:07:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-type:content-transfer-encoding; bh=34hF0mRvJwr7SigvQchoTWHf8Q1b+pC/OD91EKcYP44=; b=JukhDv+avHnEexwBRwESN/3cNbBBTnTTQxN3JUjZLND9sqaFiRxWYGJkYLQyuoqxNI AfOWnH+5z9EbKZemlxPUf95P1EFXfdrmgP6hYSwiBgnWGKerBwrnIabvvJGfQpBVRkqQ siUuEEBdTdha7kT1UFmct0N+4fTC+iBRmoXtfgleqB/dClsGWlu21HD0ANiWvlozbQNN LnzD2o0y5kPpRMj8gQ8VzSw7Ug68Q/mgasszW5fCv1E0VpV511ORuN+ojfHL87pzoTIx ShRgwpQQS8Jm0GkhFT/81CDocr82C4iromMJE7FV57heiAChGInurhSUH2K2ZxaHLKj+ qU4A== X-Gm-Message-State: AG10YOR60AKpsgUlMw17/YHbNHXz7hVIGHNdxcLe4y+EvNXtv9CaE3Pms2RyctdPO8j+3g== X-Received: by 10.182.213.7 with SMTP id no7mr2655649obc.22.1455304072312; Fri, 12 Feb 2016 11:07:52 -0800 (PST) Received: from [192.168.1.219] ([216.243.244.95]) by smtp.gmail.com with ESMTPSA id dd6sm9261061obb.3.2016.02.12.11.07.51 for (version=TLSv1/SSLv3 cipher=OTHER); Fri, 12 Feb 2016 11:07:51 -0800 (PST) To: dev@ignite.apache.org From: Dood@ODDO Subject: Async and sync ops in IgniteQueue and IgniteSet implementations Message-ID: <56BE2D89.4040204@gmail.com> Date: Fri, 12 Feb 2016 13:07:53 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello all, This may be a very dumb question (and feel free to "reprimand" me ;-) but I will ask it anyways. I am working on https://issues.apache.org/jira/browse/IGNITE-1144 and one of the comments on the submitted code was that I marked both methods I am implemented as @IgniteAsyncSupported but I never actually provided an async implementation. All my methods do is call on methods already implemented in IgniteCompute.java (after verifying that the methods are called on data structures that are collocated) and my assumption was that the methods being called are already implemented in async/sync versions. Specifically, these methods are affinityRun() and affinityCall(). Furthermore, I noticed the following comment in IgniteQueue.java, for example: ""* All queue operations have synchronous and asynchronous counterparts."". However, after looking at all the implementations of IgniteQueue interface in the code base, I could not find any actual implementations of asynchronous calls on any methods of queue or set. Am I just missing something really basic? Thanks!