ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ken Cheng <kcheng....@gmail.com>
Subject Re: PR : Please help do the code review for IGNITE-1069
Date Mon, 01 Feb 2016 03:36:46 GMT
Hi Alexey,

Thank you very much!

but I noticed the PR https://github.com/apache/ignite/pull/440 is still at
open status

Thanks,
kcheng

On Mon, Feb 1, 2016 at 11:16 AM, Alexey Kuznetsov <akuznetsov@gridgain.com>
wrote:

> Ken,
>
> I done with review, all looks good, I merged your PR to master.
> Thanks for your contribution.
>
>
> On Sat, Jan 30, 2016 at 11:19 PM, Ken Cheng <kcheng.mvp@gmail.com> wrote:
>
> > Hi Alexey Kuznetsov,
> >
> > *All the related test cases are passed, please check the detail in jira.
> I
> > have paste the build link.*
> >
> > Thanks,
> > kcheng
> >
> > On Sat, Jan 30, 2016 at 7:03 PM, Alexey Kuznetsov <
> akuznetsov@gridgain.com
> > >
> > wrote:
> >
> > > Hi Ken!
> > > I will review you PR shortly.
> > >
> > >
> > > On Sat, Jan 30, 2016 at 4:03 PM, Denis Magda <dmagda@gridgain.com>
> > wrote:
> > >
> > > > Hi Ken,
> > > >
> > > > I think that Alex Kuznetsov as a maintainer of visorcmd will be able
> to
> > > > review your contribution.
> > > >
> > > > Regards,
> > > > Denis
> > > >
> > > > > On 30 янв. 2016 г., at 11:59, Ken Cheng <kcheng.mvp@gmail.com>
> > wrote:
> > > > >
> > > > > @Ilya Suntsov
> > > > > <https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ustas
> >,
> > > > >
> > > > > You logged this issue, please help to reivew it. Thanks.
> > > > >
> > > > > Thanks,
> > > > > kcheng
> > > > >
> > > > > On Sat, Jan 30, 2016 at 4:10 PM, Ken Cheng <kcheng.mvp@gmail.com>
> > > wrote:
> > > > >
> > > > >>
> > > > >> Dear Ignite Developers,
> > > > >>
> > > > >>
> > > > >> I have raised a PR https://github.com/apache/ignite/pull/440
for
> > bug
> > > > >> https://issues.apache.org/jira/browse/IGNITE-1069
> > > > >>
> > > > >>
> > > > >> please help do a code review.
> > > > >>
> > > > >>
> > > > >>
> > > > >> Thanks,
> > > > >> kcheng
> > > > >>
> > > >
> > > >
> > >
> > >
> > > --
> > > Alexey Kuznetsov
> > > GridGain Systems
> > > www.gridgain.com
> > >
> >
>
>
>
> --
> Alexey Kuznetsov
> GridGain Systems
> www.gridgain.com
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message