ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dood@ODDO <oddodao...@gmail.com>
Subject Re: IGNITE-1144
Date Tue, 23 Feb 2016 05:13:57 GMT
Val,

All the test passed on TC - you can look at the PR at any time. Thanks!

On 2/22/2016 8:13 PM, Valentin Kulichenko wrote:
> Hi,
>
> Thanks for the pull request! I will take a look as soon as possible.
>
> -Val
>
> On Mon, Feb 22, 2016 at 9:14 AM, Dood@ODDO <oddodaoddo@gmail.com> wrote:
>
>> Hello all,
>>
>> I was wondering if anyone can take a look at the PR I submitted for
>> IGNITE-1144 [1]. It compiles and I think the code is good but the tests I
>> submitted are failing - specifically, one test: I am using assertThrows()
>> to make sure that an exception is thrown if affinityRun() is invoked on a
>> queue that is not collocated. In the tests I basically set up a queue that
>> has a configuration that invokes setCollocated(false) and then I invoke an
>> affinityRun() with an "empty" job. For some reason the tests are failing
>> with an error that the exception wasn't thrown. However, in this case I
>> actually think that my test is bad and the PR code is good ;-). Can someone
>> with more Java experience take a quick look?
>>
>> Thanks!
>>
>> [1] https://issues.apache.org/jira/browse/IGNITE-1144
>>


Mime
View raw message