Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CA+0=VoVdhSHVFU1rALVpMKEWPsj0XkZsWd-KnAoY074Ku1P2uw@mail.gmail.com>
References: 
 <CAGcMBHiUWVCMPkFQBjxaXtLWfdMD+Mf7s1ZCY_mLvrULwtFOGg@mail.gmail.com>
	<CAGt6o8=ANk1hngY7qQGs1d3dAcaXnZhSOEhTWoVfZHwz3Lfd1A@mail.gmail.com>
	<CA+0=VoVdhSHVFU1rALVpMKEWPsj0XkZsWd-KnAoY074Ku1P2uw@mail.gmail.com>
Date: Fri, 15 Jan 2016 15:10:17 +0300
Message-ID: 
 <CAGcMBHiksuErXnc0EBxxMHDEnzPSceEaP=9Do0qZscd8CvhyuQ@mail.gmail.com>
Subject: Re: GridFutureAdapter: deprecate startTime(),
 duration() and endTime()
From: Yakov Zhdanov <yzhdanov@apache.org>
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=047d7b3a8ac054c56b05295e49aa

--047d7b3a8ac054c56b05295e49aa
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

All of optimizations applied to futures so far were extremely effective.
Ignite can create different number of futures per operation depending on
context. Multiple this by ops/sec.. This is probably one of the most
intensively instantiated (and therefore GCed) object. Internal futures is
very sensitive part of the system and should be 100% effective.

As far as public API, anyone
uses org.apache.ignite.lang.IgniteFuture#startTime
or org.apache.ignite.lang.IgniteFuture#duration?

--Yakov

2016-01-15 1:20 GMT+03:00 Dmitriy Setrakyan <dsetrakyan@apache.org>:

> Really hard to believe that removing 16 bytes in futures gives 5% of
> performance. Yakov, are you certain about this?
>
> If this turns out to be true, let=E2=80=99s see if we can slim down the f=
utures
> used internally, without breaking the public API.
>
> D.
>
> On Thu, Jan 14, 2016 at 8:36 AM, Vladimir Ozerov <vozerov@gridgain.com>
> wrote:
>
> > +1
> >
> > BTW, corresponding ticket already exists. You can find it under umbrell=
a
> > ticket IGNITE-2232
> > 14 =D1=8F=D0=BD=D0=B2. 2016 =D0=B3. 18:40 =D0=BF=D0=BE=D0=BB=D1=8C=D0=
=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C "Yakov Zhdanov" <yzhdanov@apa=
che.org>
> > =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:
> >
> > > Guys,
> > >
> > > We have startTime(), duration() and endTime() methods which have
> several
> > > usages each along internals of the project, but to support these
> methods
> > we
> > > have 2 long fields in GridFutureAdapter which gives us 16 bytes.
> > >
> > > Other fields - res (reference 8 bytes at max), ignoreInterrupts
> (boolean
> > 1
> > > byte) and resFlag (byte 1 byte) =3D 10 bytes
> > >
> > > I did quick tests and I see that removing these fields (i.e. making
> each
> > > future 16 bytes thinner) can give us 5-6% in performance results.
> > >
> > > I want to deprecate  startTime(), duration() and endTime() and
> therefore
> > > deprecate corresponding methods in IgniteFuture.
> > >
> > > Thoughts?
> > >
> > > --Yakov
> > >
> >
>

--047d7b3a8ac054c56b05295e49aa--