Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ignite.apache.org
MIME-Version: 1.0
Date: Mon, 14 Dec 2015 15:01:36 +0300
Message-ID: 
 <CAGcMBHgR7tsbNTqA1JP8DHbqphRPOgsoxfyHO75mmiQ9ooirCA@mail.gmail.com>
Subject: Debug Output in Prod
From: Yakov Zhdanov <yzhdanov@apache.org>
To: dev@ignite.apache.org
Content-Type: multipart/alternative; boundary=001a11401aec6261ee0526da6f28

--001a11401aec6261ee0526da6f28
Content-Type: text/plain; charset=UTF-8

Guys,

I noticed the following code in repo several days
ago(org/apache/ignite/internal/portable/BinaryWriterExImpl.java:1810):


out.unsafeEnsure(1 + 4);

out.unsafeWriteByte(GridPortableMarshaller.HANDLE);
out.unsafeWriteInt(pos - old);

if (obj.getClass().isArray())
    System.out.println("CASE!");

return true;

Couple of points here:

1. When putting debug output to production code use U.debug(). This method
gives at least deprecation warning which can be caught and debug printouts
will not get to the repo + it prints timestamp and thread name.
2. Can we change release build to fail if U.debug() is somewhere in
production code? Anton V, perhaps you know how to achieve that?

--Yakov

--001a11401aec6261ee0526da6f28--