ignite-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yakov Zhdanov <yzhda...@apache.org>
Subject Re: store examples
Date Wed, 16 Dec 2015 14:35:11 GMT
Guys,

I refactored JDBC store example to use h2 server startup.

I decided to remove spring store example since code will be too complex
after fixing all issues with transactions along with jdbcTemplate (current
code absolutely ignores txs)
+ I removed dummy example as per Val's suggestion.

--Yakov

2015-12-16 9:23 GMT+03:00 Dmitriy Setrakyan <dsetrakyan@apache.org>:

> Got it. Yakov, I think this will work without any coding change. Can you
> confirm?
>
> On Tue, Dec 15, 2015 at 6:30 PM, Alexey Kuznetsov <akuznetsov@gridgain.com
> >
> wrote:
>
> > I think mentioned examples could be easily fixed by switching from use of
> > H2 started from example to o.a.i.examples.util.DbH2ServerStartup.
> > This will start full fledged H2 server with in-memory db and all nodes
> will
> > work with it.
> >
> > >> Ignite nodes, then why not switch to using H2 disk store?
> > Dima, this would not work, because file will be locked by first started
> > process and other will failed.
> >
> > I think we should go as I mentioned above.
> >
> >
> > On Wed, Dec 16, 2015 at 7:23 AM, Dmitriy Setrakyan <
> dsetrakyan@apache.org>
> > wrote:
> >
> > > If the problem is the H2 in-memory store not being shared between
> > multiple
> > > Ignite nodes, then why not switch to using H2 disk store?
> > >
> > > On Tue, Dec 15, 2015 at 4:11 PM, Valentin Kulichenko <
> > > valentin.kulichenko@gmail.com> wrote:
> > >
> > > > As far as I understand, the issue is that CacheJdbcStoreExample
> > > > and CacheSpringStoreExample use in-memory H2 database, so the cache
> > store
> > > > is not shared among nodes. What if we just switch to a file-based DB?
> > It
> > > > looks like a simple change to me.
> > > >
> > > > And I would remove CacheDummyStoreExample. It looks weird and doesn't
> > > > demonstrate anything that is not shown in other store examples.
> > > >
> > > > -Val
> > > >
> > > > On Tue, Dec 15, 2015 at 2:03 PM, Dmitriy Setrakyan <
> > > dsetrakyan@apache.org>
> > > > wrote:
> > > >
> > > > > I think we should fix all the examples. What has changed that makes
> > > these
> > > > > examples so difficult to fix?
> > > > >
> > > > > I really do not like removing the examples that have been
> > continuously
> > > > > shipped in every release. If it is so difficult for us to upgrade
> > them
> > > to
> > > > > 1.5, how difficult will it be for our users?
> > > > >
> > > > > D.
> > > > >
> > > > > On Tue, Dec 15, 2015 at 7:24 AM, Yakov Zhdanov <
> yzhdanov@apache.org>
> > > > > wrote:
> > > > >
> > > > > > We still have very advanced and cool CacheBinaryAutoStoreExample
> > and
> > > it
> > > > > > works properly
> > > > > >
> > > > > > --Yakov
> > > > > >
> > > > > > 2015-12-15 18:11 GMT+03:00 Dmitriy Setrakyan <
> > dsetrakyan@apache.org
> > > >:
> > > > > >
> > > > > > > If it is an example issue, why can’t we fix the examples?
I am
> > not
> > > > > > > comfortable removing CacheJdbcStoreExample from the release.
> > > > > > >
> > > > > > > On Tue, Dec 15, 2015 at 4:02 AM, Yakov Zhdanov <
> > > yzhdanov@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > https://issues.apache.org/jira/browse/IGNITE-2158
> > > > > > > >
> > > > > > > > Guys,
> > > > > > > >
> > > > > > > > It seems that CacheDummyStoreExample, CacheJdbcStoreExample
> and
> > > > > > > > CacheSpringStoreExample do not work correctly in distributed
> > > > > > environment
> > > > > > > > after code modifications to demonstrate clear() and
> > > withSkipStore()
> > > > > > > >
> > > > > > > > This is an old issue and it is 100% examples' issue,
so I
> > suggest
> > > > > > > removing
> > > > > > > > them from 1.5 and fix and return back to distro in
1.6
> > > > > > > >
> > > > > > > > Thoughts?
> > > > > > > >
> > > > > > > > --Yakov
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Alexey Kuznetsov
> > GridGain Systems
> > www.gridgain.com
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message