Return-Path: X-Original-To: apmail-ignite-dev-archive@minotaur.apache.org Delivered-To: apmail-ignite-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EB2A418F06 for ; Fri, 13 Nov 2015 17:19:34 +0000 (UTC) Received: (qmail 60432 invoked by uid 500); 13 Nov 2015 17:19:34 -0000 Delivered-To: apmail-ignite-dev-archive@ignite.apache.org Received: (qmail 60386 invoked by uid 500); 13 Nov 2015 17:19:34 -0000 Mailing-List: contact dev-help@ignite.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ignite.apache.org Delivered-To: mailing list dev@ignite.apache.org Received: (qmail 60374 invoked by uid 99); 13 Nov 2015 17:19:34 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Nov 2015 17:19:34 +0000 Received: from mail-lb0-f177.google.com (mail-lb0-f177.google.com [209.85.217.177]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id EDF2B1A0648 for ; Fri, 13 Nov 2015 17:19:33 +0000 (UTC) Received: by lbbsy6 with SMTP id sy6so28987695lbb.2 for ; Fri, 13 Nov 2015 09:19:32 -0800 (PST) X-Gm-Message-State: ALoCoQnuC3prPPZt8tRe4DImv/z344N6Z9b13Vm8Fcga6jQ4ZNdFklF/saIzDhoQzGfW698nhVBX X-Received: by 10.112.150.225 with SMTP id ul1mr10568198lbb.47.1447435172356; Fri, 13 Nov 2015 09:19:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.112.29.50 with HTTP; Fri, 13 Nov 2015 09:19:12 -0800 (PST) X-Originating-IP: [85.155.76.117] In-Reply-To: References: From: Raul Kripalani Date: Fri, 13 Nov 2015 17:19:12 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Check Ignite code base with Findbugs. To: dev@ignite.apache.org Content-Type: multipart/alternative; boundary=047d7b3435de48bf4b05246f438f --047d7b3435de48bf4b05246f438f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, Nov 13, 2015 at 4:51 PM, Alexey Kuznetsov wrote: > Raul, I'm afraid it will produce 100500 false-positive warnings. > Yep, it's likely. I think we need to investigate what will be generated by FB tune it and > then decide to include it or not into maven build. > Exactly. We should do a trial run, tune the configuration and include it once we have no warnings. That would be our baseline. I'm not sure what the benefit of FindBugs will be in the long-run, though. I like the idea as long as it brings more benefits rather than hindrances. Ignite's codebase is quite special. If we find that FB is too prone to report false positives for us, we might as well discard the idea altogether. If we do find a few bugs thanks to it during our baseline runs, then I'm all for it. > Or may be we could have it as optional step (it is possible?). > Yep, doable through a Maven profile. Regards, *Ra=C3=BAl Kripalani* PMC & Committer @ Apache Ignite, Apache Camel | Integration, Big Data and Messaging Engineer http://about.me/raulkripalani | http://www.linkedin.com/in/raulkripalani http://blog.raulkr.net | twitter: @raulvk --047d7b3435de48bf4b05246f438f--